[Bug 27321] The js used for Special:Preferences tabs is broken in debug mode

2011-02-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27321

LordAndrew reachouttothetr...@hotmail.com changed:

   What|Removed |Added

 CC||reachouttothetruth@hotmail.
   ||com

--- Comment #1 from LordAndrew reachouttothetr...@hotmail.com 2011-02-11 
15:20:01 UTC ---
The search box, the editing toolbar, and probably other JavaScript stuff is
also broken in debug mode. I tried hunting this down yesterday, but failed to
discover the origin of the problem. I'll keep looking.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 27321] The js used for Special:Preferences tabs is broken in debug mode

2011-02-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27321

Mark A. Hershberger m...@everybody.org changed:

   What|Removed |Added

 CC||m...@everybody.org
 Blocks||26611

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 27321] The js used for Special:Preferences tabs is broken in debug mode

2011-02-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27321

Brion Vibber br...@pobox.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|tpars...@wikimedia.org  |br...@pobox.com

--- Comment #2 from Brion Vibber br...@pobox.com 2011-02-12 01:23:21 UTC ---
I'll take a peek; I was poking at prefs recently.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 27321] The js used for Special:Preferences tabs is broken in debug mode

2011-02-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27321

Krinkle krinklem...@gmail.com changed:

   What|Removed |Added

 CC||krinklem...@gmail.com

--- Comment #3 from Krinkle krinklem...@gmail.com 2011-02-12 01:28:08 UTC ---
Not related to preference script. in trunk no javascript is loaded at all
except for jquery and the module implementation calls.

The script that adds the individual script tags
(mw.loader.load('/w/resources') is not adding the tags.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 27321] The js used for Special:Preferences tabs is broken in debug mode

2011-02-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27321

--- Comment #4 from Brion Vibber br...@pobox.com 2011-02-12 01:37:29 UTC ---
Created attachment 8130
  -- https://bugzilla.wikimedia.org/attachment.cgi?id=8130
Provisional fix to mediawiki.load

This fixes it for me, but I'm not sure it's the correct fix.

In debug mode, the loader chunks get replaced with attempts to load the
specific URLs; however only module names beginning with 'http:' or 'https:'
actually get loaded this way. Since we were receiving local urls like this:

  mediaWiki.loader.implement(mediawiki.legacy.mwsuggest, function( $, mw ) {
mediaWiki.loader.load(/trunk/skins/common/mwsuggest.js);

they were getting added to a modules list and then just never work.

Checking also for module names that start with / and loading them as local
URLs appears to work, but I'm not sure if it's wise. Should full URLs be used
instead?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 27321] The js used for Special:Preferences tabs is broken in debug mode

2011-02-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27321

--- Comment #5 from Brion Vibber br...@pobox.com 2011-02-12 01:46:07 UTC ---
Bug caused by regression in r81731; added a note on code review there to check
whether reverting that or adding this is better fix.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l