[Bug 27449] Regex in JavascriptDistiller causes stack overflow on windows
https://bugzilla.wikimedia.org/show_bug.cgi?id=27449 P.Copp changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #8 from P.Copp 2011-03-14 16:25:08 UTC --- (In reply to comment #6) > Tim recently changed the regex to be multiline and use . instead of > (.|[\r\n]). > Does this fix the issue? Yes. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27449] Regex in JavascriptDistiller causes stack overflow on windows
https://bugzilla.wikimedia.org/show_bug.cgi?id=27449 --- Comment #7 from Trevor Parscal 2011-02-22 19:01:58 UTC --- Just to help keep things in sync... In bug #27528 an entirely new alternative to JavaScriptDistiller called JavaScriptMinifier is proposed, which if used may close this bug. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27449] Regex in JavascriptDistiller causes stack overflow on windows
https://bugzilla.wikimedia.org/show_bug.cgi?id=27449 --- Comment #6 from Roan Kattouw 2011-02-20 20:03:32 UTC --- Tim recently changed the regex to be multiline and use . instead of (.|[\r\n]). Does this fix the issue? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27449] Regex in JavascriptDistiller causes stack overflow on windows
https://bugzilla.wikimedia.org/show_bug.cgi?id=27449 --- Comment #5 from Aaron Schulz 2011-02-16 11:37:56 UTC --- (In reply to comment #4) > (In reply to comment #1) > > See > > http://old.nabble.com/ResourceLoader-%2B-Windows-%2B-PHP-bug-47689-to30792236.html > > Right, that's where I saw this. However, the suggested fix to increase the > stack size only solves the symptom, while I don't think it's necessary to use > regexes which need recursion depth proportional to the length of the string > passed. Fair enough. I am a bit worried that the more things use RL, the more easily it will overflow. It's something to be looked at. It apparently needs the capture (of the code comments), which will get worse an worse as the input lengthens. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27449] Regex in JavascriptDistiller causes stack overflow on windows
https://bugzilla.wikimedia.org/show_bug.cgi?id=27449 --- Comment #4 from P.Copp 2011-02-16 11:32:11 UTC --- (In reply to comment #1) > See > http://old.nabble.com/ResourceLoader-%2B-Windows-%2B-PHP-bug-47689-to30792236.html Right, that's where I saw this. However, the suggested fix to increase the stack size only solves the symptom, while I don't think it's necessary to use regexes which need recursion depth proportional to the length of the string passed. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27449] Regex in JavascriptDistiller causes stack overflow on windows
https://bugzilla.wikimedia.org/show_bug.cgi?id=27449 --- Comment #3 from Aaron Schulz 2011-02-16 11:22:48 UTC --- (In reply to comment #2) > I see nothing wrong with the regex itself... is this a configuration error or > a > bug in PHP? See comment #1 and http://www.mediawiki.org/wiki/Apache_configuration#Thread_stack_size. It's a default config issue in apache. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27449] Regex in JavascriptDistiller causes stack overflow on windows
https://bugzilla.wikimedia.org/show_bug.cgi?id=27449 --- Comment #2 from Liangent 2011-02-16 11:21:28 UTC --- I see nothing wrong with the regex itself... is this a configuration error or a bug in PHP? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27449] Regex in JavascriptDistiller causes stack overflow on windows
https://bugzilla.wikimedia.org/show_bug.cgi?id=27449 Aaron Schulz changed: What|Removed |Added CC||jschulz_4...@msn.com --- Comment #1 from Aaron Schulz 2011-02-16 11:19:20 UTC --- See http://old.nabble.com/ResourceLoader-%2B-Windows-%2B-PHP-bug-47689-to30792236.html -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
