[Bug 27606] 'from' parameter of rollback urls in the web interface include '+' signs (wrong encoding)
https://bugzilla.wikimedia.org/show_bug.cgi?id=27606 Krinkle changed: What|Removed |Added CC|krinklem...@gmail.com | Blocks|27339 | -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27606] 'from' parameter of rollback urls in the web interface include '+' signs (wrong encoding)
https://bugzilla.wikimedia.org/show_bug.cgi?id=27606 Krinkle changed: What|Removed |Added CC||krinklem...@gmail.com --- Comment #4 from Krinkle 2011-02-22 18:53:50 UTC --- (In reply to comment #3) > "+" is perfectly 100% normal URL form encoding for a space, and is always > correct in this circumstance. Code that is attempting to pull URL query string > parameters but doesn't know how to decode URL form encoding needs to be fixed. Agreed (after IRC elucidation by brion). wfUrlEncode is only to be used for 'nice' urls in the core (ie. /wiki/Page:Name_here or Special:Contributions/John_Doe. query formed links are always with urlencode and encode spaces with '+', this is consistent throughout the core, such as on : http://www.mediawiki.org/wiki/User:Jack_Phoenix the sidebar links to http://www.mediawiki.org/w/index.php?title=Special:Log&user=Jack+Phoenix -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27606] 'from' parameter of rollback urls in the web interface include '+' signs (wrong encoding)
https://bugzilla.wikimedia.org/show_bug.cgi?id=27606 Brion Vibber changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Comment #3 from Brion Vibber 2011-02-22 18:25:48 UTC --- "+" is perfectly 100% normal URL form encoding for a space, and is always correct in this circumstance. Code that is attempting to pull URL query string parameters but doesn't know how to decode URL form encoding needs to be fixed. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27606] 'from' parameter of rollback urls in the web interface include '+' signs (wrong encoding)
https://bugzilla.wikimedia.org/show_bug.cgi?id=27606 Mark A. Hershberger changed: What|Removed |Added CC||m...@everybody.org Blocks||27339 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27606] 'from' parameter of rollback urls in the web interface include '+' signs (wrong encoding)
https://bugzilla.wikimedia.org/show_bug.cgi?id=27606 Derk-Jan Hartman changed: What|Removed |Added CC||hart...@videolan.org --- Comment #2 from Derk-Jan Hartman 2011-02-21 21:55:49 UTC --- you can, because we also have pagenames with + in them, so we really shouldn't use + as an escape char. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27606] 'from' parameter of rollback urls in the web interface include '+' signs (wrong encoding)
https://bugzilla.wikimedia.org/show_bug.cgi?id=27606 --- Comment #1 from AlexSm 2011-02-21 19:32:34 UTC --- Looks like "+" is used in a lot of places, compare this: /wiki/Contributions/A_b w/index.php?title=Special:Contributions...&target=A+b w/index.php?title=Special:Log...&page=A+b This works fine for MediaWiki itself so I'm not sure you can call it a bug. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
