[Bug 27688] list=allusers&auprop=blockinfo: Use ipb_by_text instead of join with user table

2011-02-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27688

--- Comment #2 from duplicate...@googlemail.com 2011-02-24 18:37:19 UTC ---
year, "Mid-air collision detected!" - Edit conflict in bugzilla

Also for list=users&usprop=blockinfo.

Thanks.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 27688] list=allusers&auprop=blockinfo: Use ipb_by_text instead of join with user table

2011-02-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27688

--- Comment #1 from Reedy  2011-02-24 18:36:02 UTC ---
I was thinking I'd already done this one, slightly confusing

if ( $fld_blockinfo ) {
$this->addTables( 'ipblocks' );
$this->addTables( 'user', 'u2' );
$u2 = $this->getAliasedName( 'user', 'u2' );
$this->addJoinConds( array(
'ipblocks' => array( 'LEFT JOIN', 'ipb_user=u1.user_id' ),
$u2 => array( 'LEFT JOIN', 'ipb_by=u2.user_id' ) ) );
$this->addFields( array( 'ipb_reason', 'u2.user_name AS
blocker_name' ) );
}

Just a case of simplifying that, and not having the 2nd join of the user table
in :)

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l