[Bug 29199] Tab index sorting doesn't make sense

2014-08-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29199

Andre Klapper aklap...@wikimedia.org changed:

   What|Removed |Added

 Status|PATCH_TO_REVIEW |NEW

--- Comment #38 from Andre Klapper aklap...@wikimedia.org ---
[No patches left here - resetting bug report status]

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29199] Tab index sorting doesn't make sense

2014-05-28 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29199

--- Comment #37 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 135269 merged by jenkins-bot:
vector: Add tabindex back to search box

https://gerrit.wikimedia.org/r/135269

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29199] Tab index sorting doesn't make sense

2014-05-27 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29199

--- Comment #33 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 135208 merged by Reedy:
Revert Restore search box tabindex

https://gerrit.wikimedia.org/r/135208

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29199] Tab index sorting doesn't make sense

2014-05-27 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29199

Matthew Flaschen mflasc...@wikimedia.org changed:

   What|Removed |Added

   Keywords|easy|

--- Comment #34 from Matthew Flaschen mflasc...@wikimedia.org ---
We should consider possible options we have other than lastTabIndex.  According
to http://www.w3.org/TR/html401/interact/forms.html#adef-tabindex , positive
tabindexes are first (this is how it works with lastTabIndex).

Then come tabindex 0 elements, which come in character stream order.  This
could work, since navigation comes late in our document.  However, I think 0
tabindex is equivalent to omitted in most cases.

That also raises the important question, why exactly is an explicit tabindex
needed here (I don't have OTRS access)?  In Firefox and Chromium, it seems that
the search box included in the actual tab order anyway, and late in the page.

Is the goal to make search late in the tab order, but still before the
navigation elements with no tabindex (e.g. Read/Edit tabs)?

Could we potentially solve this by having a dedicated tabindex range for
navigation elements in particular areas of the page?  We have 0 and 32767
available according the W3C, and it doesn't have to be contiguous, so reserving
ranges would seem to be doable.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29199] Tab index sorting doesn't make sense

2014-05-27 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29199

--- Comment #35 from Matthew Flaschen mflasc...@wikimedia.org ---
(In reply to Matthew Flaschen from comment #34)
 We should consider possible options we have other than lastTabIndex. 
 According to http://www.w3.org/TR/html401/interact/forms.html#adef-tabindex
 , positive tabindexes are first (this is how it works with lastTabIndex).
 
 Then come tabindex 0 elements, which come in character stream order.  This
 could work, since navigation comes late in our document.  However, I think 0
 tabindex is equivalent to omitted in most cases.

These rules are changed in HTML5
(http://www.w3.org/TR/html5/editing.html#sequential-focus-navigation-and-the-tabindex-attribute),
so we need to consider that, and how browsers are actually implementing it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29199] Tab index sorting doesn't make sense

2014-05-27 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29199

--- Comment #36 from Alex Monk kren...@wikimedia.org ---
(In reply to Matthew Flaschen from comment #34)
 why exactly is an explicit tabindex
 needed here (I don't have OTRS access)?  In Firefox and Chromium, it seems
 that the search box included in the actual tab order anyway, and late in the
 page.

To move the search box's position in the tab order to the beginning rather than
near the end of the page.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29199] Tab index sorting doesn't make sense

2014-05-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29199

Jesús Martínez Novo (Ciencia Al Poder) martinezn...@gmail.com changed:

   What|Removed |Added

 CC||martinezn...@gmail.com

--- Comment #25 from Jesús Martínez Novo (Ciencia Al Poder) 
martinezn...@gmail.com ---
Gerrit change 134801 doesn't seem to be a proper fix.

As I said in bug 46336 comment 3, the tabindex was set automatically (with
JavaScript) determining the highest tabindex on the page, which managed to work
well unless form fields were added dynamically to the page with hardcoded
tabindex, as was the problem with LQT.

Now, the hardcoded tabindex=1 of the search caused the problem in bug 46336
to not be specific of LQT, but to all forms that set up tabindex on the page,
whether form fields are added dynamically to the page or not, causing more
problems that it was trying to solve.

If we're hardcoding the tabindex also in the search, we should increase by 1
the tabindex for all the other elements of the page.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29199] Tab index sorting doesn't make sense

2014-05-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29199

Nemo federicol...@tiscali.it changed:

   What|Removed |Added

 Status|PATCH_TO_REVIEW |NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29199] Tab index sorting doesn't make sense

2014-05-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29199

--- Comment #26 from Nemo federicol...@tiscali.it ---
Created attachment 15472
  -- https://bugzilla.wikimedia.org/attachment.cgi?id=15472action=edit
ack-grep 'tabindex' = in whole gerrit

Would tabindex 0 work? Only a special page in WikipediaZero seems to be using
it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29199] Tab index sorting doesn't make sense

2014-05-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29199

Andre Klapper aklap...@wikimedia.org changed:

   What|Removed |Added

 Blocks||65663

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29199] Tab index sorting doesn't make sense

2014-05-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29199

--- Comment #27 from Jesús Martínez Novo (Ciencia Al Poder) 
martinezn...@gmail.com ---
(In reply to Nemo from comment #26)
 Would tabindex 0 work? Only a special page in WikipediaZero seems to be
 using it.

Nope. tabindex=0 is used on elements that normally aren't focusable (like a
span), to make them focusable when navigating through tabs, while respecting
the normal tab order in the document. Only numbers greater than 0 work for
specify a priority in the tab order (tabindex 0 is the default for focusable
elements).

What it could be done, is to use the same tabindex in all elements where the
tab order matches the order where they're present in the HTML, like the edit
form and such. But anyway, it requires changing the tabindex in a lot of PHP
files.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29199] Tab index sorting doesn't make sense

2014-05-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29199

--- Comment #28 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 135205 had a related patch set uploaded by Mattflaschen:
Revert Restore search box tabindex

https://gerrit.wikimedia.org/r/135205

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29199] Tab index sorting doesn't make sense

2014-05-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29199

Gerrit Notification Bot gerritad...@wikimedia.org changed:

   What|Removed |Added

 Status|NEW |PATCH_TO_REVIEW

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29199] Tab index sorting doesn't make sense

2014-05-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29199

--- Comment #29 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 135205 merged by jenkins-bot:
Revert Restore search box tabindex

https://gerrit.wikimedia.org/r/135205

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29199] Tab index sorting doesn't make sense

2014-05-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29199

--- Comment #30 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 135208 had a related patch set uploaded by Mattflaschen:
Revert Restore search box tabindex

https://gerrit.wikimedia.org/r/135208

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29199] Tab index sorting doesn't make sense

2014-05-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29199

--- Comment #31 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 135269 had a related patch set uploaded by Mattflaschen:
Fix search box tabindex again

https://gerrit.wikimedia.org/r/135269

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29199] Tab index sorting doesn't make sense

2014-05-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29199

Bartosz Dziewoński matma@gmail.com changed:

   What|Removed |Added

 Blocks|65704   |
   See Also||https://bugzilla.wikimedia.
   ||org/show_bug.cgi?id=65704

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29199] Tab index sorting doesn't make sense

2014-05-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29199

--- Comment #32 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 135057 abandoned by Bartosz Dziewoński:
Add search box to existing navigation role

Reason:
This is not going to work / help, sorry :( (And there are so many patches for
this issue, let's thin the herds a bit.)

https://gerrit.wikimedia.org/r/135057

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29199] Tab index sorting doesn't make sense

2014-05-23 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29199

Nemo federicol...@tiscali.it changed:

   What|Removed |Added

 Status|PATCH_TO_REVIEW |NEW

--- Comment #23 from Nemo federicol...@tiscali.it ---
(In reply to Yuki Shira from comment #22)
 Is Change 134801 tested in action=edit pages?
 The Summary: input box also has tabindex=1.

Just did, the result is bug 46336 on action=edit (tab goes from edit to summary
to search). From comment 4, the relevant section is
http://www.w3.org/WAI/PF/aria-practices/#kbd_layout_landmarks I think. See also
comment 5.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29199] Tab index sorting doesn't make sense

2014-05-23 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29199

Gerrit Notification Bot gerritad...@wikimedia.org changed:

   What|Removed |Added

 Status|NEW |PATCH_TO_REVIEW

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29199] Tab index sorting doesn't make sense

2014-05-23 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29199

--- Comment #24 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 135057 had a related patch set uploaded by Nemo bis:
Add search box to existing navigation role

https://gerrit.wikimedia.org/r/135057

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29199] Tab index sorting doesn't make sense

2014-05-23 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29199

Andre Klapper aklap...@wikimedia.org changed:

   What|Removed |Added

 Blocks||65704

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29199] Tab index sorting doesn't make sense

2014-05-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29199

Nemo federicol...@tiscali.it changed:

   What|Removed |Added

 CC||kren...@wikimedia.org
 Blocks||43562

--- Comment #19 from Nemo federicol...@tiscali.it ---
(In reply to Gerrit Notification Bot from comment #18)
 Change 65115 abandoned by Bartosz Dziewoński:
 Fix tab navigation issue on collapsible navigation menus
 
 Reason:
 This extension has been discontinued, sorry :(

Anything to recover in there?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29199] Tab index sorting doesn't make sense

2014-05-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29199

--- Comment #20 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 134801 had a related patch set uploaded by Nemo bis:
Restore search box tabindex

https://gerrit.wikimedia.org/r/134801

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29199] Tab index sorting doesn't make sense

2014-05-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29199

Nemo federicol...@tiscali.it changed:

   What|Removed |Added

   See Also||https://bugzilla.wikimedia.
   ||org/show_bug.cgi?id=1864

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29199] Tab index sorting doesn't make sense

2014-05-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29199

Nemo federicol...@tiscali.it changed:

   What|Removed |Added

 Depends on||46336

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29199] Tab index sorting doesn't make sense

2014-05-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29199

--- Comment #21 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 134801 merged by jenkins-bot:
Restore search box tabindex

https://gerrit.wikimedia.org/r/134801

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29199] Tab index sorting doesn't make sense

2014-05-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29199

Yuki Shira shirayuk...@gmail.com changed:

   What|Removed |Added

 CC||shirayuk...@gmail.com

--- Comment #22 from Yuki Shira shirayuk...@gmail.com ---
Is Change 134801 tested in action=edit pages?
The Summary: input box also has tabindex=1.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29199] Tab index sorting doesn't make sense

2013-12-23 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29199

--- Comment #17 from Marius Hoch h...@online.de ---
(In reply to comment #16)
 Do you think this task is simple enough to be a Google Code-in task? Namely,
 would it take 2-3 hours of an experienced contributor to fix it?

The code change itself surely can be done in that time span, but this requires
a *lot* of testing (different skins(?), also with screen readers)... and might
be hard to get through code review.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29199] Tab index sorting doesn't make sense

2013-12-23 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29199

--- Comment #18 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 65115 abandoned by Bartosz Dziewoński:
Fix tab navigation issue on collapsible navigation menus

Reason:
This extension has been discontinued, sorry :(

https://gerrit.wikimedia.org/r/65115

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29199] Tab index sorting doesn't make sense

2013-12-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29199

Michael Zajac mich...@zajac.ca changed:

   What|Removed |Added

 CC||mich...@zajac.ca

--- Comment #15 from Michael Zajac mich...@zajac.ca ---
The Search Submit button does not have a tabindex.

If it did, then I could use the keyboard to choose to jump to a search
suggestion by hitting return, or show search results by hitting tab, return.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29199] Tab index sorting doesn't make sense

2013-12-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29199

Quim Gil q...@wikimedia.org changed:

   What|Removed |Added

 CC||legoktm.wikipe...@gmail.com
   ||, matma@gmail.com
Version|1.20.0  |1.23-git

--- Comment #16 from Quim Gil q...@wikimedia.org ---
Do you think this task is simple enough to be a Google Code-in task? Namely,
would it take 2-3 hours of an experienced contributor to fix it?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29199] Tab index sorting doesn't make sense

2013-09-07 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29199

Nemo federicol...@tiscali.it changed:

   What|Removed |Added

 CC||federicol...@tiscali.it

--- Comment #14 from Nemo federicol...@tiscali.it ---
(In reply to comment #12)
 As we already have (working) mw-jump links we should consider completely
 removing the tabindex from the sidebar headings so that they'll get tabbed to
 only after the content (or if the user select navigation from the mw-jump
 quick links).
 Having to tab through the whole sidebar prior to reaching the content isn't
 an
 option IMO.

Agreed. That's also the behaviour in monobook; I don't use Vector so I didn't
notice it has a regression in that regard.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29199] Tab index sorting doesn't make sense

2013-08-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29199

Marius Hoch h...@online.de changed:

   What|Removed |Added

 CC||daniel.kinz...@wikimedia.de

--- Comment #13 from Marius Hoch h...@online.de ---
*** Bug 24581 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29199] Tab index sorting doesn't make sense

2013-08-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29199

Marius Hoch h...@online.de changed:

   What|Removed |Added

 CC||h...@online.de

--- Comment #12 from Marius Hoch h...@online.de ---
As we already have (working) mw-jump links we should consider completely
removing the tabindex from the sidebar headings so that they'll get tabbed to
only after the content (or if the user select navigation from the mw-jump
quick links).
Having to tab through the whole sidebar prior to reaching the content isn't an
option IMO.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29199] Tab index sorting doesn't make sense

2013-08-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29199

Marius Hoch h...@online.de changed:

   What|Removed |Added

   Keywords||accessibility

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29199] Tab index sorting doesn't make sense

2013-08-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29199

Gerrit Notification Bot gerritad...@wikimedia.org changed:

   What|Removed |Added

 Status|NEW |PATCH_TO_REVIEW

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29199] Tab index sorting doesn't make sense

2013-08-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29199

--- Comment #11 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 65115 had a related patch set uploaded by Nemo bis:
Fix tab navigation issue on collapsible navigation menus

https://gerrit.wikimedia.org/r/65115

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29199] Tab index sorting doesn't make sense

2013-06-01 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29199

Graham87 graha...@jazi.net changed:

   What|Removed |Added

 CC||graha...@jazi.net

--- Comment #10 from Graham87 graha...@jazi.net ---
I'm pretty sure  this'd be fine. I'd never heard of tabindex before being
informed about this bug on the English Wikipedia's accessibility guideline talk
page. JAWS doesn't seem to use tabindex to determine tab order anyway, but NVDA
does,per  link: http://www.w3schools.com/tags/att_global_tabindex.asp

JAWS just uses the HTML order to determine tab order in that link.
A semi-related problem is bug 47993 about the new notifications system.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29199] Tab index sorting doesn't make sense

2013-05-31 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29199

Derk-Jan Hartman hartman.w...@gmail.com changed:

   What|Removed |Added

 CC||hartman.w...@gmail.com

--- Comment #9 from Derk-Jan Hartman hartman.w...@gmail.com ---
I think that the collapsible navs should actually be tabIndex=0 role=button
(integrate with implicit taborder). Our Navigation menu's are now actually
properly under the H2 Navigation menu, making them easily reachable using
Header navigation features of screenreaders. (this was why we had a high
tabIndex on them before).

Adding 'more' tabIndexes seems confusing and unnecessary to me.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29199] Tab index sorting doesn't make sense

2013-05-23 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29199

--- Comment #8 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Related URL: https://gerrit.wikimedia.org/r/65115 (Gerrit Change
Ie71ac23b8fe26122107e861bc44f575573bd2714)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29199] Tab index sorting doesn't make sense

2013-04-25 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29199

--- Comment #7 from Ruben rube...@gmail.com ---
I agree. 
This should be fairly straightforward.
(and deliver great value for the users!)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29199] Tab index sorting doesn't make sense

2013-04-25 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29199

Quim Gil q...@wikimedia.org changed:

   What|Removed |Added

   Keywords||easy

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29199] Tab index sorting doesn't make sense

2013-04-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29199

Ruben rube...@gmail.com changed:

   What|Removed |Added

 CC||rube...@gmail.com

--- Comment #5 from Ruben rube...@gmail.com ---
I would like to add that for most users (not using screen readers or other
accessibility tools), the usefulness and impact of good tab indexing greatly
depends on the input context. When are the users more likely to be in a typing
modus - and have one or two hands on the keyboard?

I would claim that after searching for something, you are more probable to be
in that context, then you are while browsing pages. 

If you are on the search result page, you most definite have just typed in
something. You will also very likely want to access one of the first links in
the search result (rather than make a new search). 

As of now, the tab indexing varies between browsers - and they do a pretty bad
job at guessing correctly. At a quick glance, I actually didn't see any
tabindexes in the HTML.

On a search result page, you will have to have good arguments for not letting
the result set have high index priority. Google understands this and does it
very well as they even remove the search button (as most users know you can
press enter directly in the search input field.

On the search result page you'll have the hands on the keyboard, and not being
able to tab down to the first result(s) is a major usability issue for
MediaWiki and Wikipedia.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29199] Tab index sorting doesn't make sense

2013-04-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29199

--- Comment #6 from Quim Gil q...@wikimedia.org ---
Can we mark this report as easy? Given the information in this thread it
shouldn't take much work to define the focus workflow, right?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29199] Tab index sorting doesn't make sense

2013-04-02 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29199

--- Comment #4 from Trevor Parscal tpars...@wikimedia.org ---
I'm not working on this - but I do think there are issues.

The collapsible navigation headers should be focusable, but their contents
should be indexed directly after them, so pressing enter to open will make it
possible to tab into them, closing them by pressing enter again will make it
possible to skip directly over them. The fact that the links within the sidebar
aren't accesible is a horrible bug.

It's not clear that the tabs are a better place to jump the user to first. When
we tested frequency of use, the sidebar was used far more frequently than any
of the tabs, especially the home page and random article links. The idea of
collapsible navigation was originally that you could easily jump over them and
onto other things (both with your keyboard focus and your eyes) by them being
initially collapsed.

Any sufficiently complex user interface is going to suck for tab-indexing, so
perhaps we could come up with a structured approach. We could have 5 focusable
items (which each play a different role), when you press enter on search you
search, otherwise you enter a focusing state where you are now tabbing through
the sub-items of the area. Press escape to leave this focus group.

0: search
1: sidebar
  0+: portal headings and links in order of vertical appearance
2: head
  0+: tabs, then personal tools
3: content
  0+: links in the content
4: foot
  0+: links in the foot

There's some guidelines about how this sort of thing should be handled in the
WAI-ARIA spec http://www.w3.org/WAI/PF/aria-practices/#focus_tabindex

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29199] Tab index sorting doesn't make sense

2013-04-02 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29199

Quim Gil q...@wikimedia.org changed:

   What|Removed |Added

   Assignee|tpars...@wikimedia.org  |wikibugs-l@lists.wikimedia.
   ||org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29199] Tab index sorting doesn't make sense

2013-04-01 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29199

Quim Gil q...@wikimedia.org changed:

   What|Removed |Added

 CC||q...@wikimedia.org

--- Comment #3 from Quim Gil q...@wikimedia.org ---
Trevor, are you working on this and is it Normal priority? Just checking.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29199] Tab index sorting doesn't make sense

2011-05-31 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29199

--- Comment #1 from Brion Vibber br...@wikimedia.org 2011-05-31 18:54:00 UTC 
---
I can confirm w/ Vector on en.wikipedia.org in Firefox 4.0/Linux; the main
oddities are:

* the sidebar *collapsable section titles* appear in tab order between the
search form and the page content area, but the sidebar *actual links* appear in
tab order along with the other navigation links at the *end* of the page order

* getting to the top navigation links is indeed pretty hard.

For that second, there's a tradeoff between making it easier to jump into the
content area, and making it easier to reach the navigation links.

Back in the day I think we added a semi-hidden link near the top that jumps you
to the navigation links as an aid to users of text  speech browsers, but since
it's hidden normally that doesn't always help keyboarders. It might be possible
to force it visible too?

Not sure what the ideal situation is atm.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29199] Tab index sorting doesn't make sense

2011-05-31 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29199

Krinkle krinklem...@gmail.com changed:

   What|Removed |Added

 CC||krinklem...@gmail.com

--- Comment #2 from Krinkle krinklem...@gmail.com 2011-05-31 19:03:51 UTC ---
Another silent annoyance I've had for a while now is the following:

On action=edit the next tab after the editform is the editsummary. For that
reason I, and probably many power/keyboard users, go like this: Edit  [tab] 
work with wikitext  [tab]  type summary and/or hit Return to submit/save form
(this requires the extra tab since Returns inserts a newline inside the editor
instead of submitting the form, as it should).

However on action=edit's where there is no editsummary or on section=new (where
the editsummary is actually the Title/Heading, located on top of the editform
rather than below it).. in those situatinos tabbing out of the editform brings
you to the search form (rather than the summary, or some other place where
hitting Return submits the edit form).
Pressing Returnn at that point submits the search form and shows Special:Search
(g). This might one's your edit (granted, it would mostly happen to
experienced users, who would know to press the browser's Back button and submit
again (the right way this time).

.. regardless, it's annoying and I end up on a search results page by the above
means quite often actually...
It's not entirely trivial to fix though, because it's not a high tabindex on
the search form causing the problem, as much as it being the lowest tabindex on
the page and editform the highest tabindex, so... after the editform (highest)
the next (in most browsers that I know) tab goes back to the lowest tabindex.

Not sure if it requires a new bug or if it's a bug at all, but wanted to have
mentioned it!

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29199] Tab index sorting doesn't make sense

2011-05-30 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29199

Mark A. Hershberger m...@everybody.org changed:

   What|Removed |Added

   Priority|Unprioritized   |Normal
 CC||m...@everybody.org

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29199] Tab index sorting doesn't make sense

2011-05-30 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29199

Mark A. Hershberger m...@everybody.org changed:

   What|Removed |Added

   Severity|normal  |enhancement

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l