[Bug 29672] use tab name, not tab index for anchors on Special:Preferences
https://bugzilla.wikimedia.org/show_bug.cgi?id=29672
Bergi a.d.be...@web.de changed:
What|Removed |Added
Status|RESOLVED|REOPENED
CC||a.d.be...@web.de
Resolution|FIXED |
--- Comment #10 from Bergi a.d.be...@web.de 2011-07-19 16:06:39 UTC ---
Nice, but could you please add a legacy function for old links (from FAQ etc,
links that help-seeking users found in archives)? Maybe something like
(untested)
var tab, hash = window.location.hash;
if( tab = hash.match( /^#preftab-(.+)/ ) ) {
var $tab = $( hash + '-tab' );
if (! $tab.length tab[1])
$tab = $('#preftoc a').eq(parseInt(tab[1]));
$tab.click();
}
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29672] use tab name, not tab index for anchors on Special:Preferences
https://bugzilla.wikimedia.org/show_bug.cgi?id=29672
duplicate...@googlemail.com changed:
What|Removed |Added
Status|REOPENED|RESOLVED
CC||duplicate...@googlemail.com
Resolution||FIXED
--- Comment #11 from duplicate...@googlemail.com 2011-07-19 18:40:24 UTC ---
(In reply to comment #10)
Nice, but could you please add a legacy function for old links (from FAQ etc,
links that help-seeking users found in archives)? Maybe something like
(untested)
var tab, hash = window.location.hash;
if( tab = hash.match( /^#preftab-(.+)/ ) ) {
var $tab = $( hash + '-tab' );
if (! $tab.length tab[1])
$tab = $('#preftoc a').eq(parseInt(tab[1]));
$tab.click();
}
For backward compatible see r91869#c19481
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29672] use tab name, not tab index for anchors on Special:Preferences
https://bugzilla.wikimedia.org/show_bug.cgi?id=29672 DieBuche diebu...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #9 from DieBuche diebu...@gmail.com 2011-07-11 09:55:33 UTC --- Looks good. Committed in r91869 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29672] use tab name, not tab index for anchors on Special:Preferences
https://bugzilla.wikimedia.org/show_bug.cgi?id=29672 Jarry1250 jarry1...@gmail.com changed: What|Removed |Added Attachment #8742|0 |1 is obsolete|| --- Comment #8 from Jarry1250 jarry1...@gmail.com 2011-07-09 17:24:33 UTC --- Created attachment 8763 -- https://bugzilla.wikimedia.org/attachment.cgi?id=8763 Working patch (use canonical) Utilise canonical names as provided above. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29672] use tab name, not tab index for anchors on Special:Preferences
https://bugzilla.wikimedia.org/show_bug.cgi?id=29672 Jarry1250 jarry1...@gmail.com changed: What|Removed |Added Keywords||need-review, patch -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29672] use tab name, not tab index for anchors on Special:Preferences
https://bugzilla.wikimedia.org/show_bug.cgi?id=29672 Jarry1250 jarry1...@gmail.com changed: What|Removed |Added Keywords|need-review, patch | --- Comment #5 from Jarry1250 jarry1...@gmail.com 2011-07-08 17:02:28 UTC --- Thanks for the review. I shall have a prod around regarding Canonical names. With respect to allowed characters, all I can find is restricted to ASCII characters. Elsewhere in Wikipedia we use a fairly heavy process to ensure adherence to this. On the other hand, canonical names are almost certainly going to be written in English. So it's probably fine. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29672] use tab name, not tab index for anchors on Special:Preferences
https://bugzilla.wikimedia.org/show_bug.cgi?id=29672 --- Comment #6 from Jarry1250 jarry1...@gmail.com 2011-07-08 20:19:49 UTC --- Okay, so the major problem is that canonical names are not exposed to the JavaScript. There seems to be no easy way of exposing them, either. The form extends HTMLForm, and uses its abstracted functions. As a consequence, which massive overriding HTMLForm, there's no way for the PHP to know which legends the JavaScript is going to need metadata about. That's my take, anyway. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29672] use tab name, not tab index for anchors on Special:Preferences
https://bugzilla.wikimedia.org/show_bug.cgi?id=29672 --- Comment #7 from DieBuche diebu...@gmail.com 2011-07-08 21:14:34 UTC --- (In reply to comment #6) Okay, so the major problem is that canonical names are not exposed to the JavaScript. Here you go: r91757 :) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29672] use tab name, not tab index for anchors on Special:Preferences
https://bugzilla.wikimedia.org/show_bug.cgi?id=29672 DieBuche diebu...@gmail.com changed: What|Removed |Added CC||diebu...@gmail.com --- Comment #3 from DieBuche diebu...@gmail.com 2011-07-07 15:41:29 UTC --- Problems with patch: 1. HTML4 only allows very limited characters for ID's. I don't think browsers hickup on that though, since it's a very common mistake. 2. Links will be Userlanguage dependent. Something like Go to this link ../Special:Preferences#Editing , then change X and click save etc. will break if the others user lang is italian. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29672] use tab name, not tab index for anchors on Special:Preferences
https://bugzilla.wikimedia.org/show_bug.cgi?id=29672 --- Comment #4 from Umherirrender umherirrender_de...@web.de 2011-07-07 18:55:27 UTC --- (In reply to comment #3) 2. Links will be Userlanguage dependent. Something like Go to this link ../Special:Preferences#Editing , then change X and click save etc. will break if the others user lang is italian. Using the canonical/technical name of the tab should be ok, because in other situation it is also used (URL param, log types and so on) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29672] use tab name, not tab index for anchors on Special:Preferences
https://bugzilla.wikimedia.org/show_bug.cgi?id=29672 --- Comment #2 from Jarry1250 jarry1...@gmail.com 2011-07-05 19:41:43 UTC --- Created attachment 8742 -- https://bugzilla.wikimedia.org/attachment.cgi?id=8742 Working patch (remove spaces only) This patch should do the trick. Obviously, any level of normalisation is possible - it's a trade off between readability/clashes/potentially breaking the anchor. I've opted for low level normalisation - only spaces, hashes and hyphens. The JavaScript-disabled version is unaffected. Tested in latest FF, IE and Chrome; any-which-way it's a simple patch. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29672] use tab name, not tab index for anchors on Special:Preferences
https://bugzilla.wikimedia.org/show_bug.cgi?id=29672 Jarry1250 jarry1...@gmail.com changed: What|Removed |Added Keywords||need-review, patch CC||jarry1...@gmail.com -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29672] use tab name, not tab index for anchors on Special:Preferences
https://bugzilla.wikimedia.org/show_bug.cgi?id=29672 Jarry1250 jarry1...@gmail.com changed: What|Removed |Added Keywords||accessibility -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29672] use tab name, not tab index for anchors on Special:Preferences
https://bugzilla.wikimedia.org/show_bug.cgi?id=29672 Mark A. Hershberger m...@everybody.org changed: What|Removed |Added Priority|Unprioritized |Normal CC||m...@everybody.org Severity|normal |enhancement -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29672] use tab name, not tab index for anchors on Special:Preferences
https://bugzilla.wikimedia.org/show_bug.cgi?id=29672 Brion Vibber br...@wikimedia.org changed: What|Removed |Added Blocks||27559 --- Comment #1 from Brion Vibber br...@wikimedia.org 2011-07-01 21:07:31 UTC --- I'm also marking this as a blocker on bug 27559 (saving the currently selected tab across submissions); while not strictly a requirement, making the hashes more actively used would benefit from also making them link-friendlier by using nice ASCII english words. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
