[Bug 31863] Fix use of DB schema so RenameUser is trivial
https://bugzilla.wikimedia.org/show_bug.cgi?id=31863 Sam Reed (reedy) changed: What|Removed |Added See Also||https://bugzilla.wikimedia. ||org/show_bug.cgi?id=67758 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 31863] Fix use of DB schema so RenameUser is trivial
https://bugzilla.wikimedia.org/show_bug.cgi?id=31863 Sam Reed (reedy) changed: What|Removed |Added Depends on||25377 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 31863] Fix use of DB schema so RenameUser is trivial
https://bugzilla.wikimedia.org/show_bug.cgi?id=31863 --- Comment #8 from Sam Reed (reedy) --- Extensions (especially WMF used ones) need auditing for this too... -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 31863] Fix use of DB schema so RenameUser is trivial
https://bugzilla.wikimedia.org/show_bug.cgi?id=31863 Krinkle changed: What|Removed |Added CC||krinklem...@gmail.com --- Comment #7 from Krinkle --- The places MediaWiki core currently actively looks at a user_text column that isn't from the user table are listed here: * https://github.com/wikimedia/mediawiki-extensions-Renameuser/blob/REL1_22/RenameuserSQL.php#L67-L90 * https://github.com/wikimedia/mediawiki-extensions-Renameuser/blob/REL1_22/renameUserCleanup.php#L149-L155 * https://github.com/wikimedia/mediawiki-extensions-Renameuser/blob/REL1_22/RenameUserJob.php#L55-L92 As of writing: * revision . rev_user_text * archive . ar_user_text * logging . log_user_text * image . img_user_text * oldimage . oi_user_text * filearchive . fa_user_text * recentchanges . rc_user_text -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 31863] Fix use of DB schema so RenameUser is trivial
https://bugzilla.wikimedia.org/show_bug.cgi?id=31863 MZMcBride changed: What|Removed |Added CC||b...@mzmcbride.com -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 31863] Fix use of DB schema so RenameUser is trivial
https://bugzilla.wikimedia.org/show_bug.cgi?id=31863 Chris Steipp changed: What|Removed |Added CC||cste...@wikimedia.org --- Comment #6 from Chris Steipp --- Do we have a list of these anywhere? We need to do renames in the very near future, and this would make it much easier. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 31863] Fix use of DB schema so RenameUser is trivial
https://bugzilla.wikimedia.org/show_bug.cgi?id=31863 Aaron Schulz changed: What|Removed |Added Blocks||14862 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 31863] Fix use of DB schema so RenameUser is trivial
https://bugzilla.wikimedia.org/show_bug.cgi?id=31863 --- Comment #5 from Aaron Schulz 2011-12-18 21:59:45 UTC --- Still lots of places that need JOINs or, preferably, batch lookups. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 31863] Fix use of DB schema so RenameUser is trivial
https://bugzilla.wikimedia.org/show_bug.cgi?id=31863 Sumana Harihareswara changed: What|Removed |Added CC||suma...@panix.com, ||yuvipa...@gmail.com --- Comment #4 from Sumana Harihareswara 2011-12-01 21:52:24 UTC --- Adding Yuvi to this bug since he said he'd take a look at this. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 31863] Fix use of DB schema so RenameUser is trivial
https://bugzilla.wikimedia.org/show_bug.cgi?id=31863 Aaron Schulz changed: What|Removed |Added Blocks||23135 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 31863] Fix use of DB schema so RenameUser is trivial
https://bugzilla.wikimedia.org/show_bug.cgi?id=31863 --- Comment #3 from Aaron Schulz 2011-10-21 23:29:51 UTC --- (In reply to comment #1) > With that in place, the worst case scenario should be that some batch queries > might be missing the join and end up doing some more row-by-row lookups > (they'll probably already be doing lots of those for user/talk page existence > checks, so don't worry!)... but they'll show the correct results. > Basically done in r100475. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 31863] Fix use of DB schema so RenameUser is trivial
https://bugzilla.wikimedia.org/show_bug.cgi?id=31863 --- Comment #2 from Aaron Schulz 2011-10-21 22:09:52 UTC --- (In reply to comment #1) > If joined columns from 'user' are available when initializing the Revision > object from a row, then we should use that directly; but if not, we could do > an > on-demand lookup via the rev_user_id if it's non-zero (local user reference), > or keep the rev_user_text if it's zero (usually IP, sometimes named non-local > import markers). Note that the "magic coalescy thingy" was replaced with just checking user_name already ;) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 31863] Fix use of DB schema so RenameUser is trivial
https://bugzilla.wikimedia.org/show_bug.cgi?id=31863 --- Comment #1 from Brion Vibber 2011-10-21 22:07:38 UTC --- This may benefit from a tweak to internal APIs. Revision::getUserText() / Revision::getRawUserText() currently pulls from the rev_user_text field (unless it got overridden by a magic coalescy thingy in the row). This means that anything pulling its own queries may be missing the original names, as it'll be stuck with rev_user_text. If joined columns from 'user' are available when initializing the Revision object from a row, then we should use that directly; but if not, we could do an on-demand lookup via the rev_user_id if it's non-zero (local user reference), or keep the rev_user_text if it's zero (usually IP, sometimes named non-local import markers). With that in place, the worst case scenario should be that some batch queries might be missing the join and end up doing some more row-by-row lookups (they'll probably already be doing lots of those for user/talk page existence checks, so don't worry!)... but they'll show the correct results. Might also think about a Revision::getUserObj() or something that would hand back a fully-ready User object, rather than having to cart around (id, text) pairs all the time. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 31863] Fix use of DB schema so RenameUser is trivial
https://bugzilla.wikimedia.org/show_bug.cgi?id=31863 Aaron Schulz changed: What|Removed |Added Blocks||26816 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 31863] Fix use of DB schema so RenameUser is trivial
https://bugzilla.wikimedia.org/show_bug.cgi?id=31863 Rob Lanphier changed: What|Removed |Added Priority|Unprioritized |Normal -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
