[Bug 33836] Set $wgIncludeLegacyJavaScript = false by default
https://bugzilla.wikimedia.org/show_bug.cgi?id=33836 Bug 33836 depends on bug 35858, which changed state. Bug 35858 Summary: Migrate legacy redirectToFragment to modern structure https://bugzilla.wikimedia.org/show_bug.cgi?id=35858 What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33836] Set $wgIncludeLegacyJavaScript = false by default
https://bugzilla.wikimedia.org/show_bug.cgi?id=33836 Bug 33836 depends on bug 35858, which changed state. Bug 35858 Summary: Migrate legacy redirectToFragment to modern structure https://bugzilla.wikimedia.org/show_bug.cgi?id=35858 What|Removed |Added Status|RESOLVED|PATCH_TO_REVIEW Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33836] Set $wgIncludeLegacyJavaScript = false by default
https://bugzilla.wikimedia.org/show_bug.cgi?id=33836 Bug 33836 depends on bug 35858, which changed state. Bug 35858 Summary: Migrate legacy redirectToFragment to modern structure https://bugzilla.wikimedia.org/show_bug.cgi?id=35858 What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33836] Set $wgIncludeLegacyJavaScript = false by default
https://bugzilla.wikimedia.org/show_bug.cgi?id=33836 Krinkle changed: What|Removed |Added Depends on||50039 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33836] Set $wgIncludeLegacyJavaScript = false by default
https://bugzilla.wikimedia.org/show_bug.cgi?id=33836 Krinkle changed: What|Removed |Added Blocks||50039 Depends on|50039 | -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33836] Set $wgIncludeLegacyJavaScript = false by default
https://bugzilla.wikimedia.org/show_bug.cgi?id=33836 --- Comment #9 from Krinkle 2012-05-11 17:28:55 UTC --- (In reply to comment #5) > Even when $wgIncludeLegacyJavaScript is set to false by default, wikibits.js > will be loaded in a standard installation: $wgUseAjax is true by default, this > loads the legacy ajax.js (though at least the ajax features in core don't need > it anymore), which has wikibits.js as dependency. Yes, but one must never depend on another module's dependency. wgIncludeLegacyJavaScript is intended for scripts that are not resource loader modules (yet) so that those (usually older) scripts may assume presence of wikibits methods. If wgIncludeLegacyJavaScript is false, eventhough it may end up being loaded, you can't know for sure if it will be loaded when you need it. For example, if wgIncludeLegacyJavaScript is false, and your module loads before ajax.js then you won't have wikibits. (unless you add mediawiki.legacy.wikibits to your module dependencies, see comment 3) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33836] Set $wgIncludeLegacyJavaScript = false by default
https://bugzilla.wikimedia.org/show_bug.cgi?id=33836 P.Copp changed: What|Removed |Added Depends on||35858 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33836] Set $wgIncludeLegacyJavaScript = false by default
https://bugzilla.wikimedia.org/show_bug.cgi?id=33836 Krinkle changed: What|Removed |Added Depends on|25845, 27475|34958 --- Comment #8 from Krinkle 2012-03-10 22:06:20 UTC --- Removed dependency on bug 27281, added bug 34958 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33836] Set $wgIncludeLegacyJavaScript = false by default
https://bugzilla.wikimedia.org/show_bug.cgi?id=33836 --- Comment #7 from Krinkle 2012-03-10 22:05:19 UTC --- Removed dependency -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33836] Set $wgIncludeLegacyJavaScript = false by default
https://bugzilla.wikimedia.org/show_bug.cgi?id=33836 Krinkle changed: What|Removed |Added Depends on|27281 | -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33836] Set $wgIncludeLegacyJavaScript = false by default
https://bugzilla.wikimedia.org/show_bug.cgi?id=33836 Bug 33836 depends on bug 27281, which changed state. Bug 27281 Summary: Add support in the front-end for loading wiki pages as resources https://bugzilla.wikimedia.org/show_bug.cgi?id=27281 What|Old Value |New Value Status|NEW |RESOLVED Resolution||WONTFIX -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33836] Set $wgIncludeLegacyJavaScript = false by default
https://bugzilla.wikimedia.org/show_bug.cgi?id=33836 Bug 33836 depends on bug 25845, which changed state. Bug 25845 Summary: Support loading wiki pages through mediaWiki.loader.load() https://bugzilla.wikimedia.org/show_bug.cgi?id=25845 What|Old Value |New Value Status|NEW |RESOLVED Resolution||WONTFIX -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33836] Set $wgIncludeLegacyJavaScript = false by default
https://bugzilla.wikimedia.org/show_bug.cgi?id=33836 mybugs.m...@gmail.com changed: What|Removed |Added Depends on||27281 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33836] Set $wgIncludeLegacyJavaScript = false by default
https://bugzilla.wikimedia.org/show_bug.cgi?id=33836 mybugs.m...@gmail.com changed: What|Removed |Added Depends on||25845 --- Comment #6 from mybugs.m...@gmail.com 2012-01-24 19:40:45 UTC --- Adding bug 25845 as a dependency since the request from bug 27475 to have an equivalent to importScript was marked as a duplicated of the first bug (see also bug 27535). -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33836] Set $wgIncludeLegacyJavaScript = false by default
https://bugzilla.wikimedia.org/show_bug.cgi?id=33836 mybugs.m...@gmail.com changed: What|Removed |Added Depends on||27475 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33836] Set $wgIncludeLegacyJavaScript = false by default
https://bugzilla.wikimedia.org/show_bug.cgi?id=33836 Michael M. changed: What|Removed |Added CC||listenle...@gmail.com --- Comment #5 from Michael M. 2012-01-21 09:38:02 UTC --- Even when $wgIncludeLegacyJavaScript is set to false by default, wikibits.js will be loaded in a standard installation: $wgUseAjax is true by default, this loads the legacy ajax.js (though at least the ajax features in core don't need it anymore), which has wikibits.js as dependency. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33836] Set $wgIncludeLegacyJavaScript = false by default
https://bugzilla.wikimedia.org/show_bug.cgi?id=33836 --- Comment #4 from Krinkle 2012-01-20 23:17:07 UTC --- (In reply to comment #3) > * any extension module or gadget can list it as a dependency and > ResourceLoader > will make sure it's loaded before the rest of the module. .. regardless of what $wgIncludeLegacyJavaScript is set to. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33836] Set $wgIncludeLegacyJavaScript = false by default
https://bugzilla.wikimedia.org/show_bug.cgi?id=33836
Krinkle changed:
What|Removed |Added
Keywords|javascript |
Summary|Remove wikibits.js |Set
||$wgIncludeLegacyJavaScript
||= false by default
--- Comment #3 from Krinkle 2012-01-20 23:16:29 UTC ---
(In reply to comment #2)
> For the record, the legacy wikibits is included by these lines:
> if ( $wgIncludeLegacyJavaScript ){
> $this->addModules( 'mediawiki.legacy.wikibits' );
> }
> from
> http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/OutputPage.php?view=markup#l2452
>
> So, this bug is about changing $wgIncludeLegacyJavaScript to false once we
> have
> replacements for the legacy functions.
Yep, and even after that default is changed:
* wikis can still set it to true
* any extension module or gadget can list it as a dependency and ResourceLoader
will make sure it's loaded before the rest of the module.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
