https://bugzilla.wikimedia.org/show_bug.cgi?id=40062
--- Comment #30 from Andre Klapper aklap...@wikimedia.org ---
(In reply to Andre Klapper from comment #29)
(In reply to Helder from comment #28)
FYI: those two patches were merged in december.
Could somebody (Matma Rex?) elaborate what is
https://bugzilla.wikimedia.org/show_bug.cgi?id=40062
Jon jrob...@wikimedia.org changed:
What|Removed |Added
Status|NEW |RESOLVED
https://bugzilla.wikimedia.org/show_bug.cgi?id=40062
Andre Klapper aklap...@wikimedia.org changed:
What|Removed |Added
Whiteboard|gci2013 |gci2014
https://bugzilla.wikimedia.org/show_bug.cgi?id=40062
Bug 40062 depends on bug 39617, which changed state.
Bug 39617 Summary: Malformed hlist rendering due to missing linebreaks between
list items
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
What|Removed
https://bugzilla.wikimedia.org/show_bug.cgi?id=40062
Liangent liang...@gmail.com changed:
What|Removed |Added
See Also|
https://bugzilla.wikimedia.org/show_bug.cgi?id=40062
Bug 40062 depends on bug 39617, which changed state.
Bug 39617 Summary: Malformed hlist rendering due to missing linebreaks between
list items
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
What|Removed
https://bugzilla.wikimedia.org/show_bug.cgi?id=40062
--- Comment #28 from Helder he7...@gmail.com ---
FYI: those two patches were merged in december.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
https://bugzilla.wikimedia.org/show_bug.cgi?id=40062
Bug 40062 depends on bug 39617, which changed state.
Bug 39617 Summary: Malformed hlist rendering due to missing linebreaks between
list items
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
What|Removed
https://bugzilla.wikimedia.org/show_bug.cgi?id=40062
--- Comment #27 from Bartosz Dziewoński matma@gmail.com ---
(I have two pending patches related to this,
https://gerrit.wikimedia.org/r/96239 and https://gerrit.wikimedia.org/r/99805 .
Any reviews, especially from the naysayers ;), would be
https://bugzilla.wikimedia.org/show_bug.cgi?id=40062
--- Comment #25 from Krinkle krinklem...@gmail.com ---
Please revert this and iterate further in a branch per Daniel's concerns.
Also, adding it to core with the same class name as lots of wikis have locally
is problematic. Especially given
https://bugzilla.wikimedia.org/show_bug.cgi?id=40062
--- Comment #26 from Bartosz Dziewoński matma@gmail.com ---
(In reply to comment #25)
Please revert this and iterate further in a branch per Daniel's concerns.
The module currently is just present, it's not loaded anywhere, so I don't
https://bugzilla.wikimedia.org/show_bug.cgi?id=40062
--- Comment #17 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 96071 merged by jenkins-bot:
Adding hlist module to mediawiki
https://gerrit.wikimedia.org/r/96071
--
You are receiving this mail because:
You are on the CC
https://bugzilla.wikimedia.org/show_bug.cgi?id=40062
Bartosz Dziewoński matma@gmail.com changed:
What|Removed |Added
Status|PATCH_TO_REVIEW |NEW
---
https://bugzilla.wikimedia.org/show_bug.cgi?id=40062
--- Comment #19 from Daniel Friesen mediawiki-b...@nadir-seen-fire.com ---
Agh, it's in core now.
Was my comment about internationalization issues with hardcoded punctuation
just ignored.
Now we have a module in core with another a super
https://bugzilla.wikimedia.org/show_bug.cgi?id=40062
--- Comment #20 from Bartosz Dziewoński matma@gmail.com ---
(In reply to comment #19)
Was my comment about internationalization issues with hardcoded punctuation
just ignored.
I'm afraid it was (I didn't notice it myself). But there's
https://bugzilla.wikimedia.org/show_bug.cgi?id=40062
--- Comment #21 from Daniel Friesen mediawiki-b...@nadir-seen-fire.com ---
(In reply to comment #20)
(In reply to comment #19)
And added in a way that it would need JavaScript to use the css
(addModules loads CSS via JS and addModuleStyles
https://bugzilla.wikimedia.org/show_bug.cgi?id=40062
--- Comment #22 from Bartosz Dziewoński matma@gmail.com ---
(In reply to comment #21)
You can't use addModules and addModuleStyles on the same module. This will
currently lead to a double loading of the CSS (can't find the bug number).
https://bugzilla.wikimedia.org/show_bug.cgi?id=40062
--- Comment #23 from Erwin Dokter er...@darcoury.nl ---
(In reply to comment #20)
Other modules do that too (although it's not much justification).
Edokter, what are those line-height rules for? They don't seem needed
to me.
I can't
https://bugzilla.wikimedia.org/show_bug.cgi?id=40062
--- Comment #15 from Bartosz Dziewoński matma@gmail.com ---
GCI patch: https://gerrit.wikimedia.org/r/#/c/96071/
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
https://bugzilla.wikimedia.org/show_bug.cgi?id=40062
Bartosz Dziewoński matma@gmail.com changed:
What|Removed |Added
Status|NEW
https://bugzilla.wikimedia.org/show_bug.cgi?id=40062
--- Comment #16 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 96071 had a related patch set uploaded by Mayankmadan:
Adding hlist module to mediawiki
https://gerrit.wikimedia.org/r/96071
--
You are receiving this mail
https://bugzilla.wikimedia.org/show_bug.cgi?id=40062
Bug 40062 depends on bug 39617, which changed state.
Bug 39617 Summary: Malformed hlist rendering due to missing linebreaks between
list items
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
What|Removed
https://bugzilla.wikimedia.org/show_bug.cgi?id=40062
Bug 40062 depends on bug 39617, which changed state.
Bug 39617 Summary: Malformed hlist rendering due to missing linebreaks between
list items
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
What|Removed
https://bugzilla.wikimedia.org/show_bug.cgi?id=40062
Bug 40062 depends on bug 39617, which changed state.
Bug 39617 Summary: Malformed hlist rendering due to missing linebreaks between
list items
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
What|Removed
https://bugzilla.wikimedia.org/show_bug.cgi?id=40062
Bug 40062 depends on bug 39617, which changed state.
Bug 39617 Summary: Malformed hlist rendering due to missing linebreaks between
list items
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
What|Removed
https://bugzilla.wikimedia.org/show_bug.cgi?id=40062
Bug 40062 depends on bug 39617, which changed state.
Bug 39617 Summary: Malformed hlist rendering due to missing linebreaks between
list items
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
What|Removed
https://bugzilla.wikimedia.org/show_bug.cgi?id=40062
Bug 40062 depends on bug 39617, which changed state.
Bug 39617 Summary: Malformed hlist rendering due to missing linebreaks between
list items
https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
What|Removed
https://bugzilla.wikimedia.org/show_bug.cgi?id=40062
--- Comment #14 from Jon jrob...@wikimedia.org ---
I think some of the rules are useful as generic ones, looking through many of
the rules many appear to be specific to certain pages and contexts e.g. talk
pages and those rules should only be
https://bugzilla.wikimedia.org/show_bug.cgi?id=40062
Bartosz Dziewoński matma@gmail.com changed:
What|Removed |Added
Whiteboard||gci2013
https://bugzilla.wikimedia.org/show_bug.cgi?id=40062
Erwin Dokter er...@darcoury.nl changed:
What|Removed |Added
Depends on||39617
--
You are
https://bugzilla.wikimedia.org/show_bug.cgi?id=40062
MZMcBride b...@mzmcbride.com changed:
What|Removed |Added
CC||b...@mzmcbride.com
31 matches
Mail list logo
