[Bug 45221] Document Special:PermanentLink and Special:Diff in the interface

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=45221

Gerrit Notification Bot  changed:

   What|Removed |Added

 Status|NEW |PATCH_TO_REVIEW

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 45221] Document Special:PermanentLink and Special:Diff in the interface

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=45221

--- Comment #6 from Gerrit Notification Bot  ---
Change 129095 had a related patch set uploaded by Gerrit Patch Uploader:
Document Special:Diff and Special:PermanentLink

https://gerrit.wikimedia.org/r/129095

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 45221] Document Special:PermanentLink and Special:Diff in the interface

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=45221

--- Comment #5 from Bartosz Dziewoński  ---
(In reply to PiRSquared17 from comment #4)
> It would be easy to accomplish, but generating a form would mean they would
> no longer extend RedirectSpecialPage. It's definitely feasible (e.g.,
> mock-up ), but
> is there any problem with changing the inheritance?

There isn't, the SpecialPage subclasses exist only for convenience.
If you are concerned, then you could just override the execute() method.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 45221] Document Special:PermanentLink and Special:Diff in the interface

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=45221

PiRSquared17  changed:

   What|Removed |Added

 CC||pirsquare...@gmail.com

--- Comment #4 from PiRSquared17  ---
(In reply to Bartosz Dziewoński from comment #3)
> I would say this affects Special:Diff too.
> 
> Fixing this would basically require doing two things for each of the
> affected special pages:
> 
> * Adding `public function isListed() { return true; }` (see
>   e.g. SpecialCreateAccount for an example).
> * Making them generate a form with brief instructions instead of an exception
>   when no parameters are provided (see e.g. SpecialComparePages for an
>   example, I think).

It would be easy to accomplish, but generating a form would mean they would no
longer extend RedirectSpecialPage. It's definitely feasible (e.g., mock-up
), but is there
any problem with changing the inheritance?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 45221] Document Special:PermanentLink and Special:Diff in the interface

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=45221

Bartosz Dziewoński  changed:

   What|Removed |Added

Summary|Document|Document
   |Special:PermanentLink in|Special:PermanentLink and
   |the interface   |Special:Diff in the
   ||interface

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l