[Bug 45865] Enhance EventLogging Schema diffs with Extension:Diff
https://bugzilla.wikimedia.org/show_bug.cgi?id=45865 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added CC||nu...@wikimedia.org, ||tneg...@wikimedia.org Component|EventLogging|EventLogging Version|master |unspecified Assignee|o...@wikimedia.org |wikibugs-l@lists.wikimedia. ||org Product|MediaWiki extensions|Analytics --- Comment #7 from Andre Klapper aklap...@wikimedia.org --- [moving from MediaWiki extensions to Analytics product - see bug 61946] -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45865] Enhance EventLogging Schema diffs with Extension:Diff
https://bugzilla.wikimedia.org/show_bug.cgi?id=45865 Bug 45865 depends on bug 45869, which changed state. Bug 45869 Summary: It should be possible to enable Extension:Diff for particular content models or namespaces https://bugzilla.wikimedia.org/show_bug.cgi?id=45869 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45865] Enhance EventLogging Schema diffs with Extension:Diff
https://bugzilla.wikimedia.org/show_bug.cgi?id=45865 --- Comment #1 from Jeroen De Dauw jeroen_ded...@yahoo.com --- Jeoren De Dauw wrote an extension to prettify diffing of Javascript. Not sure who this Jeoren fellow is, though if his extension is doing something similar to mine, it is not aimed at JS at all. Diff is aimed at computing and representing differences between JSON like arrays. Please see the documentation and examples. https://www.mediawiki.org/wiki/Extension:Diff -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45865] Enhance EventLogging Schema diffs with Extension:Diff
https://bugzilla.wikimedia.org/show_bug.cgi?id=45865 --- Comment #2 from Matthew Flaschen mflasc...@wikimedia.org --- And JSON is exactly what EventLogging uses. See https://meta.wikimedia.org/wiki/Schema:GuidedTour?action=edit . The mention of JavaScript in the initial report is incorrect. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45865] Enhance EventLogging Schema diffs with Extension:Diff
https://bugzilla.wikimedia.org/show_bug.cgi?id=45865 --- Comment #3 from Jeroen De Dauw jeroen_ded...@yahoo.com --- Ah... yeah, if you translate that into PHP arrays you can feed it to Diff. ATM Diff does not care about ordering, which I suspect is something you actually do care about here. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45865] Enhance EventLogging Schema diffs with Extension:Diff
https://bugzilla.wikimedia.org/show_bug.cgi?id=45865 --- Comment #4 from Matthew Flaschen mflasc...@wikimedia.org --- Meaning non-associative arrays are treated as sets? I actually can't think of a case where that would currently cause a problem in EventLogging (the main use case is enums, where it just matters whether it's in the array). However, it could in the future. Perhaps we can add a OrderedListDiffer for such cases, or rename ListDiffer to SetDiffer (depending how much backwards-compatibility is an issue)? -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45865] Enhance EventLogging Schema diffs with Extension:Diff
https://bugzilla.wikimedia.org/show_bug.cgi?id=45865 --- Comment #5 from Jeroen De Dauw jeroen_ded...@yahoo.com --- ListDiffer does not care about order. It can behave as array_diff does, in which case you get behaviour probably not wanted for non-sets. It's default behaviour however holds into account that an element can occur more then once. So that's not a problem. All I'm saying is that if you need ordering, additions will need to be made. or rename ListDiffer to SetDiffer (depending how much backwards-compatibility is an issue)? This rename would be incorrect. And it would break compatibility. This extension has also been designed with the open closed principle in mind. You ought to be able to add new functionality without significantly poking at existing code. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45865] Enhance EventLogging Schema diffs with Extension:Diff
https://bugzilla.wikimedia.org/show_bug.cgi?id=45865 --- Comment #6 from Sam Reed (reedy) s...@reedyboy.net --- (In reply to comment #0) As part of the Wikidata project, Jeoren De Dauw wrote an extension to prettify diffing of Javascript. It'd likely be a good addition for EventLogging to have too! Close enough! ;) -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45865] Enhance EventLogging Schema diffs with Extension:Diff
https://bugzilla.wikimedia.org/show_bug.cgi?id=45865 Ori Livneh o...@wikimedia.org changed: What|Removed |Added Depends on||45869 -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
