[Bug 46811] Fix parsing of infobox templates used in table attribute position
https://bugzilla.wikimedia.org/show_bug.cgi?id=46811 ssas...@wikimedia.org changed: What|Removed |Added Status|PATCH_TO_REVIEW |NEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46811] Fix parsing of infobox templates used in table attribute position
https://bugzilla.wikimedia.org/show_bug.cgi?id=46811 Gerrit Notification Bot changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46811] Fix parsing of infobox templates used in table attribute position
https://bugzilla.wikimedia.org/show_bug.cgi?id=46811 --- Comment #10 from Gerrit Notification Bot --- Change 173834 had a related patch set uploaded by Subramanya Sastry: WIP: Bug 46811: Quick test hack https://gerrit.wikimedia.org/r/173834 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46811] Fix parsing of infobox templates used in table attribute position
https://bugzilla.wikimedia.org/show_bug.cgi?id=46811 Jackmcbarn changed: What|Removed |Added URL||http://parsoid-prod.wmflabs ||.org/testwiki/46811?oldid=2 ||18081 CC||jackmcbarn+w...@gmail.com --- Comment #9 from Jackmcbarn --- A really reduced test case is at https://test.wikipedia.org/wiki/46811 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46811] Fix parsing of infobox templates used in table attribute position
https://bugzilla.wikimedia.org/show_bug.cgi?id=46811 Kelson [Emmanuel Engelhart] changed: What|Removed |Added CC||kel...@kiwix.org --- Comment #8 from Kelson [Emmanuel Engelhart] --- I think, this is an other occurence of this bug: http://parsoid-lb.eqiad.wikimedia.org/idwiki/Kota_Batu?oldid=8180803 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46811] Fix parsing of infobox templates used in table attribute position
https://bugzilla.wikimedia.org/show_bug.cgi?id=46811
--- Comment #7 from ssas...@wikimedia.org ---
The soln in Comment 6 could work but it has to be able to continue to deal with
(currently supported) scenarios like:
{| style='color:red;' {{echo|class='test'}}\n|foo\n|}
{| {{echo|class='test'}} style='color:red;'\n|foo\n|}
So, in general, it has to handle the following scenario.
{| <0 or more attrs> {{tpl here}} <0 or more attrs>
..
|}
In addition, this has to also deal with:
{| <0 or more attrs> {{tpl-that-generates-more-attrs-and-content}}
..
|}
So, this has the potential to get complex / fragile. I think the alternative --
Variant (1) in the description -- might potentially work out simpler and more
robust since it can handle all of these scenarios identically.
So, this is what the AttributeExpander sees in @ line 150 for newK.
["class=\"infobox \" style=\"float: right; clear: right; width: 315px;
border-spacing: 2px; text-align: left; font-size:
90%;\"",{"type":"NlTk","dataAttribs":{}},{"type":"TagTk","name":"th","attribs":
... }]
Hoisting everything from NlTk after the table token could work. But, you still
need to clean up after this fixup since the template expansion would have been
wrapped in meta-tags. So, you would have to hoist the tpl-start meta-tag to a
position before the table-start ...
So, instead of returning: cb( { tokens: [token] } ) .. you might fix this to
return [meta-start, token-with-fixed-attrs,
NlTk-and-all-other-tokens-found-in-attr]
Lot of hand-waving going on ... but, in either scenario, the template wrapping
will need fixing up in some fashion.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46811] Fix parsing of infobox templates used in table attribute position
https://bugzilla.wikimedia.org/show_bug.cgi?id=46811 Arlo Breault changed: What|Removed |Added Assignee|gwi...@wikimedia.org|abrea...@wikimedia.org -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46811] Fix parsing of infobox templates used in table attribute position
https://bugzilla.wikimedia.org/show_bug.cgi?id=46811
--- Comment #6 from Gabriel Wicke ---
I guess one hacky solution to this would be to add another 'in table attribute
position' flag to the transclusion processing pipeline. We could then pre-pend
'{|' to the returned transclusion source in order to make it parse correctly.
The tricky bit is that we'll likely have to also strip the extra table token to
avoid foster-parenting of the entire table.
These templates seem to be quite common and won't all be fixed up soon, so it
might be worth adding such a hack.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46811] Fix parsing of infobox templates used in table attribute position
https://bugzilla.wikimedia.org/show_bug.cgi?id=46811 Gabriel Wicke changed: What|Removed |Added Priority|Low |Normal -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46811] Fix parsing of infobox templates used in table attribute position
https://bugzilla.wikimedia.org/show_bug.cgi?id=46811 Arlo Breault changed: What|Removed |Added CC||amir.ahar...@mail.huji.ac.i ||l --- Comment #5 from Arlo Breault --- *** Bug 52889 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46811] Fix parsing of infobox templates used in table attribute position
https://bugzilla.wikimedia.org/show_bug.cgi?id=46811 Arlo Breault changed: What|Removed |Added CC||gwi...@wikimedia.org --- Comment #4 from Arlo Breault --- *** Bug 53139 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46811] Fix parsing of infobox templates used in table attribute position
https://bugzilla.wikimedia.org/show_bug.cgi?id=46811
--- Comment #3 from ssas...@wikimedia.org ---
Smaller test case than the one in the Description.
{|{{Infobox Aircraft Begin
|name=Mitsubishi 1MT
|image=Mitsubishi 1MT.jpg
|caption=
}}{{Infobox Aircraft Type
|type=[[Triplane]] [[torpedo bomber]]
|national origin=Japan
|manufacturer=[[Mitsubishi]]
|designer=Herbert Smith
|first flight={{avyear|1922}}
|introduced=
|retired=
|status=
|primary user=[[Imperial Japanese Navy Air Service]]
|more users=
|produced=
|number built=20
|variants with their own articles=
}}
--
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46811] Fix parsing of infobox templates used in table attribute position
https://bugzilla.wikimedia.org/show_bug.cgi?id=46811 Andre Klapper changed: What|Removed |Added Component|JS/General |General --- Comment #2 from Andre Klapper --- [Parsoid component reorg by merging JS/General and General. See bug 50685 for more information. Filter bugmail on this comment. parsoidreorg20130704] -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46811] Fix parsing of infobox templates used in table attribute position
https://bugzilla.wikimedia.org/show_bug.cgi?id=46811 Gabriel Wicke changed: What|Removed |Added Priority|Unprioritized |Low -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46811] Fix parsing of infobox templates used in table attribute position
https://bugzilla.wikimedia.org/show_bug.cgi?id=46811 --- Comment #1 from Gabriel Wicke --- Variant 2) (extra table start tag inside the template) is supported by the PHP parser, but currently not by Parsoid. There might be other broken template transclusions that are currently broken in Parsoid for this reason, so we should probably add support for it in any case. -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
