[Bug 47235] CodeEditor and the experimental live preview preference are not compatible.
https://bugzilla.wikimedia.org/show_bug.cgi?id=47235 --- Comment #9 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 110347 abandoned by Krinkle: Fire hook LivePreviewPrepare Reason: Closing. A 'before' fire is not compatible with how mw.hook works (asynchronous). https://gerrit.wikimedia.org/r/110347 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 47235] CodeEditor and the experimental live preview preference are not compatible.
https://bugzilla.wikimedia.org/show_bug.cgi?id=47235 --- Comment #10 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 119527 had a related patch set uploaded by Helder.wiki: Remove inexistent hook LivePreviewPrepare https://gerrit.wikimedia.org/r/119527 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 47235] CodeEditor and the experimental live preview preference are not compatible.
https://bugzilla.wikimedia.org/show_bug.cgi?id=47235 Bartosz Dziewoński matma@gmail.com changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 47235] CodeEditor and the experimental live preview preference are not compatible.
https://bugzilla.wikimedia.org/show_bug.cgi?id=47235 --- Comment #11 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 119527 merged by jenkins-bot: Remove inexistent hook LivePreviewPrepare https://gerrit.wikimedia.org/r/119527 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 47235] CodeEditor and the experimental live preview preference are not compatible.
https://bugzilla.wikimedia.org/show_bug.cgi?id=47235 --- Comment #8 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 110347 had a related patch set uploaded by Helder.wiki: Fire hook LivePreviewPrepare https://gerrit.wikimedia.org/r/110347 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 47235] CodeEditor and the experimental live preview preference are not compatible.
https://bugzilla.wikimedia.org/show_bug.cgi?id=47235 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|RESOLVED|PATCH_TO_REVIEW Resolution|FIXED |--- -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 47235] CodeEditor and the experimental live preview preference are not compatible.
https://bugzilla.wikimedia.org/show_bug.cgi?id=47235 Brad Jorsch bjor...@wikimedia.org changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #7 from Brad Jorsch bjor...@wikimedia.org --- Merged. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 47235] CodeEditor and the experimental live preview preference are not compatible.
https://bugzilla.wikimedia.org/show_bug.cgi?id=47235 --- Comment #6 from Gerrit Notification Bot gerritad...@wikimedia.org --- Related URL: https://gerrit.wikimedia.org/r/62814 (Gerrit Change I39c626d066797d887769c3715df88838e709d527) -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 47235] CodeEditor and the experimental live preview preference are not compatible.
https://bugzilla.wikimedia.org/show_bug.cgi?id=47235 --- Comment #5 from Gerrit Notification Bot gerritad...@wikimedia.org --- Related URL: https://gerrit.wikimedia.org/r/62612 (Gerrit Change Iba1b727c55aabcd31afc06cec99618fcdce207d8) -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 47235] CodeEditor and the experimental live preview preference are not compatible.
https://bugzilla.wikimedia.org/show_bug.cgi?id=47235 Brad Jorsch bjor...@wikimedia.org changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|wikibugs-l@lists.wikimedia. |bjor...@wikimedia.org |org | -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 47235] CodeEditor and the experimental live preview preference are not compatible.
https://bugzilla.wikimedia.org/show_bug.cgi?id=47235 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Priority|Unprioritized |Normal -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 47235] CodeEditor and the experimental live preview preference are not compatible.
https://bugzilla.wikimedia.org/show_bug.cgi?id=47235 Brad Jorsch bjor...@wikimedia.org changed: What|Removed |Added CC||br...@wikimedia.org Component|Scribunto |CodeEditor Summary|'Show changes' button on|CodeEditor and the |page editing interface |experimental live preview |always shows an empty diff |preference are not |for modules on zhwiki |compatible. --- Comment #3 from Brad Jorsch bjor...@wikimedia.org --- (In reply to comment #0) I have live (ajax) preview enabled. This is the key. It refers to the Use live preview (requires JavaScript) (experimental) preference in the Editing tab. It appears that this has nothing to do with Scribunto. The problem is that CodeEditor and the Use live preview preference are not compatible: live preview reads out the content of the text box to find the text to diff, but CodeEditor does not update the (hidden) text box until the form is submitted. If the toggle button in CodeEditor's UI is used to display the text box, live preview's diff button works fine. I imagine that CodeEditor's javascript would need to listen for the LivePreviewPrepare event sent by the live preview javascript (see resources/mediawiki.action/mediawiki.action.edit.preview.js line 15) and update the hidden text box so live preview is able to find the updated text. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 47235] CodeEditor and the experimental live preview preference are not compatible.
https://bugzilla.wikimedia.org/show_bug.cgi?id=47235 Bartosz Dziewoński matma@gmail.com changed: What|Removed |Added CC||matma@gmail.com --- Comment #4 from Bartosz Dziewoński matma@gmail.com --- (In reply to comment #3) I imagine that CodeEditor's javascript would need to listen for the LivePreviewPrepare event sent by the live preview javascript (see resources/mediawiki.action/mediawiki.action.edit.preview.js line 15) and update the hidden text box so live preview is able to find the updated text. That event might be killed after the fix for bug 23580 is merged. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
