[Bug 47375] Address DB transaction callbacks still pending warnings from Database.php
https://bugzilla.wikimedia.org/show_bug.cgi?id=47375
--- Comment #11 from Dan Barrett mediaw...@blazemonger.com ---
I've been getting these in 1.22.5 when trying to delete an article. The delete
fails with:
A database query error has occurred. This may indicate a bug in the
software.
and in the logs:
[Fri May 30 11:20:45 2014] [error] [client 11.22.33.44] PHP Notice:
Uncommitted DB writes (transaction from WikiPage::doDeleteArticleReal). in
/mnt/mywiki/w/includes/db/Database.php on line 3944, referer:
http://mywiki.mysite.net/w/index.php?title=How_to_add_the_redactedaction=delete
[Fri May 30 11:20:45 2014] [error] [client 11.22.33.44] PHP Stack trace:,
referer:
http://mywiki.mysite.net/w/index.php?title=How_to_add_the_redactedaction=delete
[Fri May 30 11:20:45 2014] [error] [client 11.22.33.44] PHP 1. {main}()
/mnt/mywiki/w/index.php:0, referer:
http://mywiki.mysite.net/w/index.php?title=How_to_add_the_redactedaction=delete
[Fri May 30 11:20:45 2014] [error] [client 11.22.33.44] PHP 2.
MediaWiki-run() /mnt/mywiki/w/index.php:65, referer:
http://mywiki.mysite.net/w/index.php?title=How_to_add_the_redactedaction=delete
[Fri May 30 11:20:45 2014] [error] [client 11.22.33.44] PHP 3.
MWExceptionHandler::handle() /mnt/mywiki/w/includes/Wiki.php:470, referer:
http://mywiki.mysite.net/w/index.php?title=How_to_add_the_redactedaction=delete
[Fri May 30 11:20:45 2014] [error] [client 11.22.33.44] PHP 4.
DatabaseBase-__destruct() /mnt/mywiki/w/includes/db/Database.php:0, referer:
http://mywiki.mysite.net/w/index.php?title=How_to_add_the_redactedaction=delete
[Fri May 30 11:20:45 2014] [error] [client 11.22.33.44] PHP 5.
trigger_error() /mnt/mywiki/w/includes/db/Database.php:3944, referer:
http://mywiki.mysite.net/w/index.php?title=How_to_add_the_redactedaction=delete
[Fri May 30 11:20:45 2014] [error] [client 11.22.33.44] PHP Notice: DB
transaction callbacks still pending (from Title::invalidateCache,
HTMLCacheUpdate::doUpdate, EmailNotification::notifyOnPageChange). in
/mnt/mywiki/w/includes/db/Database.php on line 3953, referer:
http://mywiki.mysite.net/w/index.php?title=How_to_add_the_redactedaction=delete
[Fri May 30 11:20:45 2014] [error] [client 11.22.33.44] PHP Stack trace:,
referer:
http://mywiki.mysite.net/w/index.php?title=How_to_add_the_redactedaction=delete
[Fri May 30 11:20:45 2014] [error] [client 11.22.33.44] PHP 1. {main}()
/mnt/mywiki/w/index.php:0, referer:
http://mywiki.mysite.net/w/index.php?title=How_to_add_the_redactedaction=delete
[Fri May 30 11:20:45 2014] [error] [client 11.22.33.44] PHP 2.
MediaWiki-run() /mnt/mywiki/w/index.php:65, referer:
http://mywiki.mysite.net/w/index.php?title=How_to_add_the_redactedaction=delete
[Fri May 30 11:20:45 2014] [error] [client 11.22.33.44] PHP 3.
MWExceptionHandler::handle() /mnt/mywiki/w/includes/Wiki.php:470, referer:
http://mywiki.mysite.net/w/index.php?title=How_to_add_the_redactedaction=delete
[Fri May 30 11:20:45 2014] [error] [client 11.22.33.44] PHP 4.
DatabaseBase-__destruct() /mnt/mywiki/w/includes/db/Database.php:0, referer:
http://mywiki.mysite.net/w/index.php?title=How_to_add_the_redactedaction=delete
[Fri May 30 11:20:45 2014] [error] [client 11.22.33.44] PHP 5.
trigger_error() /mnt/mywiki/w/includes/db/Database.php:3953, referer:
http://mywiki.mysite.net/w/index.php?title=How_to_add_the_redactedaction=delete
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 47375] Address DB transaction callbacks still pending warnings from Database.php
https://bugzilla.wikimedia.org/show_bug.cgi?id=47375 --- Comment #12 from Jesús Martínez Novo (Ciencia Al Poder) martinezn...@gmail.com --- This warning should go away, and be thrown only when $wgDevelopmentWarnings is set to true. Otherwise, many errors get masked by this one, since the original error happens, and then when MediaWiki closes the connection, throws this one because the original error prevented the commit or rollback. This warning is useless in production environments! -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 47375] Address DB transaction callbacks still pending warnings from Database.php
https://bugzilla.wikimedia.org/show_bug.cgi?id=47375 Bug 47375 depends on bug 65263, which changed state. Bug 65263 Summary: Exceptions when database connection is lost and automatically reopened with pending transaction idle callbacks https://bugzilla.wikimedia.org/show_bug.cgi?id=65263 What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 47375] Address DB transaction callbacks still pending warnings from Database.php
https://bugzilla.wikimedia.org/show_bug.cgi?id=47375
Southparkfan southparkfan...@hotmail.com changed:
What|Removed |Added
CC||southparkfan...@hotmail.com
--- Comment #13 from Southparkfan southparkfan...@hotmail.com ---
(In reply to Dan Barrett from comment #11)
I've been getting these in 1.22.5 when trying to delete an article. The
delete fails with:
A database query error has occurred. This may indicate a bug in the
software.
and in the logs:
[Fri May 30 11:20:45 2014] [error] [client 11.22.33.44] PHP Notice:
Uncommitted DB writes (transaction from WikiPage::doDeleteArticleReal). in
/mnt/mywiki/w/includes/db/Database.php on line 3944, referer:
http://mywiki.mysite.net/w/index.
php?title=How_to_add_the_redactedaction=delete
[Fri May 30 11:20:45 2014] [error] [client 11.22.33.44] PHP Stack trace:,
referer:
http://mywiki.mysite.net/w/index.
php?title=How_to_add_the_redactedaction=delete
[Fri May 30 11:20:45 2014] [error] [client 11.22.33.44] PHP 1. {main}()
/mnt/mywiki/w/index.php:0, referer:
http://mywiki.mysite.net/w/index.
php?title=How_to_add_the_redactedaction=delete
[Fri May 30 11:20:45 2014] [error] [client 11.22.33.44] PHP 2.
MediaWiki-run() /mnt/mywiki/w/index.php:65, referer:
http://mywiki.mysite.net/w/index.
php?title=How_to_add_the_redactedaction=delete
[Fri May 30 11:20:45 2014] [error] [client 11.22.33.44] PHP 3.
MWExceptionHandler::handle() /mnt/mywiki/w/includes/Wiki.php:470, referer:
http://mywiki.mysite.net/w/index.
php?title=How_to_add_the_redactedaction=delete
[Fri May 30 11:20:45 2014] [error] [client 11.22.33.44] PHP 4.
DatabaseBase-__destruct() /mnt/mywiki/w/includes/db/Database.php:0,
referer:
http://mywiki.mysite.net/w/index.
php?title=How_to_add_the_redactedaction=delete
[Fri May 30 11:20:45 2014] [error] [client 11.22.33.44] PHP 5.
trigger_error() /mnt/mywiki/w/includes/db/Database.php:3944, referer:
http://mywiki.mysite.net/w/index.
php?title=How_to_add_the_redactedaction=delete
[Fri May 30 11:20:45 2014] [error] [client 11.22.33.44] PHP Notice: DB
transaction callbacks still pending (from Title::invalidateCache,
HTMLCacheUpdate::doUpdate, EmailNotification::notifyOnPageChange). in
/mnt/mywiki/w/includes/db/Database.php on line 3953, referer:
http://mywiki.mysite.net/w/index.
php?title=How_to_add_the_redactedaction=delete
[Fri May 30 11:20:45 2014] [error] [client 11.22.33.44] PHP Stack trace:,
referer:
http://mywiki.mysite.net/w/index.
php?title=How_to_add_the_redactedaction=delete
[Fri May 30 11:20:45 2014] [error] [client 11.22.33.44] PHP 1. {main}()
/mnt/mywiki/w/index.php:0, referer:
http://mywiki.mysite.net/w/index.
php?title=How_to_add_the_redactedaction=delete
[Fri May 30 11:20:45 2014] [error] [client 11.22.33.44] PHP 2.
MediaWiki-run() /mnt/mywiki/w/index.php:65, referer:
http://mywiki.mysite.net/w/index.
php?title=How_to_add_the_redactedaction=delete
[Fri May 30 11:20:45 2014] [error] [client 11.22.33.44] PHP 3.
MWExceptionHandler::handle() /mnt/mywiki/w/includes/Wiki.php:470, referer:
http://mywiki.mysite.net/w/index.
php?title=How_to_add_the_redactedaction=delete
[Fri May 30 11:20:45 2014] [error] [client 11.22.33.44] PHP 4.
DatabaseBase-__destruct() /mnt/mywiki/w/includes/db/Database.php:0,
referer:
http://mywiki.mysite.net/w/index.
php?title=How_to_add_the_redactedaction=delete
[Fri May 30 11:20:45 2014] [error] [client 11.22.33.44] PHP 5.
trigger_error() /mnt/mywiki/w/includes/db/Database.php:3953, referer:
http://mywiki.mysite.net/w/index.
php?title=How_to_add_the_redactedaction=delete
Have you more info about PHP/Database (like MySQL) version, installed
extensions, etc?
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 47375] Address DB transaction callbacks still pending warnings from Database.php
https://bugzilla.wikimedia.org/show_bug.cgi?id=47375 --- Comment #14 from Dan Barrett mediaw...@blazemonger.com --- MediaWiki 1.22.5 on a cluster with 3 front-end web servers through a load-balancer, and 2 database servers (one master replicating to one slave) mysql Ver 14.14 Distrib 5.5.37 Over 120 extensions, most of them custom-built. It's a production environment and we can't turn off extensions. The problem has never appeared in any of our (non-clustered) test environments, only on the production cluster. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 47375] Address DB transaction callbacks still pending warnings from Database.php
https://bugzilla.wikimedia.org/show_bug.cgi?id=47375 --- Comment #15 from Dan Barrett mediaw...@blazemonger.com --- Correction to comment 14: three database servers, one master replicating to 2 slaves. (However, one of the slaves is not accessed by users... it's just for reporting purposes.) Happy to answer more questions and try things out. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 47375] Address DB transaction callbacks still pending warnings from Database.php
https://bugzilla.wikimedia.org/show_bug.cgi?id=47375 --- Comment #16 from Dan Barrett mediaw...@blazemonger.com --- also PHP 5.4.27. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 47375] Address DB transaction callbacks still pending warnings from Database.php
https://bugzilla.wikimedia.org/show_bug.cgi?id=47375 Brad Jorsch bjor...@wikimedia.org changed: What|Removed |Added Depends on||65263 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 47375] Address DB transaction callbacks still pending warnings from Database.php
https://bugzilla.wikimedia.org/show_bug.cgi?id=47375 Jesús Martínez Novo (Ciencia Al Poder) martinezn...@gmail.com changed: What|Removed |Added CC||martinezn...@gmail.com --- Comment #10 from Jesús Martínez Novo (Ciencia Al Poder) martinezn...@gmail.com --- (In reply to comment #9) There's another instance of what you describe in https://www.mediawiki.org/wiki/Thread:Project:Support_desk/Mediawiki_1%2E22+_Causes_two_of_my_servers_to_hang_indefinitely%2E -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 47375] Address DB transaction callbacks still pending warnings from Database.php
https://bugzilla.wikimedia.org/show_bug.cgi?id=47375 Dan Barrett mediaw...@blazemonger.com changed: What|Removed |Added CC||mediaw...@blazemonger.com --- Comment #9 from Dan Barrett mediaw...@blazemonger.com --- I am also experiencing this problem (see mediawiki-l post http://lists.wikimedia.org/pipermail/mediawiki-l/2014-January/042329.html) and have some additional data. I installed the same 1.22.0 codebase and database on two different Linux servers. Server #1 has PHP 5.5.3 and mySQL 5.5.34), and serer #2 has PHP 5.3.27 and mySQL 5.1.68. Server #2 has the problem and server #1 does not. On server #1, I deployed 1.22.0 and copied my /images and LocalSettings.php files from 1.21.3, then ran update.php. Everything worked. I copied the same files to server #2, ran update.php, and saw no errors. Then I hit the main page (whatever.com/wiki/Home) as an anonymous user. When the home page rendered, it had this error message printed at the bottom: Notice: Uncommitted DB writes (transaction from DatabaseBase::query (WikiPage::pageData)). in ./w/includes/db/Database.php on line 3944 I clicked Log In, and the home page just sat there. Running a ps uax I saw these processes: me 16283 0.5 1.0 160180 43948 ? S23:45 0:00 /usr/bin/php /home/me/public_html/w/index.php me 16286 0.0 0.0 00 ?Z23:45 0:00 [bash] defunct me 16287 0.0 0.4 134764 17532 ? S23:45 0:00 /usr/bin/php /home/me/public_html/w/maintenance/runJobs.php --maxjobs 1 me 16295 0.4 1.0 160036 43856 ? S23:45 0:00 /usr/bin/php /home/me/public_html/w/index.php me 16296 0.0 0.0 00 ?Z23:45 0:00 [bash] defunct me 16297 0.1 0.4 134764 17544 ? S23:45 0:00 /usr/bin/php /home/me/public_html/w/maintenance/runJobs.php --maxjobs 1 me 16847 0.1 0.4 87388 17468 ? S23:46 0:00 /usr/bin/php /home/me/public_html/w/index.php me 16856 0.1 0.4 87388 17480 ? S23:46 0:00 /usr/bin/php /home/me/public_html/w/index.php me 16878 0.1 0.4 87388 17468 ? S23:46 0:00 /usr/bin/php /home/me/public_html/w/index.php I checked the job queue with maintenance/showJobs.php, and there were 0 jobs. The processes were not exiting (my browser was still spinning), so I killed them by hand. Still baffled about what to do. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 47375] Address DB transaction callbacks still pending warnings from Database.php
https://bugzilla.wikimedia.org/show_bug.cgi?id=47375
Krinkle krinklem...@gmail.com changed:
What|Removed |Added
CC||krinklem...@gmail.com
Summary|Transaction idle or |Address DB transaction
|pre-commit callbacks still |callbacks still pending
|pending |warnings from Database.php
--- Comment #8 from Krinkle krinklem...@gmail.com ---
There are four different code paths emitting this type of notice:
@ class Database
public function close() {
if ( count( $this-mTrxIdleCallbacks ) ) {
throw new MWException( Transaction idle callbacks still pending. );
...
@ class Database
public function close() {
...
if ( $this-mConn
$this-trxLevel()
!$this-mTrxAutomatic
) {
wfWarn( Transaction still in progress (from {$this-mTrxFname}), .
performing implicit commit before closing connection! );
...
@ class Database
public function __destruct() {
if ( $this-mTrxLevel $this-mTrxDoneWrites ) {
trigger_error( Uncommitted DB writes (transaction from
{$this-mTrxFname}). );
...
@ class Database
public function __destruct() {
...
if ( count( $this-mTrxIdleCallbacks ) || count(
$this-mTrxPreCommitCallbacks ) ) {
...
trigger_error( DB transaction callbacks still pending (from
$callers). );
...
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
