[Bug 47544] references/ list item must not wrap the text in span
https://bugzilla.wikimedia.org/show_bug.cgi?id=47544 --- Comment #9 from TMg mr.h...@gmx.de --- *** Bug 38661 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 47544] references/ list item must not wrap the text in span
https://bugzilla.wikimedia.org/show_bug.cgi?id=47544
--- Comment #10 from TMg mr.h...@gmx.de ---
(In reply to comment #8)
so it should still remain in ext.cite.popup.js ?
The most simple and straightforward fix is to use a div ... instead of the
span class=reference-text and add
.reference-text { display: inline; }
to all screen and print CSS files (don't forget print). This solution may need
additional tweaking. But in my opinion it should be done in any case. If it
causes other issues these issues should be fixed separately.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 47544] references/ list item must not wrap the text in span
https://bugzilla.wikimedia.org/show_bug.cgi?id=47544 Tony Thomas 01tonytho...@gmail.com changed: What|Removed |Added CC||01tonytho...@gmail.com Assignee|wikibugs-l@lists.wikimedia. |01tonytho...@gmail.com |org | -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 47544] references/ list item must not wrap the text in span
https://bugzilla.wikimedia.org/show_bug.cgi?id=47544 Michael M. listenle...@gmail.com changed: What|Removed |Added CC||listenle...@gmail.com --- Comment #7 from Michael M. listenle...@gmail.com --- (In reply to comment #6) The wrapper should simply be removed. The class refernce-text is used in some places to detect the actual content of a reference, including in the script ext.cite.popups.js provided by the extension itself. The fact that Tidy sometimes removes that class is bug 38661. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 47544] references/ list item must not wrap the text in span
https://bugzilla.wikimedia.org/show_bug.cgi?id=47544 --- Comment #8 from Tony Thomas 01tonytho...@gmail.com --- The class refernce-text is used in some places to detect the actual content of a reference, including in the script ext.cite.popups.js provided by the extension itself. so it should still remain in ext.cite.popup.js ? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 47544] references/ list item must not wrap the text in span
https://bugzilla.wikimedia.org/show_bug.cgi?id=47544
--- Comment #5 from TMg mr.h...@gmx.de ---
I'm sorry but it seems we are not talking about the same. When I enter this:
ref name=t
{|
|t
|}/ref
references /
in a local MediaWiki with Tidy disabled I get this:
ol class=references
li id=cite_note-t-1span class=mw-cite-backlinka
href=#cite_ref-t_1-0↑/a/span span class=reference-text
table
tr
tdt
/td/tr/table/span
/li
/ol
This HTML is wrongly nested. Because of this Tidy tries to fix it. It becomes:
ol class=references
li id=cite_note-t-1span class=mw-cite-backlinka
href=#cite_ref-t_1-0↑/a/span
table
tr
tdt/td
/tr
/table
/li
/ol
As you can see the class=reference-text is simply deleted. This is not good.
The class should be there no matter what is inside of the reference.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 47544] references/ list item must not wrap the text in span
https://bugzilla.wikimedia.org/show_bug.cgi?id=47544 --- Comment #6 from TMg mr.h...@gmx.de --- (In reply to comment #0) The easiest solution is to remove the span class=reference-text wrapper. I was playing around with different possible solutions (switching to a DIV depending on the text, adding default styles) and I agree. The wrapper should simply be removed. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 47544] references/ list item must not wrap the text in span
https://bugzilla.wikimedia.org/show_bug.cgi?id=47544 --- Comment #4 from Rohan Verma rohan.j.ve...@gmail.com --- Just to confirm we are talking about the same thing: span span1 /span table stuff /table span span2 /span Is wrong? when I said before and after I meant it creates a separate span before and after the block element for the rest of the reference. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 47544] references/ list item must not wrap the text in span
https://bugzilla.wikimedia.org/show_bug.cgi?id=47544 Rohan Verma rohan.j.ve...@gmail.com changed: What|Removed |Added CC||rohan.j.ve...@gmail.com --- Comment #2 from Rohan Verma rohan.j.ve...@gmail.com --- I tried to find a case where this could be a problem but even with a table within the reference it just simply puts a span before and after the table element. If anyone finds a case where this is unpredictable or a block element that doesn't work please post it and I will look at this further. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 47544] references/ list item must not wrap the text in span
https://bugzilla.wikimedia.org/show_bug.cgi?id=47544 --- Comment #3 from TMg mr.h...@gmx.de --- (In reply to comment #2) it just simply puts a span before and after the table Which is semantically wrong. It's not allowed to put block elements into inline elements. Web browsers are able to deal with almost every bad HTML but it is still wrong. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 47544] references/ list item must not wrap the text in span
https://bugzilla.wikimedia.org/show_bug.cgi?id=47544 TMg mr.h...@gmx.de changed: What|Removed |Added CC||mr.h...@gmx.de --- Comment #1 from TMg mr.h...@gmx.de --- Could you please add an example URL or explain a common case that contains block elements? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 47544] references/ list item must not wrap the text in span
https://bugzilla.wikimedia.org/show_bug.cgi?id=47544 Danny B. dann...@email.cz changed: What|Removed |Added Priority|Unprioritized |Normal Whiteboard||usability -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 47544] references/ list item must not wrap the text in span
https://bugzilla.wikimedia.org/show_bug.cgi?id=47544 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Priority|Normal |Low Severity|normal |minor -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
