[Bug 48885] VisualEditor: jQuery and mediaWiki globals should be used through closures, not directly through $ and mw
https://bugzilla.wikimedia.org/show_bug.cgi?id=48885
--- Comment #2 from Krinkle krinklem...@gmail.com ---
I suggest for standalone we introduce an module-intro/outro that is used to
wrap around individual modules (not per file).
So e.g. dist/ve.core.js would be:
-- intro
( function ( ve, $ ) {
-- include ve.js
-- include ve.A.js
-- include ve.B.js
-- include ve.C.js
-- outro
}( VisualEditor, jQuery ) );
And in MediaWiki the same would effectively happen but on-demand by
ResourceLoader (since we don't want to use a build system for MW, but instead
work on the raw source files directly and have them build dynamically).
See bug 48886 for details, but the end result would be:
-- startup:
register(
..,
[ 'ext.visualEditor', 1234, , ['VisualEditor']
);
-- mw.loader:
script( $, global[propKeys..].. );
-- load.php response when loading visualeditor:
mw.loader.implement( 'ext.visualEditor.core', function ( $, ve ) {
-- include ve.js
-- include ve.A.js
-- include ve.B.js
-- include ve.C.js
} );
--
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48885] VisualEditor: jQuery and mediaWiki globals should be used through closures, not directly through $ and mw
https://bugzilla.wikimedia.org/show_bug.cgi?id=48885 James Forrester jforres...@wikimedia.org changed: What|Removed |Added Assignee|roan.katt...@gmail.com |jforrester+veteambztickets@ ||wikimedia.org -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48885] VisualEditor: jQuery and mediaWiki globals should be used through closures, not directly through $ and mw
https://bugzilla.wikimedia.org/show_bug.cgi?id=48885 James Forrester jforres...@wikimedia.org changed: What|Removed |Added Severity|normal |enhancement -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48885] VisualEditor: jQuery and mediaWiki globals should be used through closures, not directly through $ and mw
https://bugzilla.wikimedia.org/show_bug.cgi?id=48885 James Forrester jforres...@wikimedia.org changed: What|Removed |Added Priority|Unprioritized |Low Status|NEW |ASSIGNED Summary|jQuery and mediaWiki|VisualEditor: jQuery and |globals should be used |mediaWiki globals should be |through closures, not |used through closures, not |directly through $ and mw |directly through $ and mw -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48885] VisualEditor: jQuery and mediaWiki globals should be used through closures, not directly through $ and mw
https://bugzilla.wikimedia.org/show_bug.cgi?id=48885 --- Comment #1 from Krinkle krinklem...@gmail.com --- For the record, inside ResourceLoader context $ is a local variable provided by the ResourceLoader built-in closure. See also bug 48886. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
