[Bug 49232] $wgWellFormedXml = false; breaks our EditPage broken bot protection in edittoken
https://bugzilla.wikimedia.org/show_bug.cgi?id=49232
--- Comment #5 from Gerrit Notification Bot ---
Change 67603 restored by Krinkle:
Always quote attribute values ending in a backslash
Reason:
If an unquoted attribute value ending in \ actually works in modern browsers,
and if EditPage wants older/broken browsers to work regardless (the token slash
is mostly to reject bots/scripts, it makes sense to try and support browsers
where possible since clients are helpless otherwise), then it would make sense
to do the quoting in EditPage.
However that's not the case.
div = document.createElement('div');
div.innerHTML = '';
div.firstChild.value
> "+"
div.innerHTML = '';
div.firstChild.value
> "c02a+"
It seems that when it's parsed as part of a server-response (instead of in a
fragment), that it does work, however. Which is why third-party wikis disabling
good ol' wgWellFormedXml doesn't result in a broken EditPage.
https://gerrit.wikimedia.org/r/67603
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49232] $wgWellFormedXml = false; breaks our EditPage broken bot protection in edittoken
https://bugzilla.wikimedia.org/show_bug.cgi?id=49232 --- Comment #4 from Gerrit Notification Bot --- Change 67603 abandoned by Hashar: Always quote attribute values ending in a backslash Reason: Abandoning old change. Feel free to reopen if there is still an interest in getting this merged. https://gerrit.wikimedia.org/r/67603 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49232] $wgWellFormedXml = false; breaks our EditPage broken bot protection in edittoken
https://bugzilla.wikimedia.org/show_bug.cgi?id=49232 Krinkle changed: What|Removed |Added Blocks||50040 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49232] $wgWellFormedXml = false; breaks our EditPage broken bot protection in edittoken
https://bugzilla.wikimedia.org/show_bug.cgi?id=49232 --- Comment #3 from Daniel Friesen --- gerrit 67603 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49232] $wgWellFormedXml = false; breaks our EditPage broken bot protection in edittoken
https://bugzilla.wikimedia.org/show_bug.cgi?id=49232 --- Comment #2 from Daniel Friesen --- (In reply to comment #1) > What is the actual issue here? The \ in our edit token is intended to be output into the page as \". It's a protection against badly written proxies. These proxies strip the \ turning \" into " (which could break the content). However when `$wgWellFormedXml = false;` is set it changes to value=+\. Which means that " is no longer present and it will no longer trip up the badly written proxies. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49232] $wgWellFormedXml = false; breaks our EditPage broken bot protection in edittoken
https://bugzilla.wikimedia.org/show_bug.cgi?id=49232 Niklas Laxström changed: What|Removed |Added CC||niklas.laxst...@gmail.com --- Comment #1 from Niklas Laxström --- What is the actual issue here? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49232] $wgWellFormedXml = false; breaks our EditPage broken bot protection in edittoken
https://bugzilla.wikimedia.org/show_bug.cgi?id=49232 Andre Klapper changed: What|Removed |Added Priority|Unprioritized |Normal -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
