[Bug 49259] Patrolling through API is not possible any more due to the removal of rcid

2014-03-12 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=49259

Marius Hoch h...@online.de changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
   Assignee|h...@online.de   |wikibugs-l@lists.wikimedia.
   ||org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 49259] Patrolling through API is not possible any more due to the removal of rcid

2013-06-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=49259

kipod fur.hew...@gmail.com changed:

   What|Removed |Added

   Priority|Normal  |Low
   Severity|major   |minor

--- Comment #12 from kipod fur.hew...@gmail.com ---
since the main issue is resolved (and the script that uses it is working again
- thanks!). 
i do not expect the little detail that's left unsolved to ever be fixed, and
i'm lowering importance to Low/minor.

i will rephrase the problem, in case someone would like to take a shot at it:

=== REPHRASING ==
in order for us to be able to patrol new pages from recent changes special
page, we need to have the revid of a new page available on recent changes.
this can be done, e.g., by adding a data-revid attribute to one of the
elements on the line that describes the new page.
this should be available for both normal and enhanced recent changes, and
it would be best if it's available in exactly the same form on both.


peace.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 49259] Patrolling through API is not possible any more due to the removal of rcid

2013-06-13 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=49259

Andre Klapper aklap...@wikimedia.org changed:

   What|Removed |Added

   Priority|High|Normal

--- Comment #11 from Andre Klapper aklap...@wikimedia.org ---
(In reply to comment #10)
 The above change has been merged

Thanks Markus! Lowering priority. Feel free to unassign if you don't plan to
work on this further, and anybody feel free to update the bug summary to
reflect what is left to do.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 49259] Patrolling through API is not possible any more due to the removal of rcid

2013-06-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=49259

--- Comment #8 from kipod fur.hew...@gmail.com ---
Thanks. There is one more thing, though:
For a change in existing page, the revid is present as the parameter to the
diff= field of the prev and curr fields in Special:RecentChanges.

However, for new pages, the revid is not part of the RecentChanges page.

It will be very helpful if we can add this information: strictly speaking it
may not exactly belong in this patch, but if one thinks of this patch as
mitigating the negative effects of I1e24733cafbfdc51b7a5a9a1c1baf948e760fe1a,
and considering the fact that we *did* have rcid for new pages, it make sense
to add it.

I think it would be nice to have it (maybe something like data-revid
attribute to the abbr.newpage element?), but the details are not that
important - adding the revid *anywhere* on RecentChanges page for newpage
lines will be good.

Thanks,
Peace.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 49259] Patrolling through API is not possible any more due to the removal of rcid

2013-06-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=49259

--- Comment #9 from kipod fur.hew...@gmail.com ---
ooops - i mixed my metaphors. the revid is not in the curr/prev links (these
belong to action=history, not Special:RecentChanges).

What I meant was the diff= field of the diff link. 
for new pages, there is no diff link, so we do not have the revid for new
pages, and it would be helpful to have it just anywhere on the new page line
of recentchanges.


Peace.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 49259] Patrolling through API is not possible any more due to the removal of rcid

2013-06-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=49259

--- Comment #10 from Marius Hoch h...@online.de ---
The above change has been merged, but I leave this bug open for now:

(In reply to comment #9)
 for new pages, there is no diff link, so we do not have the revid for new
 pages, and it would be helpful to have it just anywhere on the new page
 line of recentchanges.

I'm not a fan of this kind of workaround. Maybe we should also allow the
patrolling api to take page names (only for new page patrol, obviously)?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 49259] Patrolling through API is not possible any more due to the removal of rcid

2013-06-08 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=49259

db duplicate...@googlemail.com changed:

   What|Removed |Added

 CC||duplicate...@googlemail.com

--- Comment #6 from db duplicate...@googlemail.com ---
It is still possible to get the id through the api, see
action=querylist=recentchangesrcprop=ids, but it is hard to find the
corresponding id for one title in one request, so the idea of allowing a
revision id to be used in action=patrol is the better way.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 49259] Patrolling through API is not possible any more due to the removal of rcid

2013-06-08 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=49259

--- Comment #7 from Marius Hoch h...@online.de ---
https://gerrit.wikimedia.org/r/67624

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 49259] Patrolling through API is not possible any more due to the removal of rcid

2013-06-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=49259

Alex Monk (Krenair) kren...@gmail.com changed:

   What|Removed |Added

 CC||kren...@gmail.com
Summary|Due to change   |Patrolling through API is
   |I1e24733cafbfdc51b7a5a9a1c1 |not possible any more due
   |baf948e760fe1a, patrolling  |to the removal of rcid
   |through API is not possible |
   |any more|

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 49259] Patrolling through API is not possible any more due to the removal of rcid

2013-06-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=49259

--- Comment #2 from kipod fur.hew...@gmail.com ---
(In reply to comment #0)
 (priority #1: this will be the best solution for me)
 * teach action=patrol API call to optionally accept curid (which still
 appears
 in recentchanges page) or edit ID (content of diff=) instead of rcid.
 if someone can suggest a workaround that will allow patrolling from the
 recentchanges page with the current mw version (1.22wmf5), i'll be extremely
 grateful.
 
 peace.

not 100% sure what curid is, but assuming it's the last recent change id
for this page (which means the same curid can appear for more than one
change), then using curid is not an option. using commit-id will still work for
me.

peace.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 49259] Patrolling through API is not possible any more due to the removal of rcid

2013-06-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=49259

Marius Hoch h...@online.de changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|wikibugs-l@lists.wikimedia. |h...@online.de
   |org |

--- Comment #3 from Marius Hoch h...@online.de ---
(In reply to comment #2)
 not 100% sure what curid is, but assuming it's the last recent change id
 for this page (which means the same curid can appear for more than one
 change), then using curid is not an option.
curid is the page id.

(In reply to comment #2)
 using commit-id will still work for me.
What you mean is the revision id. I've just implemented that and am going to
upload it after some testing tomorrow as it seems to be the sanest way to
resolve this bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 49259] Patrolling through API is not possible any more due to the removal of rcid

2013-06-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=49259

--- Comment #4 from kipod fur.hew...@gmail.com ---
thanks you much. 
i agree with your assessment: i have no desire to see rcid - from userland
POV, revision id is the only thing that counts, and teaching the API to execute
the patrol action using revision id is the sanest solution in my mind also
(and that's why it's listed in comment #0 as the most desirable solution).

you are correct, i did mean revision id. 
this can be read from the content of the diff= in the prev link on
recentchanges and wathclist pages.

when you say upload, does this mean deploy to wikis?

peace.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 49259] Patrolling through API is not possible any more due to the removal of rcid

2013-06-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=49259

--- Comment #5 from Marius Hoch h...@online.de ---
(In reply to comment #4)
 when you say upload, does this mean deploy to wikis?
No, it means that I upload it to gerrit (https://gerrit.wikimedia.org) so that
it can be reviewed by other developers and later on be merged.
https://www.mediawiki.org/wiki/Gerrit

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l