[Bug 50316] Generate selser change assignments dynamically
https://bugzilla.wikimedia.org/show_bug.cgi?id=50316 Gabriel Wicke gwi...@wikimedia.org changed: What|Removed |Added Severity|normal |enhancement --- Comment #15 from Gabriel Wicke gwi...@wikimedia.org --- Lets keep using this bug, but reclassify it as an enhancement. Our selser test coverage can be improved further. Generating permutations systematically still seems to be a promising candidate solution for doing so. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 50316] Generate selser change assignments dynamically
https://bugzilla.wikimedia.org/show_bug.cgi?id=50316 Arlo Breault abrea...@wikimedia.org changed: What|Removed |Added Assignee|abrea...@wikimedia.org |gwi...@wikimedia.org -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 50316] Generate selser change assignments dynamically
https://bugzilla.wikimedia.org/show_bug.cgi?id=50316 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Status|PATCH_TO_REVIEW |NEW --- Comment #14 from Andre Klapper aklap...@wikimedia.org --- (In reply to ssastry from comment #13) We have a good workable solution for now, but I think Gabriel had the enhancement idea of generating selser tests by going through permutations. Gabriel: do you want to create a different enhancement ticket for it and close this one? Gabriel: ping? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 50316] Generate selser change assignments dynamically
https://bugzilla.wikimedia.org/show_bug.cgi?id=50316 --- Comment #12 from Andre Klapper aklap...@wikimedia.org --- Gabriel: All patches merged months ago - is there more work left here, or can you close this ticket as RESOLVED FIXED? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 50316] Generate selser change assignments dynamically
https://bugzilla.wikimedia.org/show_bug.cgi?id=50316 --- Comment #13 from ssas...@wikimedia.org --- We have a good workable solution for now, but I think Gabriel had the enhancement idea of generating selser tests by going through permutations. Gabriel: do you want to create a different enhancement ticket for it and close this one? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 50316] Generate selser change assignments dynamically
https://bugzilla.wikimedia.org/show_bug.cgi?id=50316 --- Comment #11 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 85952 merged by jenkins-bot: Remember the output of failing (blacklisted) tests https://gerrit.wikimedia.org/r/85952 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 50316] Generate selser change assignments dynamically
https://bugzilla.wikimedia.org/show_bug.cgi?id=50316 --- Comment #10 from Arlo Breault abrea...@wikimedia.org --- *** Bug 49222 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 50316] Generate selser change assignments dynamically
https://bugzilla.wikimedia.org/show_bug.cgi?id=50316 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|ASSIGNED|PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 50316] Generate selser change assignments dynamically
https://bugzilla.wikimedia.org/show_bug.cgi?id=50316 --- Comment #9 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 85952 had a related patch set uploaded by Arlolra: WIP: Remember the output of failing (blacklisted) tests https://gerrit.wikimedia.org/r/85952 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 50316] Generate selser change assignments dynamically
https://bugzilla.wikimedia.org/show_bug.cgi?id=50316 --- Comment #7 from Arlo Breault abrea...@wikimedia.org --- gwicke: In what way are these permutations? From the blacklist, add(selser, Non-word characters don't terminate tag names (bug 17663, 40670, 52022) [[3],3,[3],3,4,3,4,4,4,2,3]); this just looks like combinations with replacements. Given that there are 11 numbers between 2 and 4 inclusive, you'd have to generate 3^11 changes, rather than 20 random ones. That doesn't seem faster. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 50316] Generate selser change assignments dynamically
https://bugzilla.wikimedia.org/show_bug.cgi?id=50316 --- Comment #8 from Gabriel Wicke gwi...@wikimedia.org --- Deterministic generation will be faster than random generate test, as the latter will often result in duplicates which are then filtered out. Keep in mind that we try to generate a random assignment up to 1000 times, even if there are only a handful possible permutations in a small test. The extra attempts to generate permutations will just generate duplicates once the few possible permutations have been found. I agree that we'll need to limit the number of permutations we generate for large test cases. That means that generating all permutations with the current assignments won't be possible. On the bright side, there is a chance that we can get away with less permutations without really losing test coverage. As an example, case 2 (node insertion before current node) and case 4 (child node insertion) can result in the same actual change, so should probably be collapsed when that happens. Similarly, new node insertion is very similar to attribute changes for selser processing: the full 'outerwikitext' needs to be serialized in both cases. Lets discuss the possible cases and think about which cases need to be handled. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 50316] Generate selser change assignments dynamically
https://bugzilla.wikimedia.org/show_bug.cgi?id=50316 --- Comment #6 from Gabriel Wicke gwi...@wikimedia.org --- With generate test our assignments are not guaranteed to be exhaustive, which might be relevant for bug 52139. It might be worth moving to direct permutation generation instead, as that should also make change generation faster. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 50316] Generate selser change assignments dynamically
https://bugzilla.wikimedia.org/show_bug.cgi?id=50316 ssas...@wikimedia.org changed: What|Removed |Added Status|PATCH_TO_REVIEW |ASSIGNED --- Comment #5 from ssas...@wikimedia.org --- 3rd bullet point in bug description is actually bug 51718 -- need to figure out best approach for this (work through what is best -- technique as outlined in #3 here or something else). -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 50316] Generate selser change assignments dynamically
https://bugzilla.wikimedia.org/show_bug.cgi?id=50316 --- Comment #4 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 76870 merged by jenkins-bot: Generate selser change assignments dynamically. https://gerrit.wikimedia.org/r/76870 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 50316] Generate selser change assignments dynamically
https://bugzilla.wikimedia.org/show_bug.cgi?id=50316 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 50316] Generate selser change assignments dynamically
https://bugzilla.wikimedia.org/show_bug.cgi?id=50316 --- Comment #3 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 76870 had a related patch set uploaded by Arlolra: Generate selser change assignments dynamically. https://gerrit.wikimedia.org/r/76870 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 50316] Generate selser change assignments dynamically
https://bugzilla.wikimedia.org/show_bug.cgi?id=50316 Arlo Breault abrea...@wikimedia.org changed: What|Removed |Added CC||abrea...@wikimedia.org Assignee|gwi...@wikimedia.org|abrea...@wikimedia.org -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 50316] Generate selser change assignments dynamically
https://bugzilla.wikimedia.org/show_bug.cgi?id=50316 --- Comment #1 from C. Scott Ananian canan...@wikimedia.org --- It would probably be worth fixing bug 50982 first, while you can easily see the empty selser changes in the output file. Subbu thinks these might be the tests without wt2wt parsoid option ... would be good to atleast verify/confirm that hypothesis. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 50316] Generate selser change assignments dynamically
https://bugzilla.wikimedia.org/show_bug.cgi?id=50316 --- Comment #2 from Arlo Breault abrea...@wikimedia.org --- Re: comment 1. Unfortunately, that doesn't appear to be the case. A counter example is Parsoid only: Quote balancing context should be ... which has the options parsoid=wt2html,wt2wt. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 50316] Generate selser change assignments dynamically
https://bugzilla.wikimedia.org/show_bug.cgi?id=50316 ssas...@wikimedia.org changed: What|Removed |Added CC||canan...@wikimedia.org Summary|Improve parserTests.js |Generate selser change ||assignments dynamically -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
