[Bug 50419] VisualEditor: Selection over a line (with shift-down) applies formatting changes to second line (where logical selection ends), not just first line (where visible selection ends)

2014-02-28 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=50419

James Forrester jforres...@wikimedia.org changed:

   What|Removed |Added

   Assignee|da...@sheetmusic.org.uk |jforrester+veteambztickets@
   ||wikimedia.org

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 50419] VisualEditor: Selection over a line (with shift-down) applies formatting changes to second line (where logical selection ends), not just first line (where visible selection ends)

2013-11-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=50419

James Forrester jforres...@wikimedia.org changed:

   What|Removed |Added

   Priority|Unprioritized   |Low
 Status|NEW |ASSIGNED
 CC||da...@sheetmusic.org.uk,
   ||i...@wikia-inc.com,
   ||or...@framezero.com
  Component|General |ContentEditable
   Assignee|jforres...@wikimedia.org|da...@sheetmusic.org.uk
Summary|Turning line into header|VisualEditor: Selection
   |affects next line   |over a line (with
   ||shift-down) applies
   ||formatting changes to
   ||second line (where logical
   ||selection ends), not just
   ||first line (where visible
   ||selection ends)

--- Comment #2 from James Forrester jforres...@wikimedia.org ---
This is the same behaviour as in other rich editors.

By selecting in the manner you've stated (Cursor at beginning of line,
Shift-CursorDown) you've selected the current text, the current line, AND the
newline into the place before the first character.

If you mark the text as bold (which is character-level) the boldness becomes a
pre-annotation on the second line before the first character (so typing
anything at that point will become bold).

However, changing the format (rather than styling) of some text applies to the
entire paragraph (because that's how HTML works) – i.e., the entire second line
gets this applied.

We could theoretically apply different behaviour for styling and formatting, so
we apply over a newline for the first but not the second, but that might be
more unexpected?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l