[Bug 50756] Removing some whitespace is not detected as a change in some circumstances (selser issue?)
https://bugzilla.wikimedia.org/show_bug.cgi?id=50756 Arlo Breault changed: What|Removed |Added Status|ASSIGNED|RESOLVED CC||abrea...@wikimedia.org Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 50756] Removing some whitespace is not detected as a change in some circumstances (selser issue?)
https://bugzilla.wikimedia.org/show_bug.cgi?id=50756 --- Comment #7 from ssas...@wikimedia.org --- This proved to be a great bug to fix a whole bunch of related things in Parsoid. It led to about 10-15 patches indirectly. The final patch that fixes the bug (with full history) is: https://gerrit.wikimedia.org/r/#/c/97746/ (patch before Parsoid repo split) https://gerrit.wikimedia.org/r/#/c/102012/ (latest version after migration into new repo) This should get merged soon, but the code will not get deployed until January since we are now entering holiday code freeze time now. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 50756] Removing some whitespace is not detected as a change in some circumstances (selser issue?)
https://bugzilla.wikimedia.org/show_bug.cgi?id=50756 --- Comment #6 from ssas...@wikimedia.org --- After some more digging and playing around in VE, I was able to reproduce it with the following snippet: "'''foo''' bar\n\n" With this example, I can indeed reproduce this on the command line. Investigating. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 50756] Removing some whitespace is not detected as a change in some circumstances (selser issue?)
https://bugzilla.wikimedia.org/show_bug.cgi?id=50756 --- Comment #5 from Joe Decker --- As the person who pointed Oliver at this example originally, I went back to the version I'd had trouble with, and verified that the problem does not seem to be occurring now. You can see my test attempt with this diff: https://en.wikipedia.org/w/index.php?title=Michael_Lowry_%28actor%29&diff=583277441&oldid=542893928 In summary: I haven't done any wider testing, but at least the example that caused me to report this appears resolved. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 50756] Removing some whitespace is not detected as a change in some circumstances (selser issue?)
https://bugzilla.wikimedia.org/show_bug.cgi?id=50756 --- Comment #4 from ssas...@wikimedia.org --- This seems to be working on latest master (see below). I'll test this against VE in my local mediawiki after installing the cite extension and report back later today. -- [subbu@earth lib] echo "foo bar\n\n" > /tmp/wt [subbu@earth lib] node parse --fetchConfig false --extensions ref,references < /tmp/wt > /tmp/old.html [subbu@earth lib] sed 's/foo /tmp/new.html [subbu@earth lib] node parse --selser --oldhtmlfile /tmp/old.html --oldtextfile /tmp/wt < /tmp/new.html foobar -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 50756] Removing some whitespace is not detected as a change in some circumstances (selser issue?)
https://bugzilla.wikimedia.org/show_bug.cgi?id=50756 James Forrester changed: What|Removed |Added Priority|Unprioritized |High Status|NEW |ASSIGNED CC||ssas...@wikimedia.org Component|General |serializer Assignee|jforres...@wikimedia.org|gwi...@wikimedia.org Product|VisualEditor|Parsoid Summary|VisualEditor: removing |Removing some whitespace is |spaces not registering as a |not detected as a change in |change - or /working/ |some circumstances (selser ||issue?) --- Comment #3 from James Forrester --- Can confirm that the HTML going from VE to Parsoid doesn't include the whitespace - it's being re-inserted by Parsoid for some reason, possibly due to a selser bug? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
