[Bug 51954] empty attribute should be discarded
https://bugzilla.wikimedia.org/show_bug.cgi?id=51954 --- Comment #7 from ssas...@wikimedia.org --- So, Parsoid treats HTML and extension attributes slightly differently. See snippets below: [subbu@earth lib] echo "Aa Bb Cc Dd" | node parse --wt2wt Aa Bb Cc Dd [subbu@earth lib] echo "abcd" | node parse --wt2wt abcd For extensions, it drops empty attributes (in whatever form they show up), and for HTML tags, it normalizes empty attributes. Our HTML attribute behavior conforms with what browsers do. Anything to change / fix here for extensions? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 51954] empty attribute should be discarded
https://bugzilla.wikimedia.org/show_bug.cgi?id=51954 Gabriel Wicke changed: What|Removed |Added Status|NEW |UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 51954] empty attribute should be discarded
https://bugzilla.wikimedia.org/show_bug.cgi?id=51954 --- Comment #6 from Gabriel Wicke --- This is what a modern browser (HTML5 parsing spec) does: document.body.innerHTML = 'foo'; "foo" document.body.innerHTML "foo" We do the same in parsoid as we are also using the HTML5 parsing algorithm. So I think bug 52330 is really the issue here. We should already be round-tripping any kind of attribute perfectly in untouched content. The normalization to bgcolor="" should only happen when something nearby was edited. Can you verify using the visual editor? PS: When trying http://parsoid.wmflabs.org/_rtselser/dewiki/Selbstbildnis_%28Leonardo_da_Vinci%29 I noticed that there is a diff in ref tags which should not be there. This is reported in bug 60120. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 51954] empty attribute should be discarded
https://bugzilla.wikimedia.org/show_bug.cgi?id=51954 --- Comment #5 from Chris McKenna --- Yes. As noted at bug 52330 "bgcolor" generates the html "bgcolor="bgcolor" " which renders (at least in Firefox) the same as "bgcolor="#b0" " rather than the expected "#f9f9f9" that is the default for tables of class "wikitable" -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 51954] empty attribute should be discarded
https://bugzilla.wikimedia.org/show_bug.cgi?id=51954 --- Comment #4 from Gabriel Wicke --- I guess that bgcolor="" and bgcolor= should round-trip to bgcolor="" rather than just 'bgcolor'. Stripping the attribute completely does not seem to be a good solution in general. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 51954] empty attribute should be discarded
https://bugzilla.wikimedia.org/show_bug.cgi?id=51954 Gabriel Wicke changed: What|Removed |Added Priority|Unprioritized |Normal -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 51954] empty attribute should be discarded
https://bugzilla.wikimedia.org/show_bug.cgi?id=51954 --- Comment #3 from Chris McKenna --- I've reported that parsing error as bug 52330 in the mediawiki parsing component as the example table in my sandbox was generated in the source editor and so had no involvement from parsoid aiui. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 51954] empty attribute should be discarded
https://bugzilla.wikimedia.org/show_bug.cgi?id=51954 Chris McKenna changed: What|Removed |Added CC||cmcke...@sucs.org Severity|trivial |normal --- Comment #2 from Chris McKenna --- bgcolor="" should either be left alone or should be deleted, as bgcolor In a table, bgcolor="" produces no background color but bgcolor produces a dark red background because it produces the html (is this a bug in the default parser?) See https://en.wikipedia.org/w/index.php?title=User:Thryduulf/sandbox&oldid=566470353#Table This causes problems on the live wiki, see https://en.wikipedia.org/w/index.php?title=Kyle_Busch&diff=566076453&oldid=566076367 (the relevant change is the lines before the Line 709 diff block). Accordingly I've upgraded the severity from "trivial" to "normal". -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 51954] empty attribute should be discarded
https://bugzilla.wikimedia.org/show_bug.cgi?id=51954 --- Comment #1 from John Mark Vandenberg --- http://parsoid.wmflabs.org/_rt/de/Iraklis_Thessaloniki bgcolor= becomes bgcolor (which _might_ mean another edit causes the 'bgcolor'-> 'bgcolor=""' in the next parse) -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
