[Bug 52182] VisualEditor: On "applying changes" in a reference dialog, if the contents are blank, just delete the reference

2014-07-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52182

James Forrester  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED
   Target Milestone|--- |VE-deploy-2014-06-05

--- Comment #7 from James Forrester  ---
Yes, sorry, this was great. Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52182] VisualEditor: On "applying changes" in a reference dialog, if the contents are blank, just delete the reference

2014-07-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52182

--- Comment #6 from Alex Monk  ---
Ping. Anyone want to answer my question?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52182] VisualEditor: On "applying changes" in a reference dialog, if the contents are blank, just delete the reference

2014-06-03 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52182

--- Comment #5 from Alex Monk  ---
So Gerrit change 136496 fixed the existing intended behaviour, but didn't go as
far as this bug suggests (it just disables the apply button rather than
deleting the reference) - should it be changed to delete the reference still?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52182] VisualEditor: On "applying changes" in a reference dialog, if the contents are blank, just delete the reference

2014-05-30 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52182

Alex Monk  changed:

   What|Removed |Added

 CC||ryasm...@wikimedia.org

--- Comment #4 from Alex Monk  ---
*** Bug 62399 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52182] VisualEditor: On "applying changes" in a reference dialog, if the contents are blank, just delete the reference

2014-05-30 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52182

--- Comment #3 from Alex Monk  ---
See Gerrit change 81438 and Gerrit change 88618

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52182] VisualEditor: On "applying changes" in a reference dialog, if the contents are blank, just delete the reference

2014-05-30 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52182

--- Comment #2 from James Forrester  ---
length < 4 is a hack and we probably shouldn't be using it…

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52182] VisualEditor: On "applying changes" in a reference dialog, if the contents are blank, just delete the reference

2014-05-30 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52182

--- Comment #1 from Alex Monk  ---
According to ve.ui.MWReferenceDialog.prototype.onDocumentTransact, this apply
button is supposed to be disabled when the length is less than 4. But when I
empty the box, the length is 10 so nothing is done.

Anyway, I think we should either:
* Fix that bug (if it is one) and mark this bug as invalid (or repurposed for
fixing it), or
* Replace that with this idea

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52182] VisualEditor: On "applying changes" in a reference dialog, if the contents are blank, just delete the reference

2014-05-30 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52182

James Forrester  changed:

   What|Removed |Added

   Assignee|jforrester+veteambztickets@ |kren...@wikimedia.org
   |wikimedia.org   |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52182] VisualEditor: On "applying changes" in a reference dialog, if the contents are blank, just delete the reference

2014-02-28 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52182

James Forrester  changed:

   What|Removed |Added

   Assignee|rm...@wikimedia.org |jforrester+veteambztickets@
   ||wikimedia.org

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52182] VisualEditor: On "applying changes" in a reference dialog, if the contents are blank, just delete the reference

2013-11-25 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52182

James Forrester  changed:

   What|Removed |Added

   Priority|Unprioritized   |Normal
 Status|NEW |ASSIGNED
Summary|Removing content in ref |VisualEditor: On "applying
   |should remove reference |changes" in a reference
   ||dialog, if the contents are
   ||blank, just delete the
   ||reference

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l