https://bugzilla.wikimedia.org/show_bug.cgi?id=53477
--- Comment #12 from Andrew Green andrew.green...@gmail.com ---
Added a comment on the Gerrit change. tl;dr: Is $wgContentNamespaces getting
checked? I don't see how EP_NS could be there, and checking it in js seems to
fix the issue. Thanks!
https://bugzilla.wikimedia.org/show_bug.cgi?id=53477
--- Comment #13 from Andrew Green andrew.green...@gmail.com ---
P.S. Go to a production wiki and try this in a js console:
mw.config.get('wgContentNamespaces')
The results coincide:
https://bugzilla.wikimedia.org/show_bug.cgi?id=53477
James Forrester jforres...@wikimedia.org changed:
What|Removed |Added
Status|PATCH_TO_REVIEW |RESOLVED
https://bugzilla.wikimedia.org/show_bug.cgi?id=53477
--- Comment #11 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 125233 merged by jenkins-bot:
Don't change tabs on Education Program pages
https://gerrit.wikimedia.org/r/125233
--
You are receiving this mail because:
You
https://bugzilla.wikimedia.org/show_bug.cgi?id=53477
--- Comment #7 from Krinkle krinklem...@gmail.com ---
From a quick investigation it looks like there are about a dozen different ways
in which VisualEditor can reasonably find out that the page is not a real
wikipage.
Not one of them is being
https://bugzilla.wikimedia.org/show_bug.cgi?id=53477
--- Comment #8 from Alex Monk kren...@gmail.com ---
(In reply to Krinkle from comment #7)
I'd say EP should either let us know how to generically detect it without
being EP specific, or it should implement support to at least do one thing
https://bugzilla.wikimedia.org/show_bug.cgi?id=53477
--- Comment #9 from Andrew Green andrew.green...@gmail.com ---
I can look into making the EP extension warn VE through some generic mechanism.
The bug is moderately important for users of the extension, and I imagine
there's some way to do this
https://bugzilla.wikimedia.org/show_bug.cgi?id=53477
--- Comment #10 from James Forrester jforres...@wikimedia.org ---
(In reply to Andrew Green from comment #9)
I can look into making the EP extension warn VE through some generic
mechanism.
Ideally EP would warn VE through the existing
https://bugzilla.wikimedia.org/show_bug.cgi?id=53477
--- Comment #6 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 125233 had a related patch set uploaded by Alex Monk:
Only make tab changes on articles
https://gerrit.wikimedia.org/r/125233
--
You are receiving this mail
https://bugzilla.wikimedia.org/show_bug.cgi?id=53477
Gerrit Notification Bot gerritad...@wikimedia.org changed:
What|Removed |Added
Status|ASSIGNED
https://bugzilla.wikimedia.org/show_bug.cgi?id=53477
Anna Koval ako...@wikimedia.org changed:
What|Removed |Added
CC||ako...@wikimedia.org
https://bugzilla.wikimedia.org/show_bug.cgi?id=53477
James Forrester jforres...@wikimedia.org changed:
What|Removed |Added
Assignee|jforrester+veteambztickets@
https://bugzilla.wikimedia.org/show_bug.cgi?id=53477
--- Comment #5 from Alex Monk kren...@gmail.com ---
I think VE shouldn't be modifying tabs on pages which aren't articles (check
wgIsArticle is true before doing anything).
--
You are receiving this mail because:
You are on the CC list for
https://bugzilla.wikimedia.org/show_bug.cgi?id=53477
James Forrester jforres...@wikimedia.org changed:
What|Removed |Added
Assignee|krinklem...@gmail.com
https://bugzilla.wikimedia.org/show_bug.cgi?id=53477
James Forrester jforres...@wikimedia.org changed:
What|Removed |Added
Priority|Normal |High
15 matches
Mail list logo
