[Bug 53820] PHP Fatal error: Call to a member function parseParamString() on a non-object in SpecialUploadStash.php on line 137
https://bugzilla.wikimedia.org/show_bug.cgi?id=53820 Gilles Dubuc gdu...@wikimedia.org changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |WORKSFORME --- Comment #10 from Gilles Dubuc gdu...@wikimedia.org --- No trace of the exception in the last 30 days on logstash nor in the fluorine archives, which go as far back as mid-March. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53820] PHP Fatal error: Call to a member function parseParamString() on a non-object in SpecialUploadStash.php on line 137
https://bugzilla.wikimedia.org/show_bug.cgi?id=53820 Gilles Dubuc gdu...@wikimedia.org changed: What|Removed |Added CC||gdu...@wikimedia.org Assignee|bda...@wikimedia.org|gdu...@wikimedia.org -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53820] PHP Fatal error: Call to a member function parseParamString() on a non-object in SpecialUploadStash.php on line 137
https://bugzilla.wikimedia.org/show_bug.cgi?id=53820 Tisza Gergő gti...@wikimedia.org changed: What|Removed |Added CC||gti...@wikimedia.org --- Comment #9 from Tisza Gergő gti...@wikimedia.org --- Shouldn't you just not return any params if there is no handler? Not all file types have a handler, this should not be an error condition. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53820] PHP Fatal error: Call to a member function parseParamString() on a non-object in SpecialUploadStash.php on line 137
https://bugzilla.wikimedia.org/show_bug.cgi?id=53820 Mark Holmquist mtrac...@member.fsf.org changed: What|Removed |Added Status|PATCH_TO_REVIEW |ASSIGNED Assignee|wikibugs-l@lists.wikimedia. |bda...@wikimedia.org |org | --- Comment #7 from Mark Holmquist mtrac...@member.fsf.org --- Bryan's patch makes this easier to debug, but it's not fixed. Assigning. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53820] PHP Fatal error: Call to a member function parseParamString() on a non-object in SpecialUploadStash.php on line 137
https://bugzilla.wikimedia.org/show_bug.cgi?id=53820 --- Comment #8 from Bryan Davis bda...@wikimedia.org --- The patch fixes the php fatal error, but not whatever underlying problem caused it. The patch will raise an exception with a hopefully informative message if this error path is encountered again. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53820] PHP Fatal error: Call to a member function parseParamString() on a non-object in SpecialUploadStash.php on line 137
https://bugzilla.wikimedia.org/show_bug.cgi?id=53820 --- Comment #6 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 83010 merged by jenkins-bot: Guard against non-object returns from File::getHander() https://gerrit.wikimedia.org/r/83010 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53820] PHP Fatal error: Call to a member function parseParamString() on a non-object in SpecialUploadStash.php on line 137
https://bugzilla.wikimedia.org/show_bug.cgi?id=53820 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Priority|Unprioritized |High -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53820] PHP Fatal error: Call to a member function parseParamString() on a non-object in SpecialUploadStash.php on line 137
https://bugzilla.wikimedia.org/show_bug.cgi?id=53820 --- Comment #2 from Bryan Davis bda...@wikimedia.org --- File::getHandler() should probably check the return value of MediaHandler::getHandler() and raise an MWException when it === false. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53820] PHP Fatal error: Call to a member function parseParamString() on a non-object in SpecialUploadStash.php on line 137
https://bugzilla.wikimedia.org/show_bug.cgi?id=53820 --- Comment #3 from Bawolff (Brian Wolff) bawolff...@gmail.com --- Interesting. The file has extension jpg. Stashed files should get their ext from detected mime type, which means mime type should def be image/jpeg, which is a built in handler and should always be found. (Otoh maybe my memory of how upload stash works is wrong. In any case code should never assume that all files have a handler) -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53820] PHP Fatal error: Call to a member function parseParamString() on a non-object in SpecialUploadStash.php on line 137
https://bugzilla.wikimedia.org/show_bug.cgi?id=53820 --- Comment #5 from Bryan Davis bda...@wikimedia.org --- UploadStash::getFile() returns an UnregisteredLocalFile subclass which in turn derives mime type via MimeMagic::guessMimeType(). Looking there you can see that the first guess is made via magic header checks with a fallback to extension based guessing as Bawolff remembered. There's a loophole in that fallback though that my money is on for this bug. MimeMagic::doGuessMimeType() will return 'unknown/unknown' if the file can't be opened for reading. Based on some of the other bugs I've been chasing this week, my guess is that the stashed file is actually missing from disk. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53820] PHP Fatal error: Call to a member function parseParamString() on a non-object in SpecialUploadStash.php on line 137
https://bugzilla.wikimedia.org/show_bug.cgi?id=53820 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53820] PHP Fatal error: Call to a member function parseParamString() on a non-object in SpecialUploadStash.php on line 137
https://bugzilla.wikimedia.org/show_bug.cgi?id=53820 --- Comment #4 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 83010 had a related patch set uploaded by BryanDavis: Assert that $this-handler is not false. https://gerrit.wikimedia.org/r/83010 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53820] PHP Fatal error: Call to a member function parseParamString() on a non-object in SpecialUploadStash.php on line 137
https://bugzilla.wikimedia.org/show_bug.cgi?id=53820 Bryan Davis bda...@wikimedia.org changed: What|Removed |Added CC||bda...@wikimedia.org --- Comment #1 from Bryan Davis bda...@wikimedia.org --- It looks like $handler could be boolean false via MediaHandler::getHandler() if $wgMediaHandlers[$type] is not found. $handler is derived via a long chain of object lookups/calls: RepoGroup::singleton()-getLocalRepo()-getUploadStash()-getFile()-getHandler() I would expect to see a wfDebug() of MediaHandler::getHandler: no handler found for X just before this crash. X would be the mime type that MimeMagic::singleton()-guessMimeType() is returning for the local file. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
