[Bug 54197] Archiving of feedback broken on enwiki

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=54197

Andre Klapper  changed:

   What|Removed |Added

   Priority|Normal  |Lowest

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 54197] Archiving of feedback broken on enwiki

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=54197

Andre Klapper  changed:

   What|Removed |Added

   Priority|High|Normal

--- Comment #7 from Andre Klapper  ---
[Lowering priority to reflect reality, as AFTv5 is not very actively being
worked on anymore.]

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 54197] Archiving of feedback broken on enwiki

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=54197

Matthias Mullie  changed:

   What|Removed |Added

   Assignee|mmul...@wikimedia.org   |wikibugs-l@lists.wikimedia.
   ||org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 54197] Archiving of feedback broken on enwiki

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=54197

--- Comment #6 from Nemo  ---
(In reply to comment #5)
> (In reply to comment #4)
> > Fabrice or Matthias: is anyone actively working on this issue? If not, it 
> > may
> > make sense to disable AFTv5 on Wikimedia wikis if it can't be actively
> > maintained.
> 
> Seconded. If I'm not mistaken, there is no longer any "Archive" filter
> anywhere: it seems ArticleFeedbackv5AutoArchiveEnabled controls both past and
> future archival, so that setting it false actually de-archived humongous
> masses
> of unreviewed feedback, with all the vandalism they include.

After two more months of useless waiting, this is now finally proceeding:
https://gerrit.wikimedia.org/r/#/c/112639/ , bug 61163.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 54197] Archiving of feedback broken on enwiki

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=54197

User:Docu  changed:

   What|Removed |Added

 Blocks||61089

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 54197] Archiving of feedback broken on enwiki

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=54197

Nemo  changed:

   What|Removed |Added

 Blocks||43421

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 54197] Archiving of feedback broken on enwiki

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=54197

--- Comment #5 from Nemo  ---
(In reply to comment #4)
> Fabrice or Matthias: is anyone actively working on this issue? If not, it may
> make sense to disable AFTv5 on Wikimedia wikis if it can't be actively
> maintained.

Seconded. If I'm not mistaken, there is no longer any "Archive" filter
anywhere: it seems ArticleFeedbackv5AutoArchiveEnabled controls both past and
future archival, so that setting it false actually de-archived humongous masses
of unreviewed feedback, with all the vandalism they include.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 54197] Archiving of feedback broken on enwiki

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=54197

MZMcBride  changed:

   What|Removed |Added

 CC||fflo...@wikimedia.org

--- Comment #4 from MZMcBride  ---
Fabrice or Matthias: is anyone actively working on this issue? If not, it may
make sense to disable AFTv5 on Wikimedia wikis if it can't be actively
maintained.

For reference:
.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 54197] Archiving of feedback broken on enwiki

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=54197

Matthias Mullie  changed:

   What|Removed |Added

   Assignee|wikibugs-l@lists.wikimedia. |mmul...@wikimedia.org
   |org |

--- Comment #3 from Matthias Mullie  ---
Brain dump:

Looking at e.g. feedback #755805
(https://en.wikipedia.org/wiki/Special:ArticleFeedbackv5/Cloud_computing/755805),
this feedback entry is actually archived. DB data confirms: aft_archive = 1.

Only the maintenance script, which has since been killed, can mark feedback as
archived. Activity log confirms the last action was performed by Article
Feedback v5.

Where-condition, executed against slave, is: array( 'aft_archive = 0',
"aft_archive_date <= '$now'" ). This means that this post should no longer
appear when queried for "posts to be archived".

I'd say that perhaps slave is/was lagging, but the wait is right there in the
code, and I'll assume it works:
wfWaitForSlaves( false, false, $wgArticleFeedbackv5Cluster );
Also, the script had been going at it for 10+ minutes (another feedback entry
for even way longer) until it was killed, so that lag would have to have been
pretty bad. This is a highly unlikely cause.

It looks like the archiving kicked in right after a person manually un-archived
the feedback.
*ERROR #1*: archive date should be re-calculated after a person un-archives
feedback (or nulled completely), not be the original archive date (which
results in immediate re-archive).

(probably unrelated) *ERROR #2*: maintenance script nulls aft_archive_date, but
the subsequent update() call will fill out that value again.

Have to run for now, will get these fixed and continue figuring out why exactly
archive broke.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 54197] Archiving of feedback broken on enwiki

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=54197

Nemo  changed:

   What|Removed |Added

 CC||federicol...@tiscali.it

--- Comment #2 from Nemo  ---
(In reply to comment #1)
> Log for anyone interested
> https://en.wikipedia.org/wiki/Special:Log/articlefeedbackv5

That is, the ~18k log entries starting from
https://en.wikipedia.org/w/index.php?title=Special:Log/articlefeedbackv5&offset=20130917002320&limit=2500&type=articlefeedbackv5&user=

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 54197] Archiving of feedback broken on enwiki

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=54197

Andre Klapper  changed:

   What|Removed |Added

   Priority|Unprioritized   |High

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 54197] Archiving of feedback broken on enwiki

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=54197

--- Comment #1 from Sam Reed (reedy)  ---
Log for anyone interested
https://en.wikipedia.org/wiki/Special:Log/articlefeedbackv5

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l