[Bug 54885] MobileFrontend doesn't remember user choice (mobile/desktop) in some use cases
https://bugzilla.wikimedia.org/show_bug.cgi?id=54885 Jon jrob...@wikimedia.org changed: What|Removed |Added Status|NEW |UNCONFIRMED Ever confirmed|1 |0 --- Comment #26 from Jon jrob...@wikimedia.org --- Marking as unconfirmed until we hear back from Kelson. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54885] MobileFrontend doesn't remember user choice (mobile/desktop) in some use cases
https://bugzilla.wikimedia.org/show_bug.cgi?id=54885 --- Comment #24 from Kelson [Emmanuel Engelhart] kel...@kiwix.org --- @Sam Thank you for trying to push this bug/patch. I have explained in https://bugzilla.wikimedia.org/show_bug.cgi?id=54885#c8 why I had to create this new configuration value. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54885] MobileFrontend doesn't remember user choice (mobile/desktop) in some use cases
https://bugzilla.wikimedia.org/show_bug.cgi?id=54885 --- Comment #25 from Sam Smith samsm...@wikimedia.org --- No problem Kelson. MobileContext#getStopMobileRedirectCookieDomain returns wgMFStopRedirectCookieHost when it's defined. So why not set wgMFStopRedirectCookieHost to '.wikimedia.org.uk', rather than create another mechanism for setting the cookie domain? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54885] MobileFrontend doesn't remember user choice (mobile/desktop) in some use cases
https://bugzilla.wikimedia.org/show_bug.cgi?id=54885 Sam Smith samsm...@wikimedia.org changed: What|Removed |Added CC||samsm...@wikimedia.org --- Comment #21 from Sam Smith samsm...@wikimedia.org --- (In reply to Derk-Jan Hartman from comment #17) also, when on https, the stopMobileRedirect cookie is set with the 'secure' flag on. That means it won't be visible if the user enters from an http:// url from google for instance... Is this intentional ? This was fixed as part of bug 68347. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54885] MobileFrontend doesn't remember user choice (mobile/desktop) in some use cases
https://bugzilla.wikimedia.org/show_bug.cgi?id=54885 --- Comment #22 from Sam Smith samsm...@wikimedia.org --- Kelson, This bug has been added to the Mobile Web team's current sprint (see https://trello.com/c/gtF11D1B) and I'm taking a look. I've read through the patch that Jon submitted on your behalf and it looks okay. However, I'm wondering what you had/have the wgMFStopMobileRedirect configuration variable set to. I ask because that variable seems to be used to override MobileContext#getBaseDomain in #getStopMobileRedirectCookieDomain. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54885] MobileFrontend doesn't remember user choice (mobile/desktop) in some use cases
https://bugzilla.wikimedia.org/show_bug.cgi?id=54885 --- Comment #23 from Sam Smith samsm...@wikimedia.org --- Sorry, wgMFStopRedirectCookieHost. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54885] MobileFrontend doesn't remember user choice (mobile/desktop) in some use cases
https://bugzilla.wikimedia.org/show_bug.cgi?id=54885 Jon jrob...@wikimedia.org changed: What|Removed |Added Status|PATCH_TO_REVIEW |NEW --- Comment #18 from Jon jrob...@wikimedia.org --- What is the status of this bug now? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54885] MobileFrontend doesn't remember user choice (mobile/desktop) in some use cases
https://bugzilla.wikimedia.org/show_bug.cgi?id=54885 --- Comment #19 from Bingle bingle-ad...@wikimedia.org --- Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/gtF11D1B -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54885] MobileFrontend doesn't remember user choice (mobile/desktop) in some use cases
https://bugzilla.wikimedia.org/show_bug.cgi?id=54885 --- Comment #20 from Kelson [Emmanuel Engelhart] kel...@kiwix.org --- Thank you Jon for your patience. I just failed to give enough time to provide a correct patch here (I'm not so familiar with the whole testing infrastructure). It works for the WMUK instance and this is the most important to me. But it still on my TODO list... or someone else will do the patch as the bug/patch relatively trivial is. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54885] MobileFrontend doesn't remember user choice (mobile/desktop) in some use cases
https://bugzilla.wikimedia.org/show_bug.cgi?id=54885 Derk-Jan Hartman hartman.w...@gmail.com changed: What|Removed |Added CC||hartman.w...@gmail.com --- Comment #17 from Derk-Jan Hartman hartman.w...@gmail.com --- also, when on https, the stopMobileRedirect cookie is set with the 'secure' flag on. That means it won't be visible if the user enters from an http:// url from google for instance... Is this intentional ? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54885] MobileFrontend doesn't remember user choice (mobile/desktop) in some use cases
https://bugzilla.wikimedia.org/show_bug.cgi?id=54885 --- Comment #16 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 117699 abandoned by Jdlrobson: Remember user choice (mobile/desktop) Reason: Abandoning to clear the code review queue due to lack of activity. Please re-submit it when you have the time. Thanks! https://gerrit.wikimedia.org/r/117699 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54885] MobileFrontend doesn't remember user choice (mobile/desktop) in some use cases
https://bugzilla.wikimedia.org/show_bug.cgi?id=54885 --- Comment #15 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 117699 had a related patch set uploaded by Jdlrobson: Remember user choice (mobile/desktop) https://gerrit.wikimedia.org/r/117699 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54885] MobileFrontend doesn't remember user choice (mobile/desktop) in some use cases
https://bugzilla.wikimedia.org/show_bug.cgi?id=54885 Kelson [Emmanuel Engelhart] kel...@kiwix.org changed: What|Removed |Added Status|REOPENED|PATCH_TO_REVIEW --- Comment #13 from Kelson [Emmanuel Engelhart] kel...@kiwix.org --- Hmmm, it seems I have failed to attach the commit to the bug :( https://integration.wikimedia.org/ci/job/mwext-MobileFrontend-lint/8982/console -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54885] MobileFrontend doesn't remember user choice (mobile/desktop) in some use cases
https://bugzilla.wikimedia.org/show_bug.cgi?id=54885 --- Comment #14 from Kelson [Emmanuel Engelhart] kel...@kiwix.org --- https://gerrit.wikimedia.org/r/#/c/117699/ -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54885] MobileFrontend doesn't remember user choice (mobile/desktop) in some use cases
https://bugzilla.wikimedia.org/show_bug.cgi?id=54885 --- Comment #11 from Andre Klapper aklap...@wikimedia.org --- If the patch was added as an attachment here one could use Valhallsw's script to upload it via http://tools.wmflabs.org/gerrit-patch-uploader/ ... -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54885] MobileFrontend doesn't remember user choice (mobile/desktop) in some use cases
https://bugzilla.wikimedia.org/show_bug.cgi?id=54885 --- Comment #12 from Kelson [Emmanuel Engelhart] kel...@kiwix.org --- Will do it, I don't have forgotten... -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54885] MobileFrontend doesn't remember user choice (mobile/desktop) in some use cases
https://bugzilla.wikimedia.org/show_bug.cgi?id=54885 --- Comment #10 from Arthur Richards aricha...@wikimedia.org --- Kelson, just wanted to poke again - can you please submit your patch to gerrit? It will be easier to review, test, and make comments on it there. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54885] MobileFrontend doesn't remember user choice (mobile/desktop) in some use cases
https://bugzilla.wikimedia.org/show_bug.cgi?id=54885 MZMcBride b...@mzmcbride.com changed: What|Removed |Added CC||b...@mzmcbride.com Summary|MobileFrontend doesn't |MobileFrontend doesn't |remember user choice|remember user choice |(mobil/desktop) in some use |(mobile/desktop) in some |cases |use cases -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
