[Bug 55473] [REGRESSION] i18n fallback uses message from i18n file before message from db.
https://bugzilla.wikimedia.org/show_bug.cgi?id=55473 --- Comment #12 from Rainer Rillke @commons.wikimedia rainerril...@hotmail.com --- (In reply to comment #11) That's only temporary, doing everything at once was too much. And breaking existing things? No, then you can surely make use of branches. Anyway, independently from what is being implemented, I would be glad having a link to a documentation page for that behaviour here so I can check existing messages at Commons. Thank you. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55473] [REGRESSION] i18n fallback uses message from i18n file before message from db.
https://bugzilla.wikimedia.org/show_bug.cgi?id=55473
--- Comment #7 from Tisza Gergő gti...@wikimedia.org ---
MediaWiki:Licenses is a special message that only exists in the English
messages file, with a '-' value. Before 86b54375de7e, MessageCache::get() had
special handling for messages whose value was exactly '-', so the lookup went
like this:
* check DB for current lang (miss)
* check CDB ('-')
* special handling for '-': check DB for default lang (returns the english
license list)
Since 86b54375de7e, lookup goes like this:
* check DB for current lang (miss)
* check CDB ('-')
* use '-' as the license list (lines not starting with '*' are ignored, so this
is the same as an empty list)
The root problem is that DB lookups return the current language or null, while
CDB lookups include fallbacks, so a CDB fallback will take precedence over a DB
fallback which is at the same or higher position in the fallback chain. This
causes a lot of other problems apart from this bug, and a patch is already
pending: https://gerrit.wikimedia.org/r/#/c/72867/
Once that gets merged, the lookup will look like this:
* check DB for current lang (miss)
* check CDB for current lang (miss)
* walk back fallback chain, check first DB then CDB for each (eventually gets
English license list or a localization)
which fixes this bug and is actually an improvement over the old (which
returned English and not German license list for 'de-at').
It seems that that patch is stuck in review limbo, though.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55473] [REGRESSION] i18n fallback uses message from i18n file before message from db.
https://bugzilla.wikimedia.org/show_bug.cgi?id=55473 --- Comment #8 from Nemo federicol...@tiscali.it --- For clarity, the current plan is Niklas' option 1 as per bug 46579 comment 17. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55473] [REGRESSION] i18n fallback uses message from i18n file before message from db.
https://bugzilla.wikimedia.org/show_bug.cgi?id=55473 Nemo federicol...@tiscali.it changed: What|Removed |Added See Also||https://bugzilla.wikimedia. ||org/show_bug.cgi?id=1495 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55473] [REGRESSION] i18n fallback uses message from i18n file before message from db.
https://bugzilla.wikimedia.org/show_bug.cgi?id=55473 --- Comment #9 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 72867 had a related patch set uploaded by Parent5446: Complete usage of message fallback chain https://gerrit.wikimedia.org/r/72867 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55473] [REGRESSION] i18n fallback uses message from i18n file before message from db.
https://bugzilla.wikimedia.org/show_bug.cgi?id=55473 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55473] [REGRESSION] i18n fallback uses message from i18n file before message from db.
https://bugzilla.wikimedia.org/show_bug.cgi?id=55473 --- Comment #10 from Tisza Gergő gti...@wikimedia.org --- (In reply to comment #8) For clarity, the current plan is Niklas' option 1 as per bug 46579 comment 17. Is it? 86b54375de7e, which was merged half a year ago, takes a completely different direction. Anyway, if that option would be implemented, that would fix this bug as well, although then MediaWiki:Licenses should be moved to MediaWiki:Licenses/en. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55473] [REGRESSION] i18n fallback uses message from i18n file before message from db.
https://bugzilla.wikimedia.org/show_bug.cgi?id=55473 --- Comment #11 from Nemo federicol...@tiscali.it --- (In reply to comment #10) (In reply to comment #8) For clarity, the current plan is Niklas' option 1 as per bug 46579 comment 17. Is it? 86b54375de7e, which was merged half a year ago, takes a completely different direction. That's only temporary, doing everything at once was too much. Anyway, if that option would be implemented, [...] then MediaWiki:Licenses should be moved to MediaWiki:Licenses/en. Yep, it should. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55473] [REGRESSION] i18n fallback uses message from i18n file before message from db.
https://bugzilla.wikimedia.org/show_bug.cgi?id=55473 Fabrice Florin fflo...@wikimedia.org changed: What|Removed |Added Assignee|mtrac...@member.fsf.org |gti...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55473] [REGRESSION] i18n fallback uses message from i18n file before message from db.
https://bugzilla.wikimedia.org/show_bug.cgi?id=55473
Tisza Gergő gti...@gmail.com changed:
What|Removed |Added
CC||gti...@gmail.com
--- Comment #6 from Tisza Gergő gti...@gmail.com ---
Also affects languages which have no other fallback than English:
https://commons.wikimedia.org/wiki/Special:Upload?uselang=eo
and other wikis: https://en.wikipedia.org/wiki/Special:Upload?uselang=de
Other $wgForceUIMsgAsContentMsg messages do not do this:
https://commons.wikimedia.org/wiki/Special:ExpandTemplates?input={{int:contact-url}}uselang=de-at
--
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55473] [REGRESSION] i18n fallback uses message from i18n file before message from db.
https://bugzilla.wikimedia.org/show_bug.cgi?id=55473 Bawolff (Brian Wolff) bawolff...@gmail.com changed: What|Removed |Added Summary|[REGRESSION] License select |[REGRESSION] i18n fallback |fallback broken at Commons |uses message from i18n file ||before message from db. --- Comment #5 from Bawolff (Brian Wolff) bawolff...@gmail.com --- (In reply to comment #0) Since some months, the license text selector language fallback is broken at Commons: https://commons.wikimedia.org/wiki/Commons:Village_pump#Can_somebody_help. 3F_.22No_license_specified.22 https://commons.wikimedia.org/w/index.php?title=Commons: Village_pumpoldid=106628661#Can_somebody_help.3F_.22No_license_specified.22 It apparently worked before (but I am not sure): https://commons.wikimedia.org/w/index. php?title=Special%3ALogtype=user=page=MediaWiki%3ALicenses%2Fnnyear=mont h=-1tagfilter=hide_patrol_log=1 (message deleted because it was redundant to the English version) How to reproduce: Go to https://commons.wikimedia.org/wiki/Special:Upload?uselang=de-at and the Lizenz:-select only contains one entry. This is because [[MediaWiki:Licenses/de-at]] does not exist. I would, however, expect that in this case [[MediaWiki:Licenses/de]] is used. I imagine introduced in 86b54375de7e / attempts to fix bug 1495, as that was last major change to this code area. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
