https://bugzilla.wikimedia.org/show_bug.cgi?id=55535
Jon changed:
What|Removed |Added
Status|PATCH_TO_REVIEW |RESOLVED
Resolution|---
https://bugzilla.wikimedia.org/show_bug.cgi?id=55535
--- Comment #15 from Gerrit Notification Bot ---
Change 158632 merged by jenkins-bot:
Add mw-ui-icon
https://gerrit.wikimedia.org/r/158632
--
You are receiving this mail because:
You are on the CC list for the bug.
__
https://bugzilla.wikimedia.org/show_bug.cgi?id=55535
--- Comment #14 from Gerrit Notification Bot ---
Change 139368 abandoned by Phuedx:
[EXPERIMENT] Add icon mixins to mediawiki.ui
Reason:
Abandoning in favour of I68a1b207d8a4af57879361921a5f8c3aeda3fd9a.
https://gerrit.wikimedia.org/r/139368
https://bugzilla.wikimedia.org/show_bug.cgi?id=55535
--- Comment #13 from Gerrit Notification Bot ---
Change 158632 had a related patch set uploaded by Jdlrobson:
WIP: Add mw-ui-icon
https://gerrit.wikimedia.org/r/158632
--
You are receiving this mail because:
You are on the CC list for the bu
https://bugzilla.wikimedia.org/show_bug.cgi?id=55535
--- Comment #12 from Gerrit Notification Bot ---
Change 144141 abandoned by Phuedx:
Test .mw-ui-icon classes and mixins
Reason:
This change has been squashed into its parent so that it has a good working
example.
https://gerrit.wikimedia.org/
https://bugzilla.wikimedia.org/show_bug.cgi?id=55535
Matthew Flaschen changed:
What|Removed |Added
Assignee|wikibugs-l@lists.wikimedia. |samsm...@wikimedia.org
https://bugzilla.wikimedia.org/show_bug.cgi?id=55535
Tyler Romeo changed:
What|Removed |Added
CC||jrob...@wikimedia.org,
https://bugzilla.wikimedia.org/show_bug.cgi?id=55535
--- Comment #11 from Gerrit Notification Bot ---
Change 144141 had a related patch set uploaded by Phuedx:
Test the .mw-ui-button-with-icon-bgimage mixin
https://gerrit.wikimedia.org/r/144141
--
You are receiving this mail because:
You are t
https://bugzilla.wikimedia.org/show_bug.cgi?id=55535
--- Comment #10 from Gerrit Notification Bot ---
Change 139368 had a related patch set uploaded by Phuedx:
Add icon support to .mw-ui-button
https://gerrit.wikimedia.org/r/139368
--
You are receiving this mail because:
You are the assignee f
https://bugzilla.wikimedia.org/show_bug.cgi?id=55535
Gerrit Notification Bot changed:
What|Removed |Added
Status|NEW |PATCH_TO_REVIEW
--
You are
https://bugzilla.wikimedia.org/show_bug.cgi?id=55535
--- Comment #9 from Matthew Flaschen ---
Related: GettingStarted is also using mw-ui-primary, which is now deprecated,
for one of the icon buttons. As part of standardization, we should drop that
class.
--
You are receiving this mail because
https://bugzilla.wikimedia.org/show_bug.cgi?id=55535
--- Comment #8 from Jared Zimmerman (WMF) ---
Starting the catalog here. Thanks for posting these.
https://www.mediawiki.org/wiki/Wikimedia_Foundation_Design/Agora_Control_Library
--
You are receiving this mail because:
You are the assignee
https://bugzilla.wikimedia.org/show_bug.cgi?id=55535
--- Comment #7 from sp...@wikimedia.org ---
(In reply to comment #1)
> Created attachment 13463 [details]
> GettingStarted modal showing icon buttons
The Flow prototype's "Thanks" button and "Hide/Delete/Suppress" button group
also feature icon
https://bugzilla.wikimedia.org/show_bug.cgi?id=55535
Sam Reed (reedy) changed:
What|Removed |Added
Severity|normal |enhancement
--
You are receiving t
https://bugzilla.wikimedia.org/show_bug.cgi?id=55535
Andre Klapper changed:
What|Removed |Added
Priority|Unprioritized |Normal
--
You are receiving this mail
https://bugzilla.wikimedia.org/show_bug.cgi?id=55535
--- Comment #6 from Jared Zimmerman (WMF) ---
Sorry if i was unclear, just questioning whether the help text need to be IN
the button
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug
https://bugzilla.wikimedia.org/show_bug.cgi?id=55535
--- Comment #5 from Steven Walling ---
(In reply to comment #4)
> If this is the only place this is used I would ask the PM on the feature to
> decide if its absolutely required, as you mentioned its not used anywhere
> else.
> I can certainly
https://bugzilla.wikimedia.org/show_bug.cgi?id=55535
--- Comment #4 from Jared Zimmerman (WMF) ---
If this is the only place this is used I would ask the PM on the feature to
decide if its absolutely required, as you mentioned its not used anywhere else.
I can certainly see the need for a CTA but
https://bugzilla.wikimedia.org/show_bug.cgi?id=55535
--- Comment #3 from Matthew Flaschen ---
I think that's open to discussion. We should also make sure we actually want
this. I note it's not in the spec. I realize that spec isn't final, but we
should bear in mind everything we add has a cost
https://bugzilla.wikimedia.org/show_bug.cgi?id=55535
--- Comment #2 from Jared Zimmerman (WMF) ---
Thank you for the request. This is exactly how i'd hoped this process would
work.
It looks like in this instance its not only a button with an image, but a
button that allows multiple lines of diff
https://bugzilla.wikimedia.org/show_bug.cgi?id=55535
--- Comment #1 from Matthew Flaschen ---
Created attachment 13463
--> https://bugzilla.wikimedia.org/attachment.cgi?id=13463&action=edit
GettingStarted modal showing icon buttons
This shows an example modal from GettingStarted. This appeara
21 matches
Mail list logo
