https://bugzilla.wikimedia.org/show_bug.cgi?id=56363
--- Comment #16 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 161340 had a related patch set uploaded by Prtksxna:
SpecialChangeEmail: Use vform and remove wrapper
https://gerrit.wikimedia.org/r/161340
--
You are
https://bugzilla.wikimedia.org/show_bug.cgi?id=56363
--- Comment #15 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 161339 had a related patch set uploaded by Prtksxna:
SpecialChangeEmail: Remove cancel button
https://gerrit.wikimedia.org/r/161339
--
You are receiving this
https://bugzilla.wikimedia.org/show_bug.cgi?id=56363
--- Comment #17 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 161339 merged by jenkins-bot:
SpecialChangeEmail: Remove cancel button
https://gerrit.wikimedia.org/r/161339
--
You are receiving this mail because:
You are on
https://bugzilla.wikimedia.org/show_bug.cgi?id=56363
--- Comment #18 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 161340 merged by jenkins-bot:
SpecialChangeEmail: Use vform and remove wrapper
https://gerrit.wikimedia.org/r/161340
--
You are receiving this mail because:
https://bugzilla.wikimedia.org/show_bug.cgi?id=56363
Jon jrob...@wikimedia.org changed:
What|Removed |Added
Status|PATCH_TO_REVIEW |RESOLVED
https://bugzilla.wikimedia.org/show_bug.cgi?id=56363
--- Comment #19 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 121975 abandoned by Jdlrobson:
ChangeEmail special page rewritten to use vforms.
Reason:
Prateek just resolved the bug. Thanks for the help getting us there
https://bugzilla.wikimedia.org/show_bug.cgi?id=56363
Jon jrob...@wikimedia.org changed:
What|Removed |Added
Blocks||70913
--
You are
https://bugzilla.wikimedia.org/show_bug.cgi?id=56363
--- Comment #13 from Jared Zimmerman (WMF) jared.zimmer...@wikimedia.org ---
When I hit cancel I get the error Enter a valid email address which seems to
imply its doing form validation, on cancel, which is very odd.
--
You are receiving this
https://bugzilla.wikimedia.org/show_bug.cgi?id=56363
Matthew Flaschen mflasc...@wikimedia.org changed:
What|Removed |Added
See Also|
https://bugzilla.wikimedia.org/show_bug.cgi?id=56363
Matthew Flaschen mflasc...@wikimedia.org changed:
What|Removed |Added
See Also|
https://bugzilla.wikimedia.org/show_bug.cgi?id=56363
--- Comment #14 from Matthew Flaschen mflasc...@wikimedia.org ---
(In reply to Jared Zimmerman (WMF) from comment #13)
When I hit cancel I get the error Enter a valid email address which seems
to imply its doing form validation, on cancel,
https://bugzilla.wikimedia.org/show_bug.cgi?id=56363
--- Comment #10 from Jon jrob...@wikimedia.org ---
... or we could just remove the cancel button.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing
https://bugzilla.wikimedia.org/show_bug.cgi?id=56363
--- Comment #11 from Bartosz DziewoĆski matma@gmail.com ---
I like the It causes problems? Remove it! approach, we should do this more
often. I wonder which extensions cause the most trouble, maybe we should remove
them? :
--
You are
https://bugzilla.wikimedia.org/show_bug.cgi?id=56363
--- Comment #12 from Matthew Flaschen mflasc...@wikimedia.org ---
Even if we do remove it, I would still like to know what the error is.
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.wikimedia.org/show_bug.cgi?id=56363
--- Comment #9 from Matthew Flaschen mflasc...@wikimedia.org ---
I agree a cancel button is not really useful here, but in the meantime we
should not be showing errors for it.
--
You are receiving this mail because:
You are on the CC list for
https://bugzilla.wikimedia.org/show_bug.cgi?id=56363
--- Comment #8 from Matthew Flaschen mflasc...@wikimedia.org ---
(In reply to Jared Zimmerman (WMF) from comment #7)
Cancel just returns an error for me now anyway.
On what wiki? It works for me on production English Wikipedia as well as
https://bugzilla.wikimedia.org/show_bug.cgi?id=56363
--- Comment #4 from Jon jrob...@wikimedia.org ---
*** Bug 70426 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are on the CC list for the bug.
___
https://bugzilla.wikimedia.org/show_bug.cgi?id=56363
--- Comment #5 from Jon jrob...@wikimedia.org ---
Should we also remove the cancel button as part of this? It seems strange to
have a cancel button in this context.
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.wikimedia.org/show_bug.cgi?id=56363
Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com changed:
What|Removed |Added
CC|
https://bugzilla.wikimedia.org/show_bug.cgi?id=56363
--- Comment #7 from Jared Zimmerman (WMF) jared.zimmer...@wikimedia.org ---
Cancel just returns an error for me now anyway.
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.wikimedia.org/show_bug.cgi?id=56363
Jon jrob...@wikimedia.org changed:
What|Removed |Added
Summary|[[Special:ChangeEmail]] |VForm:
21 matches
Mail list logo