[Bug 56403] Use DOM append instead of z-index to position lightbox
https://bugzilla.wikimedia.org/show_bug.cgi?id=56403 Tisza Gergő gti...@wikimedia.org changed: What|Removed |Added See Also||https://bugzilla.wikimedia. ||org/show_bug.cgi?id=60405 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56403] Use DOM append instead of z-index to position lightbox
https://bugzilla.wikimedia.org/show_bug.cgi?id=56403 --- Comment #9 from Gilles Dubuc gdu...@wikimedia.org --- Yep, display: none is being applied already (could be taken a little bit further, though, by hiding all children except the mmv elements, currently it uses a whitelist). I think we can safely get rid of z-index. Any objections? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56403] Use DOM append instead of z-index to position lightbox
https://bugzilla.wikimedia.org/show_bug.cgi?id=56403 Gilles Dubuc gdu...@wikimedia.org changed: What|Removed |Added CC||gdu...@wikimedia.org --- Comment #3 from Gilles Dubuc gdu...@wikimedia.org --- What else is using z-index right now, that would prevent us from moving to append? Isn't it risky to bet on the fact that all other extensions will play nice and not use z-index? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56403] Use DOM append instead of z-index to position lightbox
https://bugzilla.wikimedia.org/show_bug.cgi?id=56403 --- Comment #4 from Mark Holmquist mtrac...@member.fsf.org --- The backdrop, wrapper, and maybe the file usage dialog(s) are all using various values for z-index. Apparently the buttons are, too. It shouldn' -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56403] Use DOM append instead of z-index to position lightbox
https://bugzilla.wikimedia.org/show_bug.cgi?id=56403 --- Comment #5 from Mark Holmquist mtrac...@member.fsf.org --- ...t be too hard to fix this, though, it's just a matter of making sure everything works well. Honestly we could probably display:none the rest of the DOM while the lightbox is open. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56403] Use DOM append instead of z-index to position lightbox
https://bugzilla.wikimedia.org/show_bug.cgi?id=56403 --- Comment #6 from Mark Holmquist mtrac...@member.fsf.org --- ...oh, we do already. We don't need z-index for that, then. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56403] Use DOM append instead of z-index to position lightbox
https://bugzilla.wikimedia.org/show_bug.cgi?id=56403 --- Comment #7 from Tisza Gergő gti...@wikimedia.org --- We are appending to the end of the body (maybe that was different when this bug was opened), but I see no good reason not to have a z-index as well. Any administrator on any wiki can put a z-index rule into MediaWiki:Common.css and cause us problems. Is there ever a valid reason to position something above the lightbox? (Notifications, maybe?) -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56403] Use DOM append instead of z-index to position lightbox
https://bugzilla.wikimedia.org/show_bug.cgi?id=56403 --- Comment #8 from Tisza Gergő gti...@wikimedia.org --- ...although display:none works as well. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56403] Use DOM append instead of z-index to position lightbox
https://bugzilla.wikimedia.org/show_bug.cgi?id=56403 --- Comment #2 from Mark Holmquist mtrac...@member.fsf.org --- I guess the idea here is that we should *all* be using the append-to-DOM method as opposed to the z-index method, because the z-index method is DUMB. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56403] Use DOM append instead of z-index to position lightbox
https://bugzilla.wikimedia.org/show_bug.cgi?id=56403 Mark Holmquist mtrac...@member.fsf.org changed: What|Removed |Added CC||krinklem...@gmail.com Blocks||700 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56403] Use DOM append instead of z-index to position lightbox
https://bugzilla.wikimedia.org/show_bug.cgi?id=56403 Tisza Gergő gti...@gmail.com changed: What|Removed |Added CC||gti...@gmail.com --- Comment #1 from Tisza Gergő gti...@gmail.com --- I don't think so - anything with a z-index would still be above the lightbox. Also, AFAIK z-index is reliable enough as long as you are using it on direct children of the body - the IE6 bug is related to z-indexed elements having non-static parents. The z-index on .mlb-fullscreen-div is pointless, however - its parent also has a z-index so that one will determine how it is placed. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56403] Use DOM append instead of z-index to position lightbox
https://bugzilla.wikimedia.org/show_bug.cgi?id=56403 Fabrice Florin fflo...@wikimedia.org changed: What|Removed |Added Priority|Unprioritized |Low -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
