[Bug 57400] Notification objects are hard to access
https://bugzilla.wikimedia.org/show_bug.cgi?id=57400 Bartosz Dziewoński changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED Assignee|wikibugs-l@lists.wikimedia. |matma@gmail.com |org | Target Milestone|--- |1.23.0 release -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57400] Notification objects are hard to access
https://bugzilla.wikimedia.org/show_bug.cgi?id=57400 --- Comment #6 from Gerrit Notification Bot --- Change 110667 merged by jenkins-bot: mediawiki.notification: Return the Notification object from .notify calls https://gerrit.wikimedia.org/r/110667 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57400] Notification objects are hard to access
https://bugzilla.wikimedia.org/show_bug.cgi?id=57400 Gerrit Notification Bot changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57400] Notification objects are hard to access
https://bugzilla.wikimedia.org/show_bug.cgi?id=57400 --- Comment #5 from Gerrit Notification Bot --- Change 110667 had a related patch set uploaded by Bartosz Dziewoński: mediawiki.notification: Return the Notification object from .notify calls https://gerrit.wikimedia.org/r/110667 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57400] Notification objects are hard to access
https://bugzilla.wikimedia.org/show_bug.cgi?id=57400 --- Comment #4 from Bartosz Dziewoński --- I say let's consider what we have here a consensus and just do it. :D -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57400] Notification objects are hard to access
https://bugzilla.wikimedia.org/show_bug.cgi?id=57400 --- Comment #3 from Alex Monk --- I guess this bug just needs a decision from Krinkle then? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57400] Notification objects are hard to access
https://bugzilla.wikimedia.org/show_bug.cgi?id=57400 --- Comment #2 from Lee Worden --- I'm using one with autoHide:false to report on progress while a brief operation is ongoing. To do this I'm adding a click() handler to the notification's div, so I can abort the operation if the user closes the notification. I guess it would also meet my needs if I could give an onclose() callback to mw.notify(). But I'd say expose the object. It would let developers do more creative things with the notifications. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57400] Notification objects are hard to access
https://bugzilla.wikimedia.org/show_bug.cgi?id=57400 Bartosz Dziewoński changed: What|Removed |Added Priority|Unprioritized |Normal CC||kren...@gmail.com Severity|normal |enhancement --- Comment #1 from Bartosz Dziewoński --- As of Icd7fd1ac (included in MW 1.22) the .close() method is exposed; other methods are not, though. That patch originally aimed to expose the entire object, but Krinkle suggested not to do that. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
