[Bug 57610] Use snake_case for methods and variables
https://bugzilla.wikimedia.org/show_bug.cgi?id=57610 Željko Filipin changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57610] Use snake_case for methods and variables
https://bugzilla.wikimedia.org/show_bug.cgi?id=57610 --- Comment #9 from Gerrit Notification Bot --- Change 100209 had a related patch set uploaded by Zfilipin: Use snake case https://gerrit.wikimedia.org/r/100209 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57610] Use snake_case for methods and variables
https://bugzilla.wikimedia.org/show_bug.cgi?id=57610 --- Comment #8 from Gerrit Notification Bot --- Change 101054 abandoned by Zfilipin: Use snake_case in Aliases Reason: Changes made to files in /selenium folder are out of scope for this Google Code-in task. I have made a few changes to this commit, that is in scope for the task: https://gerrit.wikimedia.org/r/#/c/100209/ https://gerrit.wikimedia.org/r/101054 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57610] Use snake_case for methods and variables
https://bugzilla.wikimedia.org/show_bug.cgi?id=57610 Gerrit Notification Bot changed: What|Removed |Added Status|ASSIGNED|PATCH_TO_REVIEW -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57610] Use snake_case for methods and variables
https://bugzilla.wikimedia.org/show_bug.cgi?id=57610 --- Comment #7 from Gerrit Notification Bot --- Change 101054 had a related patch set uploaded by Aaron1011: Use snake_case in Aliases https://gerrit.wikimedia.org/r/101054 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57610] Use snake_case for methods and variables
https://bugzilla.wikimedia.org/show_bug.cgi?id=57610 Željko Filipin changed: What|Removed |Added Keywords||easy --- Comment #6 from Željko Filipin --- If you need more information (and you probably do), feel free to ask questions here, at #wikimedia-qa freenode IRC channel or at QA mailing list: https://lists.wikimedia.org/mailman/listinfo/qa -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57610] Use snake_case for methods and variables
https://bugzilla.wikimedia.org/show_bug.cgi?id=57610 Željko Filipin changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57610] Use snake_case for methods and variables
https://bugzilla.wikimedia.org/show_bug.cgi?id=57610 --- Comment #5 from Željko Filipin --- CamelCase should still be used for classes and modules, do not change those. For example, this should not be changed (from alias_module.rb[1]): module AliasPage include PageObject ... end end If you have any questions, please ask here (leave a comment) at #wikimedia-qa freenode IRC channel, or at QA mailing list[2]. 1: https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/master/selenium_cuc/features/support/modules/alias_module.rb#L9-L10 2: https://lists.wikimedia.org/mailman/listinfo/qa -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57610] Use snake_case for methods and variables
https://bugzilla.wikimedia.org/show_bug.cgi?id=57610
--- Comment #4 from Željko Filipin ---
After you make the change, check syntax of all Ruby files in a repository with
this (if you are on Mac/Linux):
find . -name "*.rb" -exec ruby -wc {} \;
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57610] Use snake_case for methods and variables
https://bugzilla.wikimedia.org/show_bug.cgi?id=57610 --- Comment #3 from Željko Filipin --- Leo Xiong, Google Code-in student has claimed the task: https://www.google-melange.com/gci/task/view/google/gci2013/5259991820795904 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57610] Use snake_case for methods and variables
https://bugzilla.wikimedia.org/show_bug.cgi?id=57610 --- Comment #2 from Željko Filipin --- What needs to be done? #1 clone repositories listed here: https://github.com/wikimedia/mediawiki-selenium#links (use "Gerrit" link, not "GitHub" link) #2 inspect all Ruby files (.rb) in the repository #3 replace CamelCase with snake_case If you have any questions, ask. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57610] Use snake_case for methods and variables
https://bugzilla.wikimedia.org/show_bug.cgi?id=57610 --- Comment #1 from Željko Filipin --- This is similar to bug #57597. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57610] Use snake_case for methods and variables
https://bugzilla.wikimedia.org/show_bug.cgi?id=57610 Željko Filipin changed: What|Removed |Added URL||https://www.google-melange. ||com/gci/task/view/google/gc ||i2013/5259991820795904 Whiteboard||gci2013 ||https://www.mediawiki.org/w ||iki/Google_Code-In#Candidat ||e_tasks -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
