[Bug 57721] Do not offer thanks for multi diffs

2014-01-03 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=57721

--- Comment #5 from Gerrit Notification Bot  ---
Change 105387 had a related patch set uploaded by Jackmcbarn:
Remove misleading Thank button from some diffs

https://gerrit.wikimedia.org/r/105387

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 57721] Do not offer thanks for multi diffs

2014-01-03 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=57721

Jackmcbarn  changed:

   What|Removed |Added

 CC||jackmcbarn+w...@gmail.com
Version|unspecified |master
   Assignee|wikibugs-l@lists.wikimedia. |jackmcbarn+w...@gmail.com
   |org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 57721] Do not offer thanks for multi diffs

2014-01-03 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=57721

Gerrit Notification Bot  changed:

   What|Removed |Added

 Status|NEW |PATCH_TO_REVIEW

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 57721] Do not offer thanks for multi diffs

2014-01-03 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=57721

--- Comment #4 from Gerrit Notification Bot  ---
Change 105384 had a related patch set uploaded by Jackmcbarn:
Add oldRev parameter to DiffRevisionTools hook

https://gerrit.wikimedia.org/r/105384

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 57721] Do not offer thanks for multi diffs

2014-01-01 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=57721

--- Comment #3 from Nathan Larson  ---
It's for a revision. You'll notice, if you get the diff for a two-revision
change, and then thank the user, when he views the notification, it'll give an
opportunity to "View edit". When he clicks to do so, it'll only show him the
most recent of the revisions in the diff for which he was thanked. This is
consistent with the fact that only one revid is stored in event.event_extra.
https://www.mediawiki.org/wiki/Extension:Echo/echo_event_table#event_extra

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 57721] Do not offer thanks for multi diffs

2014-01-01 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=57721

--- Comment #2 from db  ---
Is thanks for a revision or for the diff between two revisions? That is the
question here, but when it is for a diff, what is with page creation, which
does not have a diff?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 57721] Do not offer thanks for multi diffs

2013-12-31 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=57721

Nathan Larson  changed:

   What|Removed |Added

 CC||nathanlarson3...@gmail.com

--- Comment #1 from Nathan Larson  ---
Shouldn't it be possible to thank for a change that was made over several
revisions?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 57721] Do not offer thanks for multi diffs

2013-12-02 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=57721

Andre Klapper  changed:

   What|Removed |Added

   Priority|Unprioritized   |Low

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l