[Bug 57901] VisualEditor: VE - WT - VE - Cancel leaves ?veaction=edit in the URL

2014-03-12 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=57901

--- Comment #3 from Krinkle krinklem...@gmail.com ---
I can't reproduce this on mediawiki.org or en.wikipedia.org, but I can locally
and on en.wikipedia.beta.wmflabs.org

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 57901] VisualEditor: VE - WT - VE - Cancel leaves ?veaction=edit in the URL

2014-03-12 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=57901

--- Comment #4 from ryasm...@wikimedia.org ---
I can reproduce it on en.wikipedia.org but not on mediawiki.org

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 57901] VisualEditor: VE - WT - VE - Cancel leaves ?veaction=edit in the URL

2014-03-12 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=57901

Krinkle krinklem...@gmail.com changed:

   What|Removed |Added

   Assignee|kren...@gmail.com   |krinklem...@gmail.com

--- Comment #5 from Krinkle krinklem...@gmail.com ---
It should be reliably reproducible on all of the above.

It happens when you access veaction=edit directly in the url on a fresh load.

Chrome has the nasty habit of firing a popstate event (sometimes?) on a regular
load that wasn't via the history.

This can be worked around by storing a piece of data with the state and using
that to tell events apart (to distinguish between a state pop to one we
pushed/replaced into the history, from a pop state to one some other
application pushed in or one the browser is faultily firing, like Chrome does).

jquery-pjax (the plugin GitHub uses to ajax navigate everywhere, powered by
popState), does the same thing. Generate an ID or tag, store that with the
push/replace state, and on the popstate, use that to identify ours and ignore
others.

This will fix lots of other potential bugs as well.

Assigning back to me as it's on my mind now, might as well fix it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 57901] VisualEditor: VE - WT - VE - Cancel leaves ?veaction=edit in the URL

2014-03-12 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=57901

Gerrit Notification Bot gerritad...@wikimedia.org changed:

   What|Removed |Added

 Status|ASSIGNED|PATCH_TO_REVIEW

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 57901] VisualEditor: VE - WT - VE - Cancel leaves ?veaction=edit in the URL

2014-03-12 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=57901

--- Comment #7 from Krinkle krinklem...@gmail.com ---
Rephrasing bug.

There is explicit logic in place to not update the url sometimes. This is for
when we're reacting to a popstate event (e.g. you open VisualEditor from the
read page, this activates the editor without a refresh, if you then click back,
the browser has already updated the url and it is now telling us to react to
that, we don't want to update the url again in that case).

Whenever the editor is initialised in Chrome by direct query parameter  (e.g.
by clicking Edit on a page where we don't load visualeditor, e.g. MediaWiki's
Edit source page), the weird initial popstate fired by Chrome was
misinterpreted as a dynamic state change.

Then, when leaving the editor, we still think we're reacting to a popstate
event so we don't touch the url.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 57901] VisualEditor: VE - WT - VE - Cancel leaves ?veaction=edit in the URL

2014-03-12 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=57901

--- Comment #6 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 118357 had a related patch set uploaded by Krinkle:
mw.ViewPageTarget: Tag our state changes and reject foreign states

https://gerrit.wikimedia.org/r/118357

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 57901] VisualEditor: VE - WT - VE - Cancel leaves ?veaction=edit in the URL

2014-03-03 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=57901

Alex Monk kren...@gmail.com changed:

   What|Removed |Added

 CC||kren...@gmail.com

--- Comment #2 from Alex Monk kren...@gmail.com ---
This appears to be to do with actFromPopState in ve.init.mw.ViewPageTarget

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 57901] VisualEditor: VE - WT - VE - Cancel leaves ?veaction=edit in the URL

2014-03-03 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=57901

James Forrester jforres...@wikimedia.org changed:

   What|Removed |Added

   Assignee|jforrester+veteambztickets@ |kren...@gmail.com
   |wikimedia.org   |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 57901] VisualEditor: VE - WT - VE - Cancel leaves ?veaction=edit in the URL

2014-02-28 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=57901

James Forrester jforres...@wikimedia.org changed:

   What|Removed |Added

   Assignee|krinklem...@gmail.com   |jforrester+veteambztickets@
   ||wikimedia.org

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 57901] VisualEditor: VE - WT - VE - Cancel leaves ?veaction=edit in the URL

2013-12-02 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=57901

James Forrester jforres...@wikimedia.org changed:

   What|Removed |Added

   Priority|Unprioritized   |Normal
 Status|NEW |ASSIGNED
 CC||roan.katt...@gmail.com,
   ||tpars...@wikimedia.org
  Component|Editing Tools   |MediaWiki integration
   Assignee|rm...@wikimedia.org |krinklem...@gmail.com
Summary|VisualEditor:Reloading the  |VisualEditor: VE - WT -
   |page in read mode opens up  |VE - Cancel leaves
   |the editor  |?veaction=edit in the URL
   Severity|normal  |minor

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l