https://bugzilla.wikimedia.org/show_bug.cgi?id=58077
Yaron Koren changed:
What|Removed |Added
Status|PATCH_TO_REVIEW |RESOLVED
Resolution|---
https://bugzilla.wikimedia.org/show_bug.cgi?id=58077
--- Comment #13 from Yaron Koren ---
Hi Al,
I looked into this - I definitely was able to replicate the problem with the
"regexp" input type; but "mandatory" worked fine for me, without the need for
changes. Your first fix (the two-line change
https://bugzilla.wikimedia.org/show_bug.cgi?id=58077
--- Comment #12 from Gerrit Notification Bot ---
Change 104514 merged by jenkins-bot:
Fix to avoid JS validation of fields hidden by "show on select"
https://gerrit.wikimedia.org/r/104514
--
You are receiving this mail because:
You are on th
https://bugzilla.wikimedia.org/show_bug.cgi?id=58077
Gerrit Notification Bot changed:
What|Removed |Added
Status|UNCONFIRMED |PATCH_TO_REVIEW
Ever con
https://bugzilla.wikimedia.org/show_bug.cgi?id=58077
--- Comment #11 from Gerrit Notification Bot ---
Change 104514 had a related patch set uploaded by Yaron Koren:
Fix to avoid JS validation of fields hidden by "show on select"
https://gerrit.wikimedia.org/r/104514
--
You are receiving this m
https://bugzilla.wikimedia.org/show_bug.cgi?id=58077
--- Comment #10 from Al Johnson ---
Seems to, but I'm no expert.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.or
https://bugzilla.wikimedia.org/show_bug.cgi?id=58077
--- Comment #9 from Yaron Koren ---
Does this fully work, as far as you know?
--
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists
https://bugzilla.wikimedia.org/show_bug.cgi?id=58077
--- Comment #8 from Al Johnson ---
Well, there was another problem with fields with default values and within
disabled divs (hidden) still being submitted, so I had to add one more check.
Also, added the .parent() call to make sure that SF-hid
https://bugzilla.wikimedia.org/show_bug.cgi?id=58077
--- Comment #7 from Al Johnson ---
The fix above is not enough since the hidden stuff may not have had the
hiddenBySF class added to them upon page load and it looks like mandatory but
hidden fields are setup to be validated. Is that by design
https://bugzilla.wikimedia.org/show_bug.cgi?id=58077
Al Johnson changed:
What|Removed |Added
CC||alj62...@yahoo.com
--- Comment #6 from Al
https://bugzilla.wikimedia.org/show_bug.cgi?id=58077
--- Comment #5 from Al Johnson ---
I just tried both combinations... without mandatory and without the regex.
Both have to be removed.
--
You are receiving this mail because:
You are on the CC list for the bug.
__
https://bugzilla.wikimedia.org/show_bug.cgi?id=58077
--- Comment #4 from Yaron Koren ---
Right, I got the "hidden" part. Is the "mandatory" part necessary, given the
regexp validation? Maybe it's the interplay of those two that's causing this
bug... at least, that's my hope.
--
You are receivin
https://bugzilla.wikimedia.org/show_bug.cgi?id=58077
--- Comment #3 from Al Johnson ---
{{{field|additional-url-vid-startsec|input type=regexp|regexp=/^\d{1,2}$/
|maxlength=2|size=1|mandatory}}}
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.wikimedia.org/show_bug.cgi?id=58077
--- Comment #2 from Al Johnson ---
NOTE: when I say 'hidden', I'm not referring to the hidden option for fields.
I'm speaking about a div that is hidden unless a dropdown value matches one of
the "show on select" options.
--
You are receivin
https://bugzilla.wikimedia.org/show_bug.cgi?id=58077
--- Comment #1 from Yaron Koren ---
What do you mean by "using regex validation"? What does the {{{field}}} tag
look like?
--
You are receiving this mail because:
You are on the CC list for the bug.
___
15 matches
Mail list logo
