[Bug 58311] On page for files that don't exist, edit icon shouldn't open editor for articles
https://bugzilla.wikimedia.org/show_bug.cgi?id=58311 --- Comment #16 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 134589 merged by jenkins-bot: Implement upload via Add image on New file pages https://gerrit.wikimedia.org/r/134589 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58311] On page for files that don't exist, edit icon shouldn't open editor for articles
https://bugzilla.wikimedia.org/show_bug.cgi?id=58311 Jon jrob...@wikimedia.org changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58311] On page for files that don't exist, edit icon shouldn't open editor for articles
https://bugzilla.wikimedia.org/show_bug.cgi?id=58311 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58311] On page for files that don't exist, edit icon shouldn't open editor for articles
https://bugzilla.wikimedia.org/show_bug.cgi?id=58311 --- Comment #15 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 134589 had a related patch set uploaded by Florianschmidtwelzow: Implement upload via Add image on New file pages https://gerrit.wikimedia.org/r/134589 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58311] On page for files that don't exist, edit icon shouldn't open editor for articles
https://bugzilla.wikimedia.org/show_bug.cgi?id=58311 --- Comment #14 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 104324 abandoned by Jdlrobson: On File does not exist disable edit, enable upload Reason: At request of submitter. Feel free to re-open this or use as a basis for a future fix to this problem! :) https://gerrit.wikimedia.org/r/104324 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58311] On page for files that don't exist, edit icon shouldn't open editor for articles
https://bugzilla.wikimedia.org/show_bug.cgi?id=58311 Jon jrob...@wikimedia.org changed: What|Removed |Added Status|PATCH_TO_REVIEW |NEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58311] On page for files that don't exist, edit icon shouldn't open editor for articles
https://bugzilla.wikimedia.org/show_bug.cgi?id=58311 --- Comment #12 from Jared Flores jaredflores2...@gmail.com --- Hi, I've managed to disable the edit button already, but what exactly would you like me to do with the upload button? I've already unlocked it, but I'm not sure where to go from there. Do you want me to link the button with Special:Upload? Or would you like me to modify the PhotoUpload.js to include a function for non-existent files. The latter is a tad bit harder, but if that's what you would like, I'll do it Thanks in Advanced, Jared Flores -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58311] On page for files that don't exist, edit icon shouldn't open editor for articles
https://bugzilla.wikimedia.org/show_bug.cgi?id=58311 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|ASSIGNED|PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58311] On page for files that don't exist, edit icon shouldn't open editor for articles
https://bugzilla.wikimedia.org/show_bug.cgi?id=58311 --- Comment #13 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 104324 had a related patch set uploaded by Jcf2000: On File does not exist disable edit, enable upload https://gerrit.wikimedia.org/r/104324 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58311] On page for files that don't exist, edit icon shouldn't open editor for articles
https://bugzilla.wikimedia.org/show_bug.cgi?id=58311 --- Comment #10 from Jared Flores jaredflores2...@gmail.com --- Hi, Where exactly would I find the handling for non-existent files in MobileFrontend? I've been told it might be in \includes\skins\SkinMobileBeta.php, but I've been at a loss of where to find it. Thanks in Advanced, Jared Flores -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58311] On page for files that don't exist, edit icon shouldn't open editor for articles
https://bugzilla.wikimedia.org/show_bug.cgi?id=58311 --- Comment #11 from Jared Flores jaredflores2...@gmail.com --- Nevermind, I believe I've found it. Patch will be uploaded once my testing environment starts working again -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58311] On page for files that don't exist, edit icon shouldn't open editor for articles
https://bugzilla.wikimedia.org/show_bug.cgi?id=58311 Jared Flores jaredflores2...@gmail.com changed: What|Removed |Added CC||jaredflores2...@gmail.com --- Comment #8 from Jared Flores jaredflores2...@gmail.com --- Just to be clear, is this what you want? -Disable the edit button and switch the icon to the disabled edit icon -Unlock the upload button, and trigger the normal upload workflow -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58311] On page for files that don't exist, edit icon shouldn't open editor for articles
https://bugzilla.wikimedia.org/show_bug.cgi?id=58311 Quim Gil q...@wikimedia.org changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|wikibugs-l@lists.wikimedia. |jaredflores2...@gmail.com |org | --- Comment #9 from Quim Gil q...@wikimedia.org --- Yes JaredF, this is what I also understand. fyi, Jared Flores is a Google Code-in student that has started working on this task. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58311] On page for files that don't exist, edit icon shouldn't open editor for articles
https://bugzilla.wikimedia.org/show_bug.cgi?id=58311 Jon jrob...@wikimedia.org changed: What|Removed |Added Keywords||design Status|NEW |UNCONFIRMED Ever confirmed|1 |0 Severity|normal |enhancement --- Comment #2 from Jon jrob...@wikimedia.org --- Kenan / designers what do you think? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58311] On page for files that don't exist, edit icon shouldn't open editor for articles
https://bugzilla.wikimedia.org/show_bug.cgi?id=58311 Jared Zimmerman (WMF) jared.zimmer...@wikimedia.org changed: What|Removed |Added Priority|Unprioritized |Normal -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58311] On page for files that don't exist, edit icon shouldn't open editor for articles
https://bugzilla.wikimedia.org/show_bug.cgi?id=58311 Jared Zimmerman (WMF) jared.zimmer...@wikimedia.org changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #3 from Jared Zimmerman (WMF) jared.zimmer...@wikimedia.org --- I think we should have an upload icon for this case rather than an edit icon. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58311] On page for files that don't exist, edit icon shouldn't open editor for articles
https://bugzilla.wikimedia.org/show_bug.cgi?id=58311 Jon jrob...@wikimedia.org changed: What|Removed |Added CC||aklap...@wikimedia.org, ||q...@wikimedia.org --- Comment #4 from Jon jrob...@wikimedia.org --- Jared so how about this as a first step: Visiting https://en.m.wikipedia.org/wiki/File:Foozajashsaash.png (a file that doesn't exist) shows a page actions bar without an edit button. Clicking upload starts the normal upload workflow but saves it to the same file name as given in the URL? Quim this could be a good task for Google Code in. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58311] On page for files that don't exist, edit icon shouldn't open editor for articles
https://bugzilla.wikimedia.org/show_bug.cgi?id=58311 --- Comment #5 from Jon jrob...@wikimedia.org --- (upload being the existing upload icon in the page action bar) -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58311] On page for files that don't exist, edit icon shouldn't open editor for articles
https://bugzilla.wikimedia.org/show_bug.cgi?id=58311 --- Comment #6 from Jared Zimmerman (WMF) jared.zimmer...@wikimedia.org --- That sounds fine, we could suppress the normal edit icon in this case? also we'd switch the image icon not to be the locked state, correct? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58311] On page for files that don't exist, edit icon shouldn't open editor for articles
https://bugzilla.wikimedia.org/show_bug.cgi?id=58311 Quim Gil q...@wikimedia.org changed: What|Removed |Added URL||http://www.google-melange.c ||om/gci/task/view/google/gci ||2013/5234875657355264 Whiteboard||gci2013 --- Comment #7 from Quim Gil q...@wikimedia.org --- Created a GCI task. Please leave the task as clear as possible to the eventual CI student. Thank you! -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58311] On page for files that don't exist, edit icon shouldn't open editor for articles
https://bugzilla.wikimedia.org/show_bug.cgi?id=58311 --- Comment #1 from Bingle bingle-ad...@wikimedia.org --- Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1497 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
