https://bugzilla.wikimedia.org/show_bug.cgi?id=58726
Web browser: ---
Bug ID: 58726
Summary: refactor duplicate code into getNotificationIconUrl()
Product: MediaWiki extensions
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: Unprioritized
Component: Echo
Assignee: wikibugs-l@lists.wikimedia.org
Reporter: sp...@wikimedia.org
CC: agarr...@wikimedia.org, bs...@wikimedia.org,
legoktm.wikipe...@gmail.com
Classification: Unclassified
Mobile Platform: ---
formatters/BasicFormatter.php's format() and includes/EmailFormatter.php
getNotifIcon() were already duplicating code to determine the URL of a
notification icon. With the fix for bug 58705 it's 20 lines of identical code.
The only difference between them is getNotifIcon() calls wfExpandUrl(); this
e.g. could be an optional parameter to a common function or method.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
