https://bugzilla.wikimedia.org/show_bug.cgi?id=59105
--- Comment #6 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 104473 merged by jenkins-bot:
Avoid interacting with LBFactory singleton in tests
https://gerrit.wikimedia.org/r/104473
--
You are receiving this mail because:
https://bugzilla.wikimedia.org/show_bug.cgi?id=59105
Tyler Romeo tylerro...@gmail.com changed:
What|Removed |Added
Status|PATCH_TO_REVIEW |RESOLVED
https://bugzilla.wikimedia.org/show_bug.cgi?id=59105
--- Comment #1 from Aude aude.w...@gmail.com ---
failure also occurs on jenkins in mediawiki-core-regression-master job (post
merge):
https://integration.wikimedia.org/ci/job/mediawiki-core-regression-master/3933/console
--
You are receiving
https://bugzilla.wikimedia.org/show_bug.cgi?id=59105
--- Comment #2 from Aude aude.w...@gmail.com ---
If I remove the FakeLBFactory::destroyInstance(); line in LBFactoryTest, then
the database errors do not occur however the LBFactoryTests do not work
properly and fail.
I am not quite sure what
https://bugzilla.wikimedia.org/show_bug.cgi?id=59105
Tyler Romeo tylerro...@gmail.com changed:
What|Removed |Added
CC||tylerro...@gmail.com
https://bugzilla.wikimedia.org/show_bug.cgi?id=59105
--- Comment #4 from Aude aude.w...@gmail.com ---
doing option #1 seems best. I think it's fine to test that we are handling the
deprecation / backwards compatibility correctly.
the singleton and all the global stuff makes LBFactory tricky to
https://bugzilla.wikimedia.org/show_bug.cgi?id=59105
--- Comment #5 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 104473 had a related patch set uploaded by Aude:
Avoid interacting with LBFactory singleton in tests
https://gerrit.wikimedia.org/r/104473
--
You are receiving
https://bugzilla.wikimedia.org/show_bug.cgi?id=59105
Gerrit Notification Bot gerritad...@wikimedia.org changed:
What|Removed |Added
Status|NEW
