https://bugzilla.wikimedia.org/show_bug.cgi?id=59747
Web browser: ---
Bug ID: 59747
Summary: initial KeepGoing overlay does not render
Product: MediaWiki extensions
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: major
Priority: Unprioritized
Component: MobileFrontend (Beta)
Assignee: wikibugs-l@lists.wikimedia.org
Reporter: rkald...@wikimedia.org
CC: jgon...@wikimedia.org, jrob...@wikimedia.org,
kw...@wikimedia.org, maxsem.w...@gmail.com,
mgro...@wikimedia.org, mpinc...@wikimedia.org,
rkald...@wikimedia.org
Classification: Unclassified
Mobile Platform: ---
It looks like the KeepGoing overlay was broken by
https://gerrit.wikimedia.org/r/#/c/102043/.
Specifically, that change moved the overlay show() from
KeepGoingOverlay::render() to the keepgoing.js instatiation (which only handles
the 2nd half of the keepgoing workflow). The first step is handled in
EditorOverlay.js (around line 233).
This could either be fixed by adding a show() in EditorOverlay.js or moving
show() back into KeepGoingOverlay::render(). Putting it back in
KeepGoingOverlay::render() seems the most sensible (after all, that's the
function that is supposed to render the overlay). Is there a specific reason it
was moved out of that function?
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
