https://bugzilla.wikimedia.org/show_bug.cgi?id=59939
Web browser: ---
Bug ID: 59939
Summary: Flow: a garbled post must not prevent loading its
topic or Board
Product: MediaWiki extensions
Version: master
Hardware: All
OS: All
Status: NEW
Severity: major
Priority: Unprioritized
Component: Flow
Assignee: wikibugs-l@lists.wikimedia.org
Reporter: sp...@wikimedia.org
CC: bs...@wikimedia.org, ebernhard...@wikimedia.org,
oke...@wikimedia.org, pandiculat...@gmail.com,
sp...@wikimedia.org
Classification: Unclassified
Mobile Platform: ---
When bug 59884 was happening, the garbled cache (or database?) from failed
posts meant nobody could view a board or topic, it would fail with
Missing Posts: {"14":"050de380f7b8f1dc09e4842b2b77e6f9"}
The user would see this in an errorbox at "Earlier posts" if the problematic
post was paginated into view, or would just see "Failed to load the requested
data" and this exception would be in exception.log.
We fixed that bug so that new posts worked, and Benny manually located and
deleted the garbled cache keys so people could view boards again.
But, there are any number of ways a single post might fail to load (see e.g.
bug 57987). Flow must load the other posts in the topic and the other nine
posts in the board. It should display an errorbox about the missing post in
context giving its UUID as above (cute fail icon optional) so the user knows
about the missing post (unlike Facebook's "Ehh, go read the other fluff"!), and
still log the problem somewhere prominent (card #590?) so operations counts it
as a severe problem.
There's a comment in includes/Data/RootPostLoader.php
// TODO: fake up a pseudo-post to hold the children? At this point in
// dev its probably a bug we want to see.
throw new InvalidDataException( 'Missing Posts: ' . json_encode( $missing
), 'fail-load-data' );
but now we mustn't break an entire Flow board in production over one problem
post.
Besides the post in bug 59884 I've left a garbled post on test2wiki, at
https://test2.wikipedia.org/w/index.php?title=Talk:Flow_QA&workflow=050d915f4ecd5085237590b11c2fa805
Don't clean this up, it's a nice test to verify better handling of this
problem.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
