https://bugzilla.wikimedia.org/show_bug.cgi?id=59986
Web browser: ---
Bug ID: 59986
Summary: PDFHandler doesn't redirect gs stderr, so errors in
that stage not reported
Product: MediaWiki extensions
Version: unspecified
Hardware: All
OS: All
Status: NEW
Keywords: easy
Severity: normal
Priority: Unprioritized
Component: PdfHandler
Assignee: wikibugs-l@lists.wikimedia.org
Reporter: bawolff...@gmail.com
CC: aarcos.w...@gmail.com, bawolff...@gmail.com,
fflo...@wikimedia.org, gti...@wikimedia.org,
mtrac...@member.fsf.org
Classification: Unclassified
Mobile Platform: ---
Marking easy, as this is probably a straightforward bug to fix.
Currently PDFHandler runs gs and convert in a pipeline (See
PdfHandler::doTransform). It sticks 2>&1 on the end of the command to catch
error output, however that doesn't apply to the whole pipeline, only the last
command. Hence ghostscript (gs) errors are missed.
Recommended fix: remove the 2>&1, and instead of calling wfShellExec, call
wfShellExecWithStderr. (This will also catch errors for other commands, like
the resource limit things, so its better than using 2>&1 anyways).
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
