[Bug 60054] Visibility of WikiPage::$mPreparedEdit changed from public to protected in 1.22.1 tarball, breaks Semantic MediaWiki

2014-02-25 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60054

Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #9 from Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com ---
This was fixed in the 1.22.2 release.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60054] Visibility of WikiPage::$mPreparedEdit changed from public to protected in 1.22.1 tarball, breaks Semantic MediaWiki

2014-02-25 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60054

Nemo federicol...@tiscali.it changed:

   What|Removed |Added

 CC||federicol...@tiscali.it
   Target Milestone|--- |1.22.x release
  Flags||Backport_to_Stable+

--- Comment #10 from Nemo federicol...@tiscali.it ---
So this bug in core was caused by a backport to stable of a patch for a bug
which didn't have a request of backport and is not even against core (bug
57026)? I'm confused.
Anyway, https://gerrit.wikimedia.org/r/#/c/107488/ was merged.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60054] Visibility of WikiPage::$mPreparedEdit changed from public to protected in 1.22.1 tarball, breaks Semantic MediaWiki

2014-01-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60054

Andre Klapper aklap...@wikimedia.org changed:

   What|Removed |Added

   Priority|Unprioritized   |High
Summary|Visibility of   |Visibility of
   |WikiPage::$mPreparedEdit|WikiPage::$mPreparedEdit
   |changed from public to  |changed from public to
   |protected, breaks Semantic  |protected in 1.22.1
   |MediaWiki   |tarball, breaks Semantic
   ||MediaWiki
   Severity|normal  |major

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60054] Visibility of WikiPage::$mPreparedEdit changed from public to protected in 1.22.1 tarball, breaks Semantic MediaWiki

2014-01-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60054

Mark A. Hershberger m...@everybody.org changed:

   What|Removed |Added

 CC||m...@everybody.org

--- Comment #6 from Mark A. Hershberger m...@everybody.org ---
For future releases, we should have some acceptance testing that verifies the
visibility of member variables doesn't change on point releases.

Sam has a good method for handling this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60054] Visibility of WikiPage::$mPreparedEdit changed from public to protected in 1.22.1 tarball, breaks Semantic MediaWiki

2014-01-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60054

--- Comment #7 from Bartosz DziewoƄski matma@gmail.com ---
An eyeball test should be quite sufficient.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60054] Visibility of WikiPage::$mPreparedEdit changed from public to protected in 1.22.1 tarball, breaks Semantic MediaWiki

2014-01-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60054

--- Comment #8 from Mark A. Hershberger m...@everybody.org ---
(In reply to comment #7)
 An eyeball test should be quite sufficient.

Agreed.  The problem with eyeball tests is that they cannot be automated and
run reliably.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l