[Bug 60077] Wrong image path, hence background color for buttons missing

2014-01-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60077

--- Comment #2 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 108040 had a related patch set uploaded by Gerrit Patch Uploader:
Embed background images in jquery.ui.theme.css correctly

https://gerrit.wikimedia.org/r/108040

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60077] Wrong image path, hence background color for buttons missing

2014-01-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60077

Gerrit Notification Bot gerritad...@wikimedia.org changed:

   What|Removed |Added

 Status|NEW |PATCH_TO_REVIEW

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60077] Wrong image path, hence background color for buttons missing

2014-01-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60077

--- Comment #3 from Fomafix foma...@googlemail.com ---
The problem is in mediawiki/core in file
resources/jquery.ui/themes/default/jquery.ui.theme.css

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60077] Wrong image path, hence background color for buttons missing

2014-01-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60077

Bartosz Dziewoński matma@gmail.com changed:

   What|Removed |Added

 CC||krinklem...@gmail.com,
   ||matma@gmail.com,
   ||roan.katt...@gmail.com,
   ||tpars...@wikimedia.org
  Component|ApiSandbox  |ResourceLoader
Version|master  |1.23-git
Product|MediaWiki extensions|MediaWiki

--- Comment #4 from Bartosz Dziewoński matma@gmail.com ---
This actually looks like a core CSSMin bug to me: the url() value is not
recognized and thus not processed as it should be (fixing the patch).


For the record, one of the problematic rules is below:

.ui-widget-content { border: 1px solid #aa/*{borderColorContent}*/;
background: #ff/*{bgColorContent}*/
url(images/ui-bg_flat_75_ff_40x100.png)/*{bgImgUrlContent}*/
50%/*{bgContentXPos}*/ 50%/*{bgContentYPos}*/ repeat-x/*{bgContentRepeat}*/;
color: #22/*{fcContent}*/; }


The braces in comments make this regex from CSSMin.php not match:

const URL_REGEX =
'url\(\s*[\']?(?Pfile[^\?\)\']*?)(?Pquery\?[^\)\']*?|)[\']?\s*\)';
$pattern = '/(?:^|[;{])\K[^;{}]*' . CSSMin::URL_REGEX . '[^;}]*(?=[;}]|$)/';


Not sure if we want to contort this regex even further to support this…
comments, anyone?

Probably caused by https://gerrit.wikimedia.org/r/#/c/94511/ .

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60077] Wrong image path, hence background color for buttons missing

2014-01-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60077

--- Comment #1 from Fomafix foma...@googlemail.com ---
In skin Vector this problem doesn't occur. It occurs in Monobook, Modern and
cologneblue:

https://en.wikipedia.org/wiki/Special:ApiSandbox?useskin=monobook
https://en.wikipedia.org/wiki/Special:ApiSandbox?useskin=modern
https://en.wikipedia.org/wiki/Special:ApiSandbox?useskin=cologneblue

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60077] Wrong image path, hence background color for buttons missing

2014-01-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60077

Andre Klapper aklap...@wikimedia.org changed:

   What|Removed |Added

   Severity|normal  |minor

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60077] Wrong image path, hence background color for buttons missing

2014-01-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60077

Andre Klapper aklap...@wikimedia.org changed:

   What|Removed |Added

   Priority|Unprioritized   |Normal
Summary|Wrong image path|Wrong image path, hence
   ||background color for
   ||buttons missing

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l