[Bug 60275] Flow actions don't show up in CheckUser

2014-01-31 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60275

--- Comment #12 from Risker risker...@gmail.com ---
(In reply to comment #9)
 Luis, yes, you can still see all the relevant actions in the users'
 contributions, in page history, in recent changes, etc.

I'm not actually seeing many of the user actions I know I took in the *page*
history. Indeed, when comparing my contributions to the page history on the
sandbox[2] for 27-28 January, most of my actions aren't there.  Incidentally,
the page title isn't included in my contributions history. This is a problem.
(Is it a different bugzilla?)

[1] https://www.mediawiki.org/wiki/Special:Contributions/Risker
[2]
https://www.mediawiki.org/w/index.php?title=Talk:Sandboxaction=board-history

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60275] Flow actions don't show up in CheckUser

2014-01-31 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60275

--- Comment #13 from Oliver Keyes oke...@wikimedia.org ---
(In reply to comment #12)
 (In reply to comment #9)
  Luis, yes, you can still see all the relevant actions in the users'
  contributions, in page history, in recent changes, etc.
 
 I'm not actually seeing many of the user actions I know I took in the *page*
 history. Indeed, when comparing my contributions to the page history on the
 sandbox[2] for 27-28 January, most of my actions aren't there.
Yep, we're working on the history section - you may want to check in topic
history too (under the topic dropdown)

 Incidentally,
 the page title isn't included in my contributions history. This is a problem.
 (Is it a different bugzilla?)

Yep, the lack of clarity (Topic,Comment) is a known, and we're working on
it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60275] Flow actions don't show up in CheckUser

2014-01-29 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60275

--- Comment #11 from Erik Bernhardson ebernhard...@wikimedia.org ---
(In reply to comment #7)
 Sorry, that's not what I meant. I'm talking about the HTML returned by
 \Flow\RecentChanges\Formatter::format()

Getting wikitext out of there would be difficult, it was designed to work with
the OldChangesListRecentChangesLine hook which expects a line of html.  In
terms of the functionality this needs, the list of links, potentially could
extend the abstract \Flow\Formatter to accept a check user row and run the
buildActionLinks method for it.  That will get you an array of arrays, the
inner arrays each containing a url and a plain text link name.

I'm not sure yet how to get the data across though, it needs a Title, action
string, and one or two uuids.  The title is already there, the action could
potentially be stored in cuc_actiontext although i have not yet checked if that
is legitimate.  For the uuid's i'm really not sure though, beyond adjusting the
cu_changes table.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60275] Flow actions don't show up in CheckUser

2014-01-28 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60275

Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com changed:

   What|Removed |Added

 Depends on||60559

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60275] Flow actions don't show up in CheckUser

2014-01-27 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60275

--- Comment #5 from Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com ---
So...making the entries show up properly is complicated.

The normal place to add in handling was in CheckUser::getLinksFromRow, and call
the Flow formatter there. Aside from having to do some hacky stuff to get a
RecentChange object, this didn't work since the cu_changes table does not store
rc_params, which Flow depends upon.

Next I looked into CheckUserHooks::updateCheckUserData, except I didn't see any
way in Flow to get wikitext instead of HTML from the RecentChanges formatter.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60275] Flow actions don't show up in CheckUser

2014-01-27 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60275

--- Comment #6 from Erik Bernhardson ebernhard...@wikimedia.org ---
You can convert any parsoid html to wikitext with 

Flow\ParsoidUtils::convert( 'html', 'wt', $htmlContent );

That is currently inefficient, the content came in as wikitext and was
converted to html.  Easiest way for now would be to add an internal cache to
ParsoidUtils such that after converting wt-html, asking for the wikitext of
that html retrieves it from the cache.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60275] Flow actions don't show up in CheckUser

2014-01-27 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60275

--- Comment #7 from Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com ---
Sorry, that's not what I meant. I'm talking about the HTML returned by
\Flow\RecentChanges\Formatter::format()

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60275] Flow actions don't show up in CheckUser

2014-01-27 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60275

Luis Villa (WMF Legal) lvi...@wikimedia.org changed:

   What|Removed |Added

 CC||lvi...@wikimedia.org

--- Comment #8 from Luis Villa (WMF Legal) lvi...@wikimedia.org ---
Dumb question: do we still have the equivalent of the history log, such that
given a page and a timestamp I can figure out what happened? Or is that also
missing?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60275] Flow actions don't show up in CheckUser

2014-01-27 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60275

Maryana Pinchuk mpinc...@wikimedia.org changed:

   What|Removed |Added

 CC||mpinc...@wikimedia.org

--- Comment #9 from Maryana Pinchuk mpinc...@wikimedia.org ---
Luis, yes, you can still see all the relevant actions in the users'
contributions, in page history, in recent changes, etc.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60275] Flow actions don't show up in CheckUser

2014-01-27 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60275

--- Comment #10 from Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com ---
(In reply to comment #8)
 Dumb question: do we still have the equivalent of the history log, such that
 given a page and a timestamp I can figure out what happened? Or is that also
 missing?

Yes, that should be possible with the current history view
(https://www.mediawiki.org/w/index.php?title=Talk:Sandboxaction=board-history
- throwing an exception which is another bug that has been fixed, just not
deployed).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60275] Flow actions don't show up in CheckUser

2014-01-21 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60275

Oliver Keyes oke...@wikimedia.org changed:

   What|Removed |Added

   Priority|Unprioritized   |High

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60275] Flow actions don't show up in CheckUser

2014-01-21 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60275

Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com changed:

   What|Removed |Added

 Status|PATCH_TO_REVIEW |NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60275] Flow actions don't show up in CheckUser

2014-01-21 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60275

--- Comment #4 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 108653 merged by jenkins-bot:
Use RecentChanges::save to add RC rows

https://gerrit.wikimedia.org/r/108653

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60275] Flow actions don't show up in CheckUser

2014-01-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60275

--- Comment #1 from Bingle bingle-ad...@wikimedia.org ---
The WMF core features team tracks this bug on Mingle card
https://wikimedia.mingle.thoughtworks.com/projects/flow/cards/731, but people
from the community are welcome to contribute here and in Gerrit.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60275] Flow actions don't show up in CheckUser

2014-01-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60275

--- Comment #2 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 108653 had a related patch set uploaded by Legoktm:
Use RecentChanges::save to add RC rows

https://gerrit.wikimedia.org/r/108653

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60275] Flow actions don't show up in CheckUser

2014-01-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60275

Gerrit Notification Bot gerritad...@wikimedia.org changed:

   What|Removed |Added

 Status|NEW |PATCH_TO_REVIEW

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60275] Flow actions don't show up in CheckUser

2014-01-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60275

--- Comment #3 from Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com ---
Patch is the first step. Right now the entries in CheckUser look like:

 (diff) (hist) . . Talk:Flow . . 04:08 . . Admin (Talk | contribs | block)
IP: 10.0.2.2   Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:26.0)
Gecko/20100101 Firefox/26.0

The diff and history links are broken, and there is no indication of what Flow
action was taken.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60275] Flow actions don't show up in CheckUser

2014-01-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60275

MZMcBride b...@mzmcbride.com changed:

   What|Removed |Added

 Blocks||60178

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l