[Bug 60605] Create another account button should not also be an h3 element
https://bugzilla.wikimedia.org/show_bug.cgi?id=60605 Bartosz Dziewoński matma@gmail.com changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED CC||matma@gmail.com Resolution|--- |FIXED Assignee|wikibugs-l@lists.wikimedia. |rkald...@wikimedia.org |org | Target Milestone|--- |1.23.0 release -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60605] Create another account button should not also be an h3 element
https://bugzilla.wikimedia.org/show_bug.cgi?id=60605 --- Comment #2 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 110296 merged by jenkins-bot: Remove unneeded h3s around Create Account links https://gerrit.wikimedia.org/r/110296 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60605] Create another account button should not also be an h3 element
https://bugzilla.wikimedia.org/show_bug.cgi?id=60605 Steven Walling swall...@wikimedia.org changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- --- Comment #3 from Steven Walling swall...@wikimedia.org --- Compare: http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special:UserLoginreturnto=Main+Page to mediawiki.org and enwiki prod. Removing the h3 here and turning it in to a div created an unwanted line break, if you look at this on Beta Labs. In English (other languages may be too long) it is short enough to be on one line. Unless the button text or description are too long (as in some langauges) we should not have a line break between them. Please test and fix this before this goes out to enwiki. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60605] Create another account button should not also be an h3 element
https://bugzilla.wikimedia.org/show_bug.cgi?id=60605 Bartosz Dziewoński matma@gmail.com changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED --- Comment #4 from Bartosz Dziewoński matma@gmail.com --- That's because width of the container is defined to be 20em, and the size of 'em' changed. We should not depend on it not to change for pixel-perfect sizing, and we should not build pixel-perfect layouts for one language only… This is fixed, please feel free to submit a patch to fix the silly em sizing. It was there before and I don't believe the change is layout to be a bug, really, it's just different. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60605] Create another account button should not also be an h3 element
https://bugzilla.wikimedia.org/show_bug.cgi?id=60605 --- Comment #5 from Steven Walling swall...@wikimedia.org --- (In reply to comment #4) That's because width of the container is defined to be 20em, and the size of 'em' changed. We should not depend on it not to change for pixel-perfect sizing, and we should not build pixel-perfect layouts for one language only… This is fixed, please feel free to submit a patch to fix the silly em sizing. It was there before and I don't believe the change is layout to be a bug, really, it's just different. Wrong. You can't break a design with a patch and then call it fixed. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60605] Create another account button should not also be an h3 element
https://bugzilla.wikimedia.org/show_bug.cgi?id=60605 --- Comment #1 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 110296 had a related patch set uploaded by Kaldari: Remove unneeded h3s around Create Account links https://gerrit.wikimedia.org/r/110296 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60605] Create another account button should not also be an h3 element
https://bugzilla.wikimedia.org/show_bug.cgi?id=60605 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60605] Create another account button should not also be an h3 element
https://bugzilla.wikimedia.org/show_bug.cgi?id=60605 Sam Reed (reedy) s...@reedyboy.net changed: What|Removed |Added Priority|Unprioritized |Normal Severity|normal |minor -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
