[Bug 60633] Fatal error: Call to a member function getId() on a non-object in CourseTalkNotification.php on line 108

2014-02-06 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=60633

Sage Ross  changed:

   What|Removed |Added

 Status|PATCH_TO_REVIEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 60633] Fatal error: Call to a member function getId() on a non-object in CourseTalkNotification.php on line 108

2014-01-30 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=60633

Andrew Green  changed:

   What|Removed |Added

 Status|NEW |PATCH_TO_REVIEW

--- Comment #2 from Andrew Green  ---
https://gerrit.wikimedia.org/r/#/c/110446/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 60633] Fatal error: Call to a member function getId() on a non-object in CourseTalkNotification.php on line 108

2014-01-30 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=60633

Andrew Green  changed:

   What|Removed |Added

   Assignee|wikibugs-l@lists.wikimedia. |andrew.green...@gmail.com
   |org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 60633] Fatal error: Call to a member function getId() on a non-object in CourseTalkNotification.php on line 108

2014-01-30 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=60633

--- Comment #1 from Sam Reed (reedy)  ---
public function trigger( $params ) {

$revision = $params['revision'];

\EchoEvent::create( array(
'type' => CourseTalkNotification::KEY,
'title' => $params['course-talk-title'],
'agent' => $params['agent'],
'extra' => array (

// 'revid' is used by the EchoBasicFormatter (which
// CourseTalkFormatter inherits from) to generate the diff
// destination, which we use in the secondary link.
'revid' => $revision->getId(),
),
) );
}



Not checking if there's actually a revision object...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l