[Bug 60940] Gerrit throwing internal server error with status:closed queries
https://bugzilla.wikimedia.org/show_bug.cgi?id=60940 christ...@quelltextlich.at changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED --- Comment #10 from christ...@quelltextlich.at --- New, fixed gerrit has been deployed yesterday. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60940] Gerrit throwing internal server error with status:closed queries
https://bugzilla.wikimedia.org/show_bug.cgi?id=60940 --- Comment #11 from Bartosz Dziewoński matma@gmail.com --- Thank you! -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60940] Gerrit throwing internal server error with status:closed queries
https://bugzilla.wikimedia.org/show_bug.cgi?id=60940 --- Comment #12 from MZMcBride b...@mzmcbride.com --- \o/ -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60940] Gerrit throwing internal server error with status:closed queries
https://bugzilla.wikimedia.org/show_bug.cgi?id=60940 --- Comment #9 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 112201 merged by QChris: Keep status:closed's limit below MySQL Connector/J's hard limit https://gerrit.wikimedia.org/r/112201 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60940] Gerrit throwing internal server error with status:closed queries
https://bugzilla.wikimedia.org/show_bug.cgi?id=60940 --- Comment #8 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 112201 had a related patch set uploaded by QChris: Keep status:closed's limit below MySQL Connector/J's hard limit https://gerrit.wikimedia.org/r/112201 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60940] Gerrit throwing internal server error with status:closed queries
https://bugzilla.wikimedia.org/show_bug.cgi?id=60940 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60940] Gerrit throwing internal server error with status:closed queries
https://bugzilla.wikimedia.org/show_bug.cgi?id=60940 --- Comment #4 from Andre Klapper aklap...@wikimedia.org --- (In reply to comment #3) someone else who likely remembers where the Gerrit bug tracker is https://www.mediawiki.org/wiki/Bug_management/Upstream_bugtrackers -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60940] Gerrit throwing internal server error with status:closed queries
https://bugzilla.wikimedia.org/show_bug.cgi?id=60940 Bartosz Dziewoński matma@gmail.com changed: What|Removed |Added Keywords||upstream URL||https://code.google.com/p/g ||errit/issues/detail?id=2392 --- Comment #5 from Bartosz Dziewoński matma@gmail.com --- Upstream bug seems to be https://code.google.com/p/gerrit/issues/detail?id=2392 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60940] Gerrit throwing internal server error with status:closed queries
https://bugzilla.wikimedia.org/show_bug.cgi?id=60940 --- Comment #6 from christ...@quelltextlich.at --- I can reproduce on a local gerrit that uses MySQL, so it's not limited to our wmf gerrit. Changing the database to H2 makes the error disappear. It seems the issue is limited to the MySQL backend, as the error is thrown from the MySQL connector, whose hard limit for 5000 rows is below 2^31-1. I checked gerrit upstreams stable-2.8 branch, and it does not seem to have a fix for the issue. But it might actually be a gwtorm issue, where the setMaxRows gets called :-( P.S.: Although the bug is of course valid nonetheless, searches for status:closed have never been working IIRC, as they boil down to using OR. Previously they just gave the empty result set more often than not :-( -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60940] Gerrit throwing internal server error with status:closed queries
https://bugzilla.wikimedia.org/show_bug.cgi?id=60940 --- Comment #7 from christ...@quelltextlich.at --- Although it of course sucks, you can work around the issues, by resolving the OR part of the query by hand: Like instead of curl https://gerrit.wikimedia.org/r/changes/?q=status:closed; do curl https://gerrit.wikimedia.org/r/changes/?q=status:merged; curl https://gerrit.wikimedia.org/r/changes/?q=status:abandoned; . -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60940] Gerrit throwing internal server error with status:closed queries
https://bugzilla.wikimedia.org/show_bug.cgi?id=60940 Bartosz Dziewoński matma@gmail.com changed: What|Removed |Added CC||matma@gmail.com Severity|normal |major -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60940] Gerrit throwing internal server error with status:closed queries
https://bugzilla.wikimedia.org/show_bug.cgi?id=60940 Antoine hashar Musso has...@free.fr changed: What|Removed |Added CC||has...@free.fr --- Comment #1 from Antoine hashar Musso has...@free.fr --- Same in the search box (which uses the REST API I guess). Since status:closes is equivalent to is:merged OR is:abandoned I tried that, and it fails as well. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 60940] Gerrit throwing internal server error with status:closed queries
https://bugzilla.wikimedia.org/show_bug.cgi?id=60940 --- Comment #2 from Chad H. innocentkil...@gmail.com --- Pretty sure this is the exception we're seeing (swap merged for abandoned or closed and you'll find some more): [2014-02-06 14:50:28,927] ERROR com.google.gerrit.httpd.restapi.RestApiServlet : Error in GET /r/changes/?q=is:merged+OR+is:abandonedn=25O=1 java.sql.SQLException: setMaxRows() out of range. 2147483647 5000. at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:1074) at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:988) at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:974) at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:919) at com.mysql.jdbc.StatementImpl.setMaxRows(StatementImpl.java:2745) at com.google.gerrit.reviewdb.client.Change_Access_changes_GwtOrm$$13.allClosedNext(Unknown Source) at com.google.gerrit.server.query.change.SqlRewriterImpl$13.scan(SqlRewriterImpl.java:340) at com.google.gerrit.server.query.change.SqlRewriterImpl$PaginatedSource.scan(SqlRewriterImpl.java:645) at com.google.gerrit.server.query.change.SqlRewriterImpl$ChangeSource.read(SqlRewriterImpl.java:608) at com.google.gerrit.server.query.change.OrSource.read(OrSource.java:43) at com.google.gerrit.server.query.change.AndSource.readImpl(AndSource.java:110) at com.google.gerrit.server.query.change.AndSource.read(AndSource.java:94) at com.google.gerrit.server.query.change.QueryProcessor.queryChanges(QueryProcessor.java:261) at com.google.gerrit.server.query.change.QueryChanges.query0(QueryChanges.java:153) at com.google.gerrit.server.query.change.QueryChanges.query(QueryChanges.java:141) at com.google.gerrit.server.query.change.QueryChanges.apply(QueryChanges.java:108) at com.google.gerrit.server.query.change.QueryChanges.apply(QueryChanges.java:41) at com.google.gerrit.httpd.restapi.RestApiServlet.service(RestApiServlet.java:306) at javax.servlet.http.HttpServlet.service(HttpServlet.java:722) at com.google.inject.servlet.ServletDefinition.doServiceImpl(ServletDefinition.java:278) at com.google.inject.servlet.ServletDefinition.doService(ServletDefinition.java:268) at com.google.inject.servlet.ServletDefinition.service(ServletDefinition.java:180) at com.google.inject.servlet.ManagedServletPipeline.service(ManagedServletPipeline.java:93) at com.google.inject.servlet.FilterChainInvocation.doFilter(FilterChainInvocation.java:85) at com.google.gwtexpui.server.CacheControlFilter.doFilter(CacheControlFilter.java:70) at com.google.inject.servlet.FilterChainInvocation.doFilter(FilterChainInvocation.java:82) at com.google.gerrit.httpd.RunAsFilter.doFilter(RunAsFilter.java:113) at com.google.inject.servlet.FilterChainInvocation.doFilter(FilterChainInvocation.java:82) at com.google.gerrit.httpd.RequireSslFilter.doFilter(RequireSslFilter.java:68) at com.google.inject.servlet.FilterChainInvocation.doFilter(FilterChainInvocation.java:82) at com.google.gerrit.httpd.AllRequestFilter$FilterProxy$1.doFilter(AllRequestFilter.java:64) at com.google.gerrit.httpd.AllRequestFilter$FilterProxy.doFilter(AllRequestFilter.java:57) at com.google.inject.servlet.FilterChainInvocation.doFilter(FilterChainInvocation.java:82) at com.google.gerrit.httpd.RequestContextFilter.doFilter(RequestContextFilter.java:75) at com.google.inject.servlet.FilterChainInvocation.doFilter(FilterChainInvocation.java:82) at com.google.inject.servlet.ManagedFilterPipeline.dispatch(ManagedFilterPipeline.java:120) at com.google.inject.servlet.GuiceFilter$1.call(GuiceFilter.java:132) at com.google.inject.servlet.GuiceFilter$1.call(GuiceFilter.java:129) at com.google.inject.servlet.GuiceFilter$Context.call(GuiceFilter.java:206) at com.google.inject.servlet.GuiceFilter.doFilter(GuiceFilter.java:129) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1307) at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:453) at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:229) at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1072) at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:382) at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:193) at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1006) at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:135) at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:116) at org.eclipse.jetty.server.Server.handle(Server.java:365) at
[Bug 60940] Gerrit throwing internal server error with status:closed queries
https://bugzilla.wikimedia.org/show_bug.cgi?id=60940 --- Comment #3 from MZMcBride b...@mzmcbride.com --- Chad or someone else who likely remembers where the Gerrit bug tracker is and has an account over there: can you please check if there's already an upstream ticket filed about this issue and if not, copy and paste this one over there and cross-reference? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
