[Bug 61298] Crasher in production

2014-03-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=61298

Arlo Breault abrea...@wikimedia.org changed:

   What|Removed |Added

 Status|PATCH_TO_REVIEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 61298] Crasher in production

2014-03-07 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=61298

--- Comment #11 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 117211 merged by jenkins-bot:
Bug 61298: Avoid need for cloning when using PHP preprocessor

https://gerrit.wikimedia.org/r/117211

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 61298] Crasher in production

2014-03-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=61298

Gerrit Notification Bot gerritad...@wikimedia.org changed:

   What|Removed |Added

 Status|NEW |PATCH_TO_REVIEW

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 61298] Crasher in production

2014-03-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=61298

--- Comment #10 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 117211 had a related patch set uploaded by GWicke:
Bug 61298: Avoid need for cloning when using PHP preprocessor

https://gerrit.wikimedia.org/r/117211

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 61298] Crasher in production

2014-02-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=61298

--- Comment #7 from ssas...@wikimedia.org ---
Just to clarify, that specific problem was on Marc's
parse-template-args-to-DOM patch. But, I think something equivalent is
happening on master as well -- i.e. token sharing between main and
sub-pipelines (which is not saying much that is not obvious from the fact that
we are cloning :-)). That is what we should investigate.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 61298] Crasher in production

2014-02-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=61298

--- Comment #8 from Arlo Breault abrea...@wikimedia.org ---
In comment 2 above I produced a test case from the crasher page that tracked
the problem down to template in template being sanitized.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 61298] Crasher in production

2014-02-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=61298

--- Comment #9 from ssas...@wikimedia.org ---
I should read the full comment thread before commenting then. :-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 61298] Crasher in production

2014-02-25 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=61298

--- Comment #5 from Gabriel Wicke gwi...@wikimedia.org ---
We should still investigate why the clone is necessary, and ideally remove it
again without ill effects.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 61298] Crasher in production

2014-02-25 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=61298

--- Comment #6 from Arlo Breault abrea...@wikimedia.org ---
There's a comment in the patch about what's going on.

Templates contained in templates get their attributes stripped when passing
through the sanitizer, affecting the original token in the main pipeline.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 61298] Crasher in production

2014-02-14 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=61298

Arlo Breault abrea...@wikimedia.org changed:

   What|Removed |Added

 CC||abrea...@wikimedia.org

--- Comment #1 from Arlo Breault abrea...@wikimedia.org ---
This is a regression introduced in 4d1f0abc7403a33f0aa4e6c0ee616f2b7b030a09.
Looking into it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 61298] Crasher in production

2014-02-14 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=61298

--- Comment #2 from Arlo Breault abrea...@wikimedia.org ---
test case here is:

echo [{{fullurl:{{{link}}}|action=edit}} editar] | node parse --prefix arwiki

fixed by putting back the token.clone() in ext.core.Sanitizer.js ~L735 but I'm
still not quite sure why that is ...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 61298] Crasher in production

2014-02-14 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=61298

Gerrit Notification Bot gerritad...@wikimedia.org changed:

   What|Removed |Added

 Status|NEW |PATCH_TO_REVIEW

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 61298] Crasher in production

2014-02-14 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=61298

--- Comment #3 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 113482 had a related patch set uploaded by Arlolra:
Fix crasher

https://gerrit.wikimedia.org/r/113482

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 61298] Crasher in production

2014-02-14 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=61298

--- Comment #4 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 113482 merged by jenkins-bot:
Fix crasher

https://gerrit.wikimedia.org/r/113482

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 61298] Crasher in production

2014-02-14 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=61298

Arlo Breault abrea...@wikimedia.org changed:

   What|Removed |Added

 Status|PATCH_TO_REVIEW |NEW

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l