[Bug 61358] Mobile view link unexpectedly goes to HTTPS

2014-06-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=61358

Florian  changed:

   What|Removed |Added

 Status|PATCH_TO_REVIEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 61358] Mobile view link unexpectedly goes to HTTPS

2014-06-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=61358

--- Comment #25 from Gerrit Notification Bot  ---
Change 137291 merged by MaxSem:
Fix incorrect value being passed in second argument of
MobileContext::getMobileUrl()

https://gerrit.wikimedia.org/r/137291

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 61358] Mobile view link unexpectedly goes to HTTPS

2014-06-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=61358

--- Comment #24 from Florian  ---
Yeah, you are right, the patch isn't backported to REL1_22.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 61358] Mobile view link unexpectedly goes to HTTPS

2014-06-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=61358

--- Comment #23 from Gerrit Notification Bot  ---
Change 137291 had a related patch set uploaded by Florianschmidtwelzow:
Fix incorrect value being passed in second argument of
MobileContext::getMobileUrl()

https://gerrit.wikimedia.org/r/137291

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 61358] Mobile view link unexpectedly goes to HTTPS

2014-06-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=61358

Gerrit Notification Bot  changed:

   What|Removed |Added

 Status|UNCONFIRMED |PATCH_TO_REVIEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 61358] Mobile view link unexpectedly goes to HTTPS

2014-06-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=61358

--- Comment #22 from Morbus Iff  ---
Incidentally, I can't use master, as there's a version checker in it which
states it requires MW 1.23.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 61358] Mobile view link unexpectedly goes to HTTPS

2014-06-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=61358

--- Comment #21 from Morbus Iff  ---
@Florian: Confused. I grabed REL1_22 from git, per
http://www.mediawiki.org/wiki/Extension:MobileFrontend - I pull all my
extensions and MW core from git vs. using the packaged downloads. Even so, the
commit isn't in the snapshot download either. It doesn't look like this patch
has been applied to REL1_22 at all - should it have been?

https://git.wikimedia.org/log/mediawiki%2Fextensions%2FMobileFrontend.git/refs%2Fheads%2FREL1_22

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 61358] Mobile view link unexpectedly goes to HTTPS

2014-06-03 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=61358

Florian  changed:

   What|Removed |Added

 Status|PATCH_TO_REVIEW |UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #20 from Florian  ---
@Morbus: Sorry, but: https://gerrit.wikimedia.org/r/#/c/91123/
:) In actual version of MobileFrontend getMobileUrl is called with only one
argument, so all ok, no need for a patch? Can you try to update MobileFrontend
and test?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 61358] Mobile view link unexpectedly goes to HTTPS

2014-06-03 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=61358

Florian  changed:

   What|Removed |Added

 CC||florian.schmidt.welzow@t-on
   ||line.de

--- Comment #19 from Florian  ---
@Morbus: Can you use Gerrit patch uploader instead? :)
https://tools.wmflabs.org/gerrit-patch-uploader/

For this tool you only need a free MediaWiki account :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 61358] Mobile view link unexpectedly goes to HTTPS

2014-06-03 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=61358

Morbus Iff  changed:

   What|Removed |Added

 Status|NEW |PATCH_TO_REVIEW

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 61358] Mobile view link unexpectedly goes to HTTPS

2014-06-03 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=61358

--- Comment #18 from Morbus Iff  ---
Created attachment 15563
  --> https://bugzilla.wikimedia.org/attachment.cgi?id=15563&action=edit
Patch to change $args to $wgMFForceSecureLogin

Patch attached. I'm not a MW developer, so I've likely screwed up the proper
workflow somewhere, but this is what's now running on disobey.com/wiki/, and is
consistent with other uses of getMobileUrl() with the second argument.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 61358] Mobile view link unexpectedly goes to HTTPS

2014-06-03 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=61358

Morbus Iff  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #17 from Morbus Iff  ---
Fact dump:

 * Old wiki, updated a number of times.
 * No core hacks or patches.
 * Never configured for https:.
 * Brand new install of MobileFrontend.
 * Vanilla enabled - no additional config past $wgMFAutodetectMobileView.
 * Running today-pulled REL1_22 of both core and MobileFrontend.
 * $wgSecureLogin is not set.

The cause is in MobileContext::getMobileUrl( $url, $forceHttps = false ),
namely that second argument. In the code, if that evaluates to TRUE, then the
scheme is set to https - the expectation for that argument is a boolean. But,
if you look in onSkinTemplateOutputPageBeforeExec(), you'll see that $args, an
array, is being passed to it. In my case, $wgMobileUrlTemplate wasn't
configured, so $args will always be an array filled with the mobileaction =>
toggle_view_mobile.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 61358] Mobile view link unexpectedly goes to HTTPS

2014-06-03 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=61358

Morbus Iff  changed:

   What|Removed |Added

 CC||mor...@disobey.com

--- Comment #16 from Morbus Iff  ---
I'm seeing this too. Still debugging. Public URL:
http://www.disobey.com/wiki/Main_Page

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 61358] Mobile view link unexpectedly goes to HTTPS

2014-05-12 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=61358

--- Comment #15 from Andre Klapper  ---
(In reply to grant from comment #13)
> I'm in the middle of a server change. Give me a day or two.

Grant: Any news?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 61358] Mobile view link unexpectedly goes to HTTPS

2014-02-27 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=61358

Arthur Richards  changed:

   What|Removed |Added

 Status|NEW |UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 61358] Mobile view link unexpectedly goes to HTTPS

2014-02-27 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=61358

--- Comment #14 from Jon  ---
Thanks for the update Grant.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 61358] Mobile view link unexpectedly goes to HTTPS

2014-02-27 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=61358

--- Comment #13 from grant  ---
I'm in the middle of a server change. Give me a day or two. Since is is a
subdoman of a different site, I wonder if the htaccess of the other site is
passing along some values. I will get back to you once I'm up and running.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 61358] Mobile view link unexpectedly goes to HTTPS

2014-02-27 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=61358

--- Comment #12 from Arthur Richards  ---
Grant, I don't see anything that suggests the problem is Mediawiki or
MobileFrontend related and I can't replicate your problem. The error your
described in your original post suggests to me that you may be dealing with a
server configuration issue, though I really can't be sure.

Is the site in question publicly visible? It may be easier for us to have a
better sense of what is happening if we can see the issue in the wild.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 61358] Mobile view link unexpectedly goes to HTTPS

2014-02-16 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=61358

jeremyb  changed:

   What|Removed |Added

 CC||bugzilla+org.wikimedia@tuxm
   ||achine.com
Summary|Mobile view lin k   |Mobile view link
   |unexpectedly goes to HTTPS  |unexpectedly goes to HTTPS

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l